Message-ID: <58224a49-654f-0026-4286-c6103d2057dc@amd.com>
Date:   Mon, 13 Mar 2023 08:47:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 3/3] drm/ttm: Remove comment referencing now-removed
 vmf_insert_mixed_prot()
Content-Language: en-US
To:     Lorenzo Stoakes <lstoakes@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Thomas Hellstrom <thomas.hellstrom@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@suse.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>
References: <cover.1678661628.git.lstoakes@gmail.com>
 <db403b3622b94a87bd93528cc1d6b44ae88adcdd.1678661628.git.lstoakes@gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <db403b3622b94a87bd93528cc1d6b44ae88adcdd.1678661628.git.lstoakes@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmRxaERIOVVIMlQ3VDBIalZrYlZaTGhnWC9WVWVNcUxKMUFXTjllOXdYRkRT?=
 =?utf-8?B?b2toVU5VNHV3SmhDWXpvLy9KQUR5SEZvTW9FUUgzZ0lmQlFPdDczRzlnWTAy?=
 =?utf-8?B?TTZVZ0wrZVJFMGtiMHIwNEhHdm5HRDdqRzFOUTdGMVlkVm1pRDhmNUZzc3Yz?=
 =?utf-8?B?VUNLN2NabG9WMlBIUzhZZWpQNkxqQ2h4SWt0YVF6MXk2UVMySXZ1WXhPQjdN?=
 =?utf-8?B?bGFwcG1RWmJkNitoeDVJS3UxTHJVVWwvSjZQb2tYcjUyOGZhNDZDc0ZDZTA4?=
 =?utf-8?B?cGJFYVQ2TGw5cjEydTk1TDhnQ1c3VVVTL2dadGJNdE9KMmR0RzNjMWFPUFh1?=
 =?utf-8?B?aWM3Q1lROWs4U0t5a3lVZjZiL0NtNGFOK25QSmtlTVY4VS9Zb2o3U0YyRGZG?=
 =?utf-8?B?cTYveThTSGk2Rkt4VkF0dzJhUXhsdEcveUVZMlh5eTRMRU1mc2M2QUJ2RGtC?=
 =?utf-8?B?MmlZWVE5MWw4dGdaT3JOZUs3ZVM0M2c2NWxsVktLYWZKdHNYdTVWaTlQVDBI?=
 =?utf-8?B?b1duZFFNd0hxRXdQNlNUNkpPVkxra3UwNmU0WnZVbHFNcForVFpDaEE5S1k2?=
 =?utf-8?B?SkxuUStjN0QxYW1qUTJuU1N0dnpFTGN2Y0pVajBrMU5HcnM2aTBDQ1RSdmJR?=
 =?utf-8?B?YlZpZkJLRml1YUR0TGVKbHA5cWVWQWxOMXRSeXJhRSs1dUU4NFZVclpyMndp?=
 =?utf-8?B?ZGFSMFNsWnpiamVFV0FtRUpkNFpkVUZJLzFrMmNuY2NKTWpoaTNnbGNlMWRI?=
 =?utf-8?B?SlpkNnBEai9BVEJoY1p1WTRlMEpWOXQ5L0hZdElZM0VPdlVYRUpjb0htWGpB?=
 =?utf-8?B?OFRtaFdkZFZXVEVHNzR1TnlGdjZxb1pwZkJ1bzA5d1lqS2ppcG5WdG5PbEx6?=
 =?utf-8?B?TVNKOElRbEVRRUJCeGo3SkZxWDZxLzRiYk03QjVhd3BYbzlQdHNoYmM3N1pn?=
 =?utf-8?B?UGtZczh2azNBdDRTOGdoc3E4aloxREl3eTB5eVJYeG12OHdZZlFkQ1VKeDYr?=
 =?utf-8?B?K2JJc1lyb3ZjbndtUktNMDZqMUtIcmkvc3BCVzV4WWxOdm5qTU9UYURCM2xa?=
 =?utf-8?B?Z0tiMEdMN3ZqY2lxeks5WktnZFRtREJPMkdSVm5SVC9qYXd1a2Fubjl0Tm1r?=
 =?utf-8?B?dHB5Z000ZERnSnFhZWozNTVaeCswSUZoUi9QTXd1ZHJuUVdadW5oYzNNZ3FC?=
 =?utf-8?B?QkVWY21acERDVVVwSmtMWVptaDVZaU56eHEyOS82aFZ5RFpXK042TjdDNFNo?=
 =?utf-8?B?eWlLSngxQ1pkTndZcm1ISGwrUEl1U09HUTcrZlF2RlZKYndsOG94bmRIUndO?=
 =?utf-8?B?Z29RQ1pBa0M5SEp4WXphWHM4M0E0Yk9EK0NrVzlWOXpVcm1OMlk3Rm11a0tS?=
 =?utf-8?B?UlYwakFyR3BFMmdGdUIrVGsxemVqb1ZBTnJTZ1hPZFg3eEYrWUd6dE83YWl1?=
 =?utf-8?B?VzBUeStPK1dQUk8ybEl0MzBjbi9qajhCWFJ6UVFLSlBvVDBOaGprWklBWVVX?=
 =?utf-8?B?UnhEMzdaVnd1RnlVYjYyWGVDcVY5YSs5Wit5R1NoWGN4Zlg4RDI4YUVoa2ZV?=
 =?utf-8?B?YmJEcUN1ZllKU3RTUUtvY0NXRThhUVhBVGtQaTRDcVU1TzZOMnZ1aTk3RW1P?=
 =?utf-8?B?R283TkppVlAvcytQaUh5SENlcXU5NnpDWTlpd1UwbUdCaFpRTUVaQVh3d2Ny?=
 =?utf-8?B?UnZLUTlqbG9UK2MzVzRlaDlmZlBhWjZ5d1JvbHRTSjluMlNXNmF6NTlDbkJE?=
 =?utf-8?B?aHJTRjVib0VQSUxrRnZabGhnTGpDR1FWNzlyN2o0U2VjL1diTFRjS2xld3Nm?=
 =?utf-8?B?cTEyZ0w1K0dYcXhTbjJtUUFrQzhUQjJFbStlNmdQN3hheWNyOUxQWCtjLzBT?=
 =?utf-8?B?UjkwbjBvdk1Ob3RRSlRqUFFaSld0V3FHRER0RlJneEppS3hTSFFmamk3Um1h?=
 =?utf-8?B?NE1MZGM3dVYxdmEzQjA0T1RnLzBFQVh5NzRuRXJtcXM3Q2s3cHVvTkhnYmI2?=
 =?utf-8?B?dmlnK3U1OHlLTmFhWHlPaTc4cFh5a1pTVkNUdU1MMkRzbWlTQTB3a2FNUUF0?=
 =?utf-8?B?enVsY1lxdUZFV1c0R3ptK3JWZkhtcEIwVVRpMktzdldtR1FZSUJvZUp0REl6?=
 =?utf-8?Q?Wdd064GY8MBF6LUq17Q3yIhQq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1cbd381-a2b8-4765-c7cd-08db239731af
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 07:47:28.5725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kPFHegJhOZgrJ7TbfmGmfIMWJv7wFjQh7YfU+vr6GfUJTykH9qaD/da26OVbOg5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4053
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.03.23 um 00:40 schrieb Lorenzo Stoakes:
> This function no longer exists, however the prot != vma->vm_page_prot case
> discussion has been retained and moved to vmf_insert_pfn_prot() so refer to
> this instead.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Feel free to add my acked-by to the other two patches in the series and 
upstream through any branch you like.

Alternatively ping me when you get rbs for the first two patches from 
the MM people and I can push this upstream through drm-misc.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_bo_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
> index ca7744b852f5..5df3edadb808 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
> @@ -254,7 +254,7 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf,
>   		 * encryption bits. This is because the exact location of the
>   		 * data may not be known at mmap() time and may also change
>   		 * at arbitrary times while the data is mmap'ed.
> -		 * See vmf_insert_mixed_prot() for a discussion.
> +		 * See vmf_insert_pfn_prot() for a discussion.
>   		 */
>   		ret = vmf_insert_pfn_prot(vma, address, pfn, prot);
>