Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20833C6FD19 for ; Mon, 13 Mar 2023 08:57:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbjCMI5A (ORCPT ); Mon, 13 Mar 2023 04:57:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230302AbjCMI4c (ORCPT ); Mon, 13 Mar 2023 04:56:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4826B4205 for ; Mon, 13 Mar 2023 01:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678697543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rn0ZDN/u4ONTQp/tmI2ypE9T4TH7mmvAAf+chBeDHxQ=; b=iTZgLC0/P4qi6wVW3VTOgc+neK97LwiLu3UNCvQ123EAUoBWPfrfR0fo/j9GFy2jwOWGWK boMb7HkDvZI7jHO2z5g5+uUfHp80tGs6CojbGf1KxkT37026QmVvDGU0lnGi3Ls4iZPUnl D7WS0FTqzCucz6zpTpB298Sx1oNGOg0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-326-j-eQXjg8ORK0ti-wx5PCJA-1; Mon, 13 Mar 2023 04:52:21 -0400 X-MC-Unique: j-eQXjg8ORK0ti-wx5PCJA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 71414800050; Mon, 13 Mar 2023 08:52:21 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3214D202701E; Mon, 13 Mar 2023 08:52:21 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 191791801CF6; Mon, 13 Mar 2023 09:52:20 +0100 (CET) Date: Mon, 13 Mar 2023 09:52:20 +0100 From: Gerd Hoffmann To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , Bilal Elmoussaoui , Jocelyn Falempe , Enric Balletbo i Serra , Christian Hergert , Albert Esteve , Chia-I Wu , Daniel Vetter , David Airlie , Gurchetan Singh , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drm/virtio: Enable fb damage clips property for the primary plane Message-ID: <20230313085220.fwvcul7sz7ycxtm4@sirius.home.kraxel.org> References: <20230310125943.912514-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310125943.912514-1-javierm@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 10, 2023 at 01:59:42PM +0100, Javier Martinez Canillas wrote: > Christian Hergert reports that the driver doesn't enable the property and > that leads to always doing a full plane update, even when the driver does > support damage clipping for the primary plane. > > Don't enable it for the cursor plane, because its .atomic_update callback > doesn't handle damage clips. > > Reported-by: Christian Hergert > Signed-off-by: Javier Martinez Canillas Acked-by: Gerd Hoffmann