From:   David Laight <David.Laight@ACULAB.COM>
To:     'Theodore Ts'o' <tytso@mit.edu>, Yangtao Li <frank.li@vivo.com>
CC:     "adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Subject: RE: [PATCH] ext4: convert to DIV_ROUND_UP() in
 mpage_process_page_bufs()
Thread-Topic: [PATCH] ext4: convert to DIV_ROUND_UP() in
 mpage_process_page_bufs()
Thread-Index: AQHZU6cIVd7TlGe9BUuq0KVFS4jPEK74cpWQ
Date:   Mon, 13 Mar 2023 09:25:20 +0000
Message-ID: <6135e1e118724e5ea3a1f7640b705cb5@AcuMS.aculab.com>
References: <20230310060734.8780-1-frank.li@vivo.com>
 <20230310232107.GE860405@mit.edu>
In-Reply-To: <20230310232107.GE860405@mit.edu>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

...
> On 32-bit platforms --- i386 in particular --- the 64-bit division
> results in an out-of-line call to a helper function that is not
> supplied in the kernel compilation environment, so not only is it
> slower, it Just Doesn't Work.

Even on some 64-bit systems a 64bit divide can be significantly
slower than a 32-bit divide - even with the same arguments.
IIRC Intel x86-64 a 64-bit divide (128-bit dividend) is about
twice the clocks of a 32-bit one. On AMD cpu they are much the same.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)