From:   Michael Walle <michael@walle.cc>
To:     andrew@lunn.ch, Linus Walleij <linus.walleij@linaro.org>
Cc:     Arun.Ramadoss@microchip.com, alexander.stein@ew.tq-group.com,
        ansuelsmth@gmail.com, bagasdotme@gmail.com, corbet@lwn.net,
        davem@davemloft.net, devicetree@vger.kernel.org,
        edumazet@google.com, f.fainelli@gmail.com, hdegoede@redhat.com,
        hkallweit1@gmail.com, jacek.anaszewski@gmail.com, john@phrozen.org,
        krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lee@kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-leds@vger.kernel.org, linux@armlinux.org.uk,
        netdev@vger.kernel.org, olteanv@gmail.com, pabeni@redhat.com,
        pavel@ucw.cz, rasmus.villemoes@prevas.dk,
        rmk+kernel@armlinux.org.uk, robh+dt@kernel.org,
        tharvey@gateworks.com, Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v8 00/13] Adds support for PHY LEDs with offload triggers
Date:   Mon, 13 Mar 2023 10:28:15 +0100
Message-Id: <20230313092815.496442-1-michael@walle.cc>
In-Reply-To: <576d57cb-481c-46ba-9e3b-d3b7e3a4ec69@lunn.ch>
References: <576d57cb-481c-46ba-9e3b-d3b7e3a4ec69@lunn.ch>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> > I think there will be a day when a switch without LED controller appears,
> > but the system has a few LEDs for the ports connected to an
> > arbitrary GPIO controller, and then we will need this. But we have
> > not seen that yet :)
> 
> The microchip sparx5 might be going in that direction. It has what
> looks like a reasonably generic sgpio controller:
> drivers/pinctrl/pinctrl-microchip-sgpio.c

That gpio controller supports both, some kind of hardware controlled
and pure software controlled mode. AFAIK the driver only supports
software controlled mode (yet?). In any case, our board
(arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi) is broken in
a way that we are forced to use the software controlled mode anyway.
Therefore, there is already such a board ;)

-michael