Message-ID: <50c21d8d-bb25-ac94-8386-36b62243b625@amd.com>
Date:   Mon, 13 Mar 2023 10:30:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v5 1/5] mailbox: zynqmp: fix counts of child nodes
To:     Tanmay Shah <tanmay.shah@amd.com>, andersson@kernel.org,
        mathieu.poirier@linaro.org, jaswinder.singh@linaro.org,
        ben.levinsky@amd.com, shubhrajyoti.datta@amd.com
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-remoteproc@vger.kernel.org
References: <20230311012407.1292118-1-tanmay.shah@amd.com>
 <20230311012407.1292118-2-tanmay.shah@amd.com>
Content-Language: en-US
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230311012407.1292118-2-tanmay.shah@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2VJQWVOMzQwTHR0L29NUEE4NksvUEZjWFg0SWdxSEg5QXNCbWNNYXlpU0dV?=
 =?utf-8?B?VGpFM0ZRWFJrNWJDdnFpMWxmVklyczJaOTBvNE1vdHV0MU9ldnE1MXRvWXZP?=
 =?utf-8?B?aTVGMlVTMkRaM09iVmxSUm1TSU9PSGlzcjJ2c1k2VjlGK3Z1dWh1K0xreUtC?=
 =?utf-8?B?S0tYT2VMbWJ1OWN6dTJYS1hlVWk5TkE5TjV0ZWlJbDljTVByY3BNbnN5ZXZx?=
 =?utf-8?B?VS9Xd3kvUlZqTE0vNmkzODgxcHlFWmZ5SXFFUWtQSXFlcjMyeEI2dVNSelNp?=
 =?utf-8?B?M3JQUDk4em00TDFwR0ZsemI3RXBBcmlvbkEzemlqam9ueXlXbzNVd2RCa1hu?=
 =?utf-8?B?MDB5YVU5SFFhbkd1WUwvRy9wNFZhSnlWOWJsTis4WFdoMUtyeVRrNkFqWDZ2?=
 =?utf-8?B?NXp3MTh3dFBFemVkQlFYMTNuRmVQay9jNkl0am8rcmRzNy92L2k2cHRzZVRy?=
 =?utf-8?B?b2VoMVlLR3lRSGhDZEkrUmZleEhEMmFSSFR5RnU0S2ZaK1NzYzh5Rk53N3hZ?=
 =?utf-8?B?dkk3UGlWWVJ6YlE2dU9DZFlER0oreGxTOUFoeUYzNmI0SU5BZXRzZGNkUTFt?=
 =?utf-8?B?UUtZaEVnNFU4dFdac0trdTFBVDBSMEkrem5mZ0RPeW1VTXJ4OXE5SjRKbFk4?=
 =?utf-8?B?b1ZuUVpwU25pRjlzNXY1TUx6aUlPMkluTnVIZjlzK0FPOVZKN3RHY3pKb1hj?=
 =?utf-8?B?bUVmdVVzWlFXYnRHRURYeDF6ZDhmRDJnZnpEWWlGOG5iM1lhRmZobTYzSHNk?=
 =?utf-8?B?VURaa2JBRTZwZFlMa1NBNVBDd3RHS0ZRajRrODhMTFU4WEJ2Z2V0ZVlPVFB5?=
 =?utf-8?B?TVpwblpqcHhsMjVPSHJrbHc4QW55NTJtay9GSll3dGlSUjZYcHVBVGJvR0NE?=
 =?utf-8?B?UHlKZjJaZnZPZWcvU2VIMHNERVUxU3ZYamxzNUZtUXZsNFgxQUo5dzJ1cmFZ?=
 =?utf-8?B?TWg3UmxiR3BLTm13WXgrRFVxempHMkpZdjdHQ1NhM3NxUVhkTU5TbXFDRTQx?=
 =?utf-8?B?NmJtN0MzMkM0UUZtR3RjVTcwN2N1TlNvcUM3STRTVzlvUmJiT1NqOTdoRk5y?=
 =?utf-8?B?UmNIcHliZ212cXFhVkx2RUpxWGJFcGcrL1MxU1BzZFQ4eGpnQi9mQjROZi92?=
 =?utf-8?B?aGFndzY5SkpPdHFyUlFuRG9ONmlWWWsxaFNoamR1OTFVWk9MbHZ1V3Y4OWMz?=
 =?utf-8?B?TTRlZklQenhvd3cwY3lVdDZONHAzQ0haZ0NEc3BDenRaNEE5WXNrcXlCS1hU?=
 =?utf-8?B?aDZCWWhVYUtaZE1wdXJ2V3hpZHhLM2kwZlMvU2EzNStkcWdsOXFCRGVDSmlo?=
 =?utf-8?B?Nm1vMnkwS0pxUkQrWDc0Uk04VVVXczIzN0NoN3hJSksvcVQvcXM0Y2wzK3Z1?=
 =?utf-8?B?VUljU3FjWS9zVTcvbVQrS1dkQlN1MnFNVDJmRlRFSEhSNjExMVZPVFRtamJz?=
 =?utf-8?B?TjZRcXUrdGZsOVFkaXRHK01RNWdvT3J0UUhLOWRzUHBCMFJiSkNraDhPSnVY?=
 =?utf-8?B?cWE4dG5QSENndmFPYXNvVkN4ZXhFeUwxYXVWYk9pYzhEdHlqY294QW1lQXBk?=
 =?utf-8?B?dFRHZUlLQXJjZkZ2c0wxYWFhcVJBaHRHQzJPL01GZm15SU1XK0RDU3JTV3A0?=
 =?utf-8?B?cVVnc1lQRXB1bGZYRUF1NTZFTy9WV0JHa203cmJwb3NpMDdwdjNBbFpkNmpS?=
 =?utf-8?B?U1FXT1c5RmROaXg3UVppeERGSHRONzJyajRmdzBIUW5KSEtoc2xUSWdJNitI?=
 =?utf-8?B?OS9CQjdGK01HYmw5NW1CMXI4S0c2ZXNWSXJrRWdTS0ltQXBydkdEMjA2Nlky?=
 =?utf-8?B?TGNtYyswcmJxU2dlb3BhM0RrWTY4Q09yVmtva1BuNGpsRVBmR05YeklFSHBk?=
 =?utf-8?B?Nmt3dlhCNGFXalo4MnR0eS9vRDVQdEVDcG1McWZHSndiRk5VeU5iRlJhck9G?=
 =?utf-8?B?cTJkc1dWVGRJUW1wNGlLR2xwL28zT3grb2hRQ3YrUndraDNkKzhvZTljWlg3?=
 =?utf-8?B?QVdMWVdPY1lRam43dm9zV3lXQnZiemQrNTdYR0FtckUrMUoxMkRnbXEvRkxM?=
 =?utf-8?B?Zy9xeVY1NzlZUG1NZjFnVXpQREhJUVNIZ0dOTWRzSzcwM3EwNGg3aDJ1Z0RL?=
 =?utf-8?Q?F9wQwsNorg80jGOglie/pyQ6U?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 415f66c9-e150-462c-b53f-08db23a5a2e6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 09:30:51.4692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5VyrA5UkrPQ1qBi4d2ifRoBUQNh+hhZo6t+Zp5ac+IMI/OghbyNGOkNRJqUfqatm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7024
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/11/23 02:24, Tanmay Shah wrote:
> If child mailbox node status is disabled it causes
> crash in interrupt handler. Fix this by assigning
> only available child node during driver probe.
> 
> Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller")
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
> 
> Changes in v5:
>    - mailbox node count should not be 0 for driver to probe
> 
>   drivers/mailbox/zynqmp-ipi-mailbox.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index a4c8d23c76e2..ae47fbac38d2 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -634,7 +634,12 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
>   	struct zynqmp_ipi_mbox *mbox;
>   	int num_mboxes, ret = -EINVAL;
>   
> -	num_mboxes = of_get_child_count(np);
> +	num_mboxes = of_get_available_child_count(np);
> +	if (num_mboxes == 0) {
> +		dev_err(dev, "mailbox nodes not available\n");
> +		return -EINVAL;
> +	}
> +
>   	pdata = devm_kzalloc(dev, struct_size(pdata, ipi_mboxes, num_mboxes),
>   			     GFP_KERNEL);
>   	if (!pdata)

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal