From:   John Garry <john.g.garry@oracle.com>
To:     jejb@linux.ibm.com, martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, bvanassche@acm.org,
        linux-kernel@vger.kernel.org, dgilbert@interlog.com,
        John Garry <john.g.garry@oracle.com>
Subject: [PATCH RESEND v2 11/11] scsi: scsi_debug: Add poll mode deferred completions to statistics
Date:   Mon, 13 Mar 2023 09:31:14 +0000
Message-Id: <20230313093114.1498305-12-john.g.garry@oracle.com>
In-Reply-To: <20230313093114.1498305-1-john.g.garry@oracle.com>
References: <20230313093114.1498305-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8wDt/idR29r3P5Fi9/CunsAbuKcxJnpZprLIrpfNlFebSDqdsYL9VevkiXX7?=
 =?us-ascii?Q?J8eXZ6CYz80WkNTSNjSPN+xuJh/5Rr7w4YlP31quJALo4omPf6QxYfR9LmQ8?=
 =?us-ascii?Q?ggY5oiIWpaX1/WQUZfUrR+Z3gAl1dI2mCuQeMlPVgICj0kPuveS/DnUgtZdi?=
 =?us-ascii?Q?yvYJv/Ch4f8qKKmhWMFmbgLws0IR/9h3KHFpPaxwaY3ko9gz6NCnb7RtWgpi?=
 =?us-ascii?Q?zkISPuFS+W36TZwqkuOmcUaBrnP33UXwRzdLvqrYZPBqFMXqXsGz3pJ4BHfg?=
 =?us-ascii?Q?EglB8Qc7L8cU6qdiJziHgESWe2JNOT/0XMjQtz6Zyo4Amu4tgo5pg/1y6zyw?=
 =?us-ascii?Q?G/3Vb/6FuVDvtvEHw1FeknFYSZg4bJlzUOklJ3PGmsRug2J9dWgVY/iexX9b?=
 =?us-ascii?Q?hBuHZ9aaW4yb5fhvzfihSLdFa/YTrDnybeHe8c6qfUBDrCD4DIR17kQa/l3e?=
 =?us-ascii?Q?2f3QtYP3KV+rLBviSTYrlP6YnF2swmSh4Dj2OoR/z3riOUdPiUIkQujYyyfd?=
 =?us-ascii?Q?y0pmZ2PVgg80kGGh81BjpcxJT8J3bjaGuUticsCO/xfGEmqaYP5cwzQF/KiA?=
 =?us-ascii?Q?EsuBid4w4nmIhJn3rnDPWAWesjrQUrDkd1+nNT6Xa1c+3D+WHKMp2OhPdRzu?=
 =?us-ascii?Q?dBANi/j/cv1g3TVqxFfQ2GcDhDTt3tI6K2AP6v/6M43reem5pWYKpE94xTqS?=
 =?us-ascii?Q?glMl8IPByBCBHiuP7Hc5XvncwwRrbL2AUswCWXc+5BTDRxkAfnJTHOFdxFMv?=
 =?us-ascii?Q?fHGvT8bKn4DcPjtgoYSHkd5ADVEFFWmFGW69fGPzFMmobG5Bf3m1WSWp/HZx?=
 =?us-ascii?Q?weH67oYr8I5pZD8CwIgl/pInOjsh0d6+IS01wqRa5bgZmrmZNDnaUVqTjBBK?=
 =?us-ascii?Q?j9vwz1B8I2Klrqi12cFLg2YZEL6a6DgEoyTTqNkmYwhEZcOO2TgRE4KieK0C?=
 =?us-ascii?Q?5kzkCDwVWDIZBumvRZFOqd0/MD0TNjdJaXNNKpTRMA1Ao+qtv2SyhTUKG6kx?=
 =?us-ascii?Q?WIfzWzzCY3pnochTpLWoIQDO7dzUBDyhrgLLck+N5LpMm3keAwlgsdya344O?=
 =?us-ascii?Q?WMsubQtnEutDftfnzpBz+cC/Q4IAr230ZYSUXKDk0flds+/dQ+htAgOUudf3?=
 =?us-ascii?Q?A90/V0IgD5P7FFuwp+Kw1ybw11iYQKUlGSum4oag1YV1TPwcu88dLwWf8yMw?=
 =?us-ascii?Q?c+T4xs3PVj4DKNQX7V8jN8yCnSdkrGeSrx1qBHVB17HJEMQxFqsqZBqTLMXg?=
 =?us-ascii?Q?1SfgTSZ6+jFZTqNZRJLCOHR8PlpfnF81UT38cMfBWsb3FfJP0LHCqv0p5ALy?=
 =?us-ascii?Q?pPHIyBwvMFW2jVE6+GY+45jC6G5vBbr+NRNzbyFaEjZ95K91h0imbytSUJnP?=
 =?us-ascii?Q?5ammS9Pcac3gt8/Feh7jcBB2yOo01QRlgsAji9Grx6kq9d4Ize6I8aA2fc2i?=
 =?us-ascii?Q?FLbVMzFPJ1BEP0whzxY6p/k39G7QS/Aoo7M+Ha5CO/YV60LzRhRY9818e9Mj?=
 =?us-ascii?Q?NFk1kvDabh3DK13WJaHgR8in9tAwTqE8hLY8fK5sLAf0T9xfnXatqDlhHWBe?=
 =?us-ascii?Q?OfsrSRX7tHARtI5rHKt+SPOTSRUZN7NVeHANAnrLgqCPS94GDrJvfgVjM6uQ?=
 =?us-ascii?Q?AQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9eaxylGaKHZ5xP+VE10XyXbupyyms9BvhLJnn18aS4L6ZcQYnCyWbKBLvT3vBVbW06Z2KZJhC1rwyhrbnXeWnoG1XenTWgbh5fpT3JFMvn2wK3WEEARAJHK6ZegAwa8zzP6UP+Qd5YRoSxY6ndU6r89fDlJiQZrABHQ3WhHtH02DW9KxsWmZ2FfBjWjh7cvC7q6oHeHLhuRLHo+0S6i5wu6uJ4s1qC739N2TPbvVgRQhUOv7C4JWPLb/W2aWUVXgPiLucKNO6bHfBND6+uDanYXo+ILMEzViqrXO937IynJLKCfDhNbEMlbhCjt+4yi9UU2kwbubgmiKskKi+AlgWk3Vsi2Bl8NmSms1aVmQMhOITEXj+tJsgpFjgbjEhlYvrwpJbtKi0tjwzLF5UOdALt4oIaEEC3HfoGcCNwRdrmiYKbNWGlG/G2xTrT8iEc/ij/rMBCmplanKPmMx84TfEHe5aXYQt+XQCUsLDaS9tm/lZCSLJq0MVijMJPcAqLn8JjrgJG4V6aPt/dHkoXcARHfJTaO0J+Lnh0jo0ac8S09kEwVOk+I3ppnvu2BVxVkndFF58ETBu8Bj/QGM6hiu4YugnmJW2twSi7zSrNKAkyPUJ2rVOVDYG2bUkIwD7uOXqJb8SQHKR+p/CG/NxE7Vt8yNWnX7c/fLyArSKFdyg7YehFYIVChDonwywZ1rk32ZCBIuUMH2HlFMWOdryanUNZoywDP2aO1050iwexeOdsrwAG/QJQ+3ahcYSW/7oFhJbrip1BhlEH6DcvIdAvqTMYDHKz/ZZhG6jrk5dxU0idxCfXfsYp8tSGt3Vkn2zV99EstLehTdQ+vlYr0YpVBD9EmHnlobthnB81ZutoUXr9M=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bbfd535b-a787-47cf-a741-08db23a5d0f3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 09:32:08.6199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6EKN1ity3l7qjeSQ2cI0UgXwygxYDX3vULtBPxK93ocfoK0qTxmBiQAcF4K+UKpIuwx6Sryt+4AvrX3bb/N5Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7048
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-13_02,2023-03-10_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 bulkscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2303130077
X-Proofpoint-GUID: vAwTx6WtlGugOwCUGLogDmpfMiZSuRRF
X-Proofpoint-ORIG-GUID: vAwTx6WtlGugOwCUGLogDmpfMiZSuRRF
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Currently commands completed via poll mode are not included in the
statistics gathering for deferred completions and missed CPUs.

Poll mode completions should be treated the same as other deferred
completion types, so add poll mode completions to the statistics.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 drivers/scsi/scsi_debug.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 1463e54179bf..073fc02f9fed 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -7531,6 +7531,13 @@ static int sdebug_blk_mq_poll(struct Scsi_Host *shost, unsigned int queue_num)
 		}
 		WRITE_ONCE(sd_dp->defer_t, SDEB_DEFER_NONE);
 		spin_unlock_irqrestore(&sqp->qc_lock, iflags);
+
+		if (sdebug_statistics) {
+			atomic_inc(&sdebug_completions);
+			if (raw_smp_processor_id() != sd_dp->issuing_cpu)
+				atomic_inc(&sdebug_miss_cpus);
+		}
+
 		scsi_done(scp); /* callback to mid level */
 		num_entries++;
 		spin_lock_irqsave(&sqp->qc_lock, iflags);
-- 
2.35.3