Date:   Mon, 13 Mar 2023 17:58:08 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>,
        <intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v2 00/27] drm/i915/gvt: KVM: KVMGT fixes and page-track
 cleanups
Message-ID: <ZA7zsAIekNA+ty0x@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230311002258.852397-1-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230311002258.852397-1-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1hk2D2RmNmBfibMNENVMvNJ/cVFsRnQ9yox8fLh5cNcIrjJEvSVRXpsvyKSO?=
 =?us-ascii?Q?JPwj1++sKzYNFDlC8mcjsxQc4NXpIvdQh3EXwC74LO0dJ0lxKID9Gq50+phX?=
 =?us-ascii?Q?KD4vmv7PmnIyeiEuUmr2ktJ1BTZpXcSL+8PefkCNcW8CAxH+5SAHojBh6Pfc?=
 =?us-ascii?Q?cC5MoNUHowXBp8J3Yv7cvK9UdeGhltotfBhfFd3hFETY6FUP8r67WJu+U79d?=
 =?us-ascii?Q?DiwhPGmg386dPAmWM/oVyAbLI8X6Czd5PeI0+DbSGz1cExPc2Vt8Jw2cknEH?=
 =?us-ascii?Q?NNdDwNnXdIqo9Wj7PF0ROYsM1ggITH9Kla/CFoGzarElUhbmO1RpneInoHii?=
 =?us-ascii?Q?/uZFVeXcA6XTIy5AvbQndtVv1QILBO8UVQoaBLn+4Ddj/DaUV8sBqx7xpeeI?=
 =?us-ascii?Q?svapKipKQXLB8zC9hCXeOxkNDB78T0r2wMNM7N43wyCaNdNcbhzDOCIl+dpY?=
 =?us-ascii?Q?dCCY/oRA6R35UFLBUbsQ3bz1X1MekleDovkjmYpaFxNxeJesg4DanwiS1dfO?=
 =?us-ascii?Q?dXhyn2X4FabdI+OkgVfBwsOfPlgmVacZg5fJz4NPgqtoGxodJQa7vklgOUF8?=
 =?us-ascii?Q?MDIlStWTrVm1DIlx9r+VJst5ts5cTmAApQjSKHcn8B6faOhGZ5+nIj/vUR1l?=
 =?us-ascii?Q?r26mMqrSz5iaQ1JET6Mnbk7DPj1eMN3t/Rcr94iLhYq6dRW9sVBK8lYDyrkV?=
 =?us-ascii?Q?wZ45YDMZcA420ymXUYL5I31Ps+CmfPUkRxlFDJe24fO6kGeUjgUgIXiggnQa?=
 =?us-ascii?Q?ZGwieQfsV71BRsUlLNwDheT/M23sBuO7jFvbk2Rb0eSx3f6+XL0WE4ONs+nh?=
 =?us-ascii?Q?x8oHH/WbFbfJkdpOvnCCLZqJUTxtWFtfMOGJGP6VbXIE8+PG8c137cOao8z4?=
 =?us-ascii?Q?87QYdBcNm/uKMJfE52sfHGBx+EFi3IFPTnSXVugAiukWQbidk9GNYpoE5J05?=
 =?us-ascii?Q?BSiWXCiUbGopemyO2KrGokwwLTNvKZGjWOrGZkmov69LrKlt40F/rG3Y9dM2?=
 =?us-ascii?Q?/2hHRP61wDaXuJ4nC7j+akZxoDdfYLZmo9s5vT9zQu12BGRj18Q4Nl8fCxp+?=
 =?us-ascii?Q?742NIS2ZzMis3TFBA8B6xDsxT9FqNq4sKBeytLzPrjE2WF15ziflo4E6h2M3?=
 =?us-ascii?Q?ldGaH9opxPcyPNl0MUeHZFog6F5zQWHgI6nd7E8H2cSouEUvIp5H13ncqqBd?=
 =?us-ascii?Q?K0Q93+OC4giA/StoIusJ8xv6m+J5TYmhZFIRPLblnLqx4hGlAM1EG1BHEfaw?=
 =?us-ascii?Q?EqspkxV7aJTwm7cne4GzO2BF1Rczv6c87iHZQwts7d4JqHARi1OGfPr16+cZ?=
 =?us-ascii?Q?MCPShgt+xzQB/5GjwfVJXHgmEzYNiJ1IJOF1fCfx9exbirRgDwABPqkVeNnx?=
 =?us-ascii?Q?8YkcxwMEYbPQwLKl9rspLtijOWfXv482nwtabAriHuulDIFRMtuDtkvQSwPz?=
 =?us-ascii?Q?jkH7qVsljGhwixc2wf/0avsZaaWBy5ARLWW7KyTyicUlk5jqdtB3msgXmT/T?=
 =?us-ascii?Q?AWsb1CH4ct0XNqeeaXe7Vg6DTf/bLG2eZ6eqaIcvHL4WqQQdnan/8Ppt2t/Z?=
 =?us-ascii?Q?cB5+rjFztdk+dtChUq2OdDePJKOdAiWTheiEfhg0o9K2pY3N5zElRNwou0yP?=
 =?us-ascii?Q?4w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 34c09832-dd67-46ef-5615-08db23acc7fc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 10:22:00.1951
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RgDb/+VgKGrqI15oKGB+Aexiv7mcvhQBsrCnybGbk4UjayFkWtQsTxCQDOINJ6lwY4JwLIvDbHqNKWxY1uy3gQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8142
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 04:22:31PM -0800, Sean Christopherson wrote:
> Fix a variety of found-by-inspection bugs in KVMGT, and overhaul KVM's
> page-track APIs to provide a leaner and cleaner interface.  The motivation
> for this series is to (significantly) reduce the number of KVM APIs that
> KVMGT uses, with a long-term goal of making all kvm_host.h headers
> KVM-internal.
> 
> As was the case in v1, tThe KVMGT changes are compile tested only.
> 
> Based on "git://git.kernel.org/pub/scm/virt/kvm/kvm.git next".
> 
> v2:
>  - Reuse vgpu_lock to protect gfn hash instead of introducing a new (and
>    buggy) mutext. [Yan]
>  - Remove a spurious return from kvm_page_track_init(). [Yan]
>  - Take @kvm directly in the inner __kvm_page_track_write(). [Yan]
>  - Delete the gfn sanity check that relies on kvm_is_visible_gfn() instead
>    of providing a dedicated interface. [Yan]
> 
> base-commit: 45dd9bc75d9adc9483f0c7d662ba6e73ed698a0b
> -- 
Thanks for the update!
It passed basic tests (gvt in a single vm) at my side.
Will do detailed review tomorrow.

Thanks
Yan