Message-ID: <770dde57-20b6-2877-53c6-b7ecf5980090@gmail.com>
Date:   Mon, 13 Mar 2023 19:39:14 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] PM / devfreq: exynos: Use of_property_present() for
 testing DT property presence
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>
Cc:     devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230310144734.1546726-1-robh@kernel.org>
From:   Chanwoo Choi <cwchoi00@gmail.com>
In-Reply-To: <20230310144734.1546726-1-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23. 3. 10. 23:47, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/devfreq/exynos-bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 027e8f336acc..d341876e7b62 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -432,7 +432,7 @@ static int exynos_bus_probe(struct platform_device *pdev)
>  		goto err;
>  
>  	/* Create child platform device for the interconnect provider */
> -	if (of_get_property(dev->of_node, "#interconnect-cells", NULL)) {
> +	if (of_property_present(dev->of_node, "#interconnect-cells")) {
>  		bus->icc_pdev = platform_device_register_data(
>  						dev, "exynos-generic-icc",
>  						PLATFORM_DEVID_AUTO, NULL, 0);

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi