Message-ID: <3c53eca1-ce62-e98d-ee52-269a09480658@iki.fi>
Date:   Mon, 13 Mar 2023 12:47:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2] USB: serial: xr: Add TIOCGRS485 and TIOCSRS485 ioctls
To:     Oliver Neukum <oneukum@suse.com>
Cc:     Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <ZA7Wh2Z/DdKOsOYr@kroah.com>
 <20230313082734.886890-1-kasper@iki.fi>
 <e426ae4c-4e49-5773-e8da-919fa2e3dc33@suse.com>
From:   Jarkko Sonninen <kasper@iki.fi>
In-Reply-To: <e426ae4c-4e49-5773-e8da-919fa2e3dc33@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

     Hello,

It uses only one flag from the struct from user. Would it be better to 
store only that to state ?

Do I need locking at all in that case ?

The whole struct is stored just in case, if someone would implement 
other functionality later.

     - Jarkko


Oliver Neukum kirjoitti 13/03/2023 klo 11.54:
>
>
> On 13.03.23 09:27, Jarkko Sonninen wrote:
>> Add support for RS-485 in Exar USB adapters.
>> RS-485 mode is controlled by TIOCGRS485 and TIOCSRS485 ioctls.
>> Gpio mode register is set to enable RS-485.
>>
>> Signed-off-by: Jarkko Sonninen <kasper@iki.fi>
>
>
> Hi,
>
> I am sorry, but locking is really broken here. All these contexts can 
> sleep.
> There is no need for a spinlock. As far as you need locking, just use 
> a mutex.
>
> Secondly, if xr_set_rs485_config() needs locking, so will 
> xr_get_rs485_config()
> or you can get the case that you return half a new and half an old 
> state to user
> space.
>
>     Regards
>         Oliver