Message-ID: <1da3c396-ffce-0473-aedb-a290d707fb19@gmail.com>
Date:   Mon, 13 Mar 2023 20:03:07 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v4 1/4] extcon: Removed redundant null checking for class
Content-Language: en-US
To:     Bumwoo Lee <bw365.lee@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        linux-kernel@vger.kernel.org
References: <20230302090143.46678-1-bw365.lee@samsung.com>
 <CGME20230302090149epcas1p35d6a66bf8b29ef159ecee93441560c58@epcas1p3.samsung.com>
 <20230302090143.46678-2-bw365.lee@samsung.com>
From:   Chanwoo Choi <cwchoi00@gmail.com>
In-Reply-To: <20230302090143.46678-2-bw365.lee@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23. 3. 2. 18:01, Bumwoo Lee wrote:
> create_extcon_class() is already Null checking.
> 
> Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
> ---
>  drivers/extcon/extcon.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index e1c71359b605..adcf01132f70 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon);
>  
>  static int create_extcon_class(void)
>  {
> -	if (!extcon_class) {
> -		extcon_class = class_create(THIS_MODULE, "extcon");
> -		if (IS_ERR(extcon_class))
> -			return PTR_ERR(extcon_class);
> -		extcon_class->dev_groups = extcon_groups;
> -	}
> +	if (extcon_class)
> +		return 0;
> +
> +	extcon_class = class_create(THIS_MODULE, "extcon");
> +	if (IS_ERR(extcon_class))
> +		return PTR_ERR(extcon_class);
> +	extcon_class->dev_groups = extcon_groups;
>  
>  	return 0;
>  }
> @@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev)
>  	int ret, index = 0;
>  	static atomic_t edev_no = ATOMIC_INIT(-1);
>  
> -	if (!extcon_class) {
> -		ret = create_extcon_class();
> -		if (ret < 0)
> -			return ret;
> -	}
> +	ret = create_extcon_class();
> +	if (ret < 0)
> +		return ret;
>  
>  	if (!edev || !edev->supported_cable)
>  		return -EINVAL;


Applied it with following edited title:
On later, please write the patch title in command form.

extcon: Remove redundant null checking for class

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi