Message-ID: <79c3cf69-8acd-e6de-c168-329954a14841@suse.com>
Date:   Mon, 13 Mar 2023 12:27:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2] USB: serial: xr: Add TIOCGRS485 and TIOCSRS485 ioctls
Content-Language: en-US
To:     Jarkko Sonninen <kasper@iki.fi>, Oliver Neukum <oneukum@suse.com>
Cc:     Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <ZA7Wh2Z/DdKOsOYr@kroah.com>
 <20230313082734.886890-1-kasper@iki.fi>
 <e426ae4c-4e49-5773-e8da-919fa2e3dc33@suse.com>
 <3c53eca1-ce62-e98d-ee52-269a09480658@iki.fi>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <3c53eca1-ce62-e98d-ee52-269a09480658@iki.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFJDRGZZaVUzSm90b09qcStBOFA5YWNlRFlzNG9ZaytjUXF0WFRRRlF4NU1J?=
 =?utf-8?B?RE9ZVERDQUl1N3lSc3pUWEQzUnNsb3BUZXRjWExLMEZwdExSeXQ4VmpXT1Av?=
 =?utf-8?B?dStwQWNKM0FkS2E3TDhia1FmU3M2NDZBM21QYUQ2V1cxM1ZQdm45VzdYRTRN?=
 =?utf-8?B?K3I1MmtENUJ0QlR6N2pkS0U2NGllKytxV0FYNkc5ZnVnSUV6VExGQjN2THM4?=
 =?utf-8?B?Y3poSkpmTlBhQWhoK1E0QVlVdERudFFvbC82My8wQ2xVdFVZSVllRVZkSzZV?=
 =?utf-8?B?aXpQaVh5Vmk3ZDBFSnB0dWNWYisySXFKYzdZenRtQlRTcmJ5UHo5WmFOaFF0?=
 =?utf-8?B?aHhOL0kzcXNWTUhHZ0JGendjeWFZNlNteVlpbWhFTkQ3NFZaa1hybVNvY0lO?=
 =?utf-8?B?S0Z0N2o3N25kVldxN2N3NlljcGZpZ2JxUzBjdDExazJIMjF1c1RTTmlVRHR2?=
 =?utf-8?B?YXpXL2d2U291R0FoWEFJS1B0ZW16TlcrTWRSMkh2ZmFpdG9YN0tlcmJITWla?=
 =?utf-8?B?aWlCaFExVlZ2a0t0VHl1aUNiNnVFVTlDb083MlAvWVhNZ2Joamc4RXdzVDRr?=
 =?utf-8?B?TjlrZ1VtN01yMDZONEFBQk9RcGpHSExQRjF4cW01Q0ZRaUcyckdBVXAzMVJZ?=
 =?utf-8?B?K204R0RpbjdTK1plcmFNdkZlUXJsZFJGM1krL2t3aDdRNWJVdDNWSkgzc3No?=
 =?utf-8?B?emV1NmU2eVlUa21zT2hsMHl5UVl3VG5EQ2dPTUhHRGpWYlViQjNUYkFOcm1K?=
 =?utf-8?B?T24zcmlzNkF3d0NHRTlLVEVTbVNPK0F6K01wRmNNS1ljQk5mV2JmTnFGZGpO?=
 =?utf-8?B?Mi9RM2J5TXJUZTlhQS9xa0lCZDI2TWtGY0NraTk2Ylhoa2w0ZFN3Y1kvNzhN?=
 =?utf-8?B?T3dmWjdrWmJzejVlRUxVQWo2b0s3NUFEc0k2NkljVE5PQnJwT29HWUlOUUtw?=
 =?utf-8?B?M1NoRThSYkFzeG9sdTdabnpvM0N4UVEyS3o0a3lZSm5iWVFSMkQxTlFKUDEy?=
 =?utf-8?B?VWVpaU1XaVRySERrUXRGV3JJQmJYTTBmalFmaURRTFNTaGVNa081YmlwR1hU?=
 =?utf-8?B?ZkRkVzJ2V1JSV09xNlJKRUllNE9ucUk3QkxoMGlOQjNnOWVCTTh0V2FXbElo?=
 =?utf-8?B?Mk1zL0I3QnZJenFkR0R2OGNYNXRRbmg4cm03WTNaRFArSkxUVEd0UWx5Y0Fi?=
 =?utf-8?B?SHcwRkdCemtmR2lLM3NDVm9IemhQRW9PdHRYS3haemdsNStpSzdPRS9mbUVD?=
 =?utf-8?B?SXN0UEttVnJNRjZyUVppdjRlQkQ5NzRMY2hJdkF3bU8zbmxHbjBTb1VwcjFS?=
 =?utf-8?B?WG5IVGpwd21GRWhaNGFvYlRIcnlySTZTWjR6bGM4djNxT1B3ZGNZelZMbUdp?=
 =?utf-8?B?cHpyS3dVNXBKd3VsVVduVFZiWXlCN2N5bzVjeUZrL3JvcllnZHJmMzdFbG5v?=
 =?utf-8?B?b3FXQUE2V3ZjSUdIM3dwK1oyZXNLZVlDQzVkSTRaNlRiRllIVjhrdmNiSjVC?=
 =?utf-8?B?ZzFWeFI3UkJqK2VMRTFKYTBMb0ljMzF2SGlXQWRweTVYdzRpQ0VMY0pUaWZZ?=
 =?utf-8?B?ZnRxZVQvdmpKL2dtU0pXb1VmZ0lqa3dLcCtkTDFvVnhGRm1kUExhM0M3TGpS?=
 =?utf-8?B?K0JFUExxd1BYamN6c1Mvbllxa0xSSFR6SXRFSDFZN3lXOEdQckJjZnFNS2pX?=
 =?utf-8?B?aC93Skp4M2xMTGswZmRYb3VwZnpVVXJLUnZZWlBlbS9PeHAwaEN5T2hVNFUy?=
 =?utf-8?B?d1pKdVJmbW9mY0kzellrdXFLWWU2eEEzcGJhVzVIY1k4c2FJL29hR0syc1dL?=
 =?utf-8?B?UlNKTWJwdTl5MjRuOG9taG53QjhGNkYzZHlDdDUwalJ2M0NHaU5OV3BLOHoy?=
 =?utf-8?B?LzNFRTFhSjlHT294eGU2anlKSUVUNWQ2bTBSYlhVNFZIMWVzd1F0cmhWb2Fy?=
 =?utf-8?B?L0lBdC81TWZMYU1wZ1l5cWtwLzAvT1pXOHd2N2lNOEx3T284SmJlUnhYMEJI?=
 =?utf-8?B?VjdQVGprWVdwQlJiVFFpbW5tVTJTUXg2bVA0NmU0UG5ZeDNQbm5TakNwNjZl?=
 =?utf-8?B?V3l2R0MzeXRaMDI5YWt1NWdoN2FZUHVpSWYvZEpFWTFYSGpQanB6TEFnK0hj?=
 =?utf-8?B?UFJCT1dqNndJT28xeHcxWFBubVMrMmNCcXhRZlVEbVdQNkpyOW0vNkp6WW9z?=
 =?utf-8?Q?S2rXbx/KKSOiw3ZVXFFD9984ZtEooGfHfZkUnrPIHJUX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74fced05-bc14-4282-c2e3-08db23b5e6ee
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 11:27:17.6016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U3FllfC43w4EkHCMD6UVMsIA/U/fLYc7kfCuGqAb71r3pnyS2NuFCeBATVBh+PltZDSBWfYQ1kCrl2xju9xV7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8427
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 13.03.23 11:47, Jarkko Sonninen wrote:
>      Hello,
> 
> It uses only one flag from the struct from user. Would it be better to store only that to state ?
> 
> Do I need locking at all in that case ?
> 
> The whole struct is stored just in case, if someone would implement other functionality later.

Well,

1. would you be happy if you were the one to implement additional
features and found that you'd have to reinvent locking?

2. That would mean discarding the values given for delay_rts_before_send
and delay_rts_after_send. That wouldn't be nice.

It seems to me that all our algorithmic complexity goes away
if you just turn "lock" into a mutex and just take it.

	Regards
		Oliver