Date:   Mon, 13 Mar 2023 13:34:24 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     Mario Limonciello <mario.limonciello@amd.com>,
        Jan =?utf-8?B?RMSFYnJvxZs=?= <jsd@semihalf.com>,
        Grzegorz Bernacki <gjb@semihalf.com>, Rijo-john.Thomas@amd.com,
        Thomas.Lendacky@amd.com, herbert@gondor.apana.org.au,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Felix.Held@amd.com, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 8/8] i2c: designware: Add doorbell support for Skyrim
Message-ID: <ZA8KQIeRUtAXbkTV@smile.fi.intel.com>
References: <20230310211954.2490-1-mario.limonciello@amd.com>
 <20230310211954.2490-9-mario.limonciello@amd.com>
 <b18aefc2-dd07-5356-0d19-b4783ed500e6@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b18aefc2-dd07-5356-0d19-b4783ed500e6@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Mar 13, 2023 at 12:29:50PM +0200, Jarkko Nikula wrote:
> On 3/10/23 23:19, Mario Limonciello wrote:

...

> > +	if (rdev->device == 0x1630)
> > +		_psp_send_i2c_req = psp_send_i2c_req_cezanne;
> > +	else
> > +		_psp_send_i2c_req = psp_send_i2c_req_skyrim;
> 
> Is there any possibility pci_get_domain_bus_and_slot() returns NULL? Or is
> 00:00.0 always present?

Theoretically it's possible in two cases (or more?):
1) no PCI support compiled;
2) no device found (PCI-less system).

-- 
With Best Regards,
Andy Shevchenko