Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E74BC74A4B for ; Mon, 13 Mar 2023 11:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231301AbjCMLrk (ORCPT ); Mon, 13 Mar 2023 07:47:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231151AbjCMLrc (ORCPT ); Mon, 13 Mar 2023 07:47:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E289A18AA7; Mon, 13 Mar 2023 04:47:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 701C0B81059; Mon, 13 Mar 2023 11:46:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75B65C433D2; Mon, 13 Mar 2023 11:46:48 +0000 (UTC) Message-ID: <4f33e492-cd5b-b9eb-f037-85062f27dbde@xs4all.nl> Date: Mon, 13 Mar 2023 12:46:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 03/28] media: cec: tegra: drop of_match_ptr for ID table Content-Language: en-US To: Krzysztof Kozlowski , Joe Tessler , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Manivannan Sadhasivam , Michael Tretter , Pengutronix Kernel Team , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Rui Miguel Silva , Wenyou Yang , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Patrice Chotard , Yong Deng , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Lad, Prabhakar" , Ezequiel Garcia , Philipp Zabel , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> <20230312131318.351173-3-krzysztof.kozlowski@linaro.org> From: Hans Verkuil In-Reply-To: <20230312131318.351173-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2023 14:12, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). This > also fixes !CONFIG_OF error: > > drivers/media/cec/platform/tegra/tegra_cec.c:457:34: error: ‘tegra_cec_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans Verkuil Thanks! Hans > --- > drivers/media/cec/platform/tegra/tegra_cec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c > index 5e907395ca2e..7115636ca748 100644 > --- a/drivers/media/cec/platform/tegra/tegra_cec.c > +++ b/drivers/media/cec/platform/tegra/tegra_cec.c > @@ -464,7 +464,7 @@ static const struct of_device_id tegra_cec_of_match[] = { > static struct platform_driver tegra_cec_driver = { > .driver = { > .name = TEGRA_CEC_NAME, > - .of_match_table = of_match_ptr(tegra_cec_of_match), > + .of_match_table = tegra_cec_of_match, > }, > .probe = tegra_cec_probe, > .remove = tegra_cec_remove,