Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B5B1C6FD1C for ; Mon, 13 Mar 2023 11:57:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230097AbjCML5H (ORCPT ); Mon, 13 Mar 2023 07:57:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbjCML4s (ORCPT ); Mon, 13 Mar 2023 07:56:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 640C3274B3; Mon, 13 Mar 2023 04:56:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C75CB80DFD; Mon, 13 Mar 2023 11:56:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00EDDC433EF; Mon, 13 Mar 2023 11:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678708565; bh=aYab9G0GQpUestpPo8muQjMDnq5FPhxPRLKOeNTUbdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y646vg5fN164JQu6ZOeYkNbRzn71xk9/gOomVKs81RV6ySjJ9E5VAkPYgM6dELr2H MQ2hfqgsV8efyjpBFSRbcqL3K/8PrVGsJSfxdH4WFibL2wusqNw9iRNhO7RMAEuq43 mpRd1tlUqFKwBI0IIpk8DorBM1u4H2kIzN4Ph1g2YVdzqUJgshdXSgUySwpSbFcmVh FVl41F2tLCkcHob0XSz/LmylHUv78rZM0++tUCCHax5349R2fQdyHFX+sKwBxZMsjW N646FpqOvSnpJkpkiOtXfz7Fhz3dqnQ0ycxBLzAK/KybsTSHjnIkNSPjzbXDu+bzXz HYd6ku8KW32mg== Date: Mon, 13 Mar 2023 13:56:01 +0200 From: Leon Romanovsky To: Daniil Dulov Cc: Bernard Metzler , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] RDMA/siw: Fix potential page_array out of range access Message-ID: <20230313115601.GB135453@unreal> References: <20230227091751.589612-1-d.dulov@aladdin.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230227091751.589612-1-d.dulov@aladdin.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 27, 2023 at 01:17:51AM -0800, Daniil Dulov wrote: > When seg is equal to MAX_ARRAY, the loop should break, otherwise > it will result in out of range access. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: b9be6f18cf9e ("rdma/siw: transmit path") > Signed-off-by: Daniil Dulov > --- > drivers/infiniband/sw/siw/siw_qp_tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, applied and changed as Bernard suggested.