Message-ID: <6f9453d7-d7c0-62ff-c7e9-42067a9fb207@amd.com>
Date:   Mon, 13 Mar 2023 08:00:29 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] drm/amd/display: Write to correct dirty_rect
To:     Benjamin Cheng <ben@bcheng.me>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20230313004739.3110719-1-ben@bcheng.me>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230313004739.3110719-1-ben@bcheng.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlB3QStCZ1BtMkxBOERFVEVTenFXT0VtUWxxZ3lDMU9kckNXa2FFT01JcU0y?=
 =?utf-8?B?enovT2Z6N2JsTkxpQ21zMWNQSkNWbkhtUTZiQ2QxKzhMNjJnczh2ZE4xVVV1?=
 =?utf-8?B?d3dKRHdUa2xzZStvQTZ3T0N2eVF0N2l3MHdSWmVDYWd6ZVQySkdoakljZ1lo?=
 =?utf-8?B?QlNFc3pSMjhCdzVzQlQyWWUvVG9rcFBYU3kwNFJzYnF6cnNzTFJIb2RjMUUv?=
 =?utf-8?B?SnoxZFZwMTA1N3NLcXNlaHFOendtQm90UWtlSW94TWNoY2RCTzRxRjRBbkZE?=
 =?utf-8?B?S2s5QUlNenFvTnp4TWMwT1RmS1R1WnZKZkYxY1BYbExkdld1Nk9DUWNWdDJi?=
 =?utf-8?B?bGVreWhZVmgrTEEzdm56YW1YQmpOdlZuRFpjSEVoRW94V3A2VSttaTkzQTJu?=
 =?utf-8?B?ampQL0szaitYVjNVMmgvSEhNVC9LalcwZEV0dzZPVGVGUi9GdTdUS1c2aFYr?=
 =?utf-8?B?SEVOTUJUY2hjVlJnNitXTlpFbG1xRDg2M1JORlBlZHgwalVINENuVllQY0pI?=
 =?utf-8?B?VHpzOG5kQzhqQUNBNTMvc3Q2NDhJZjRsTUszSTN0RWpQQ1pZY3VrbzdXQXBz?=
 =?utf-8?B?SGtNS0JOYjZRaklZSkFOQ0EyQmM2bU1id2hEeFJpLy92K1lYYmMzMFBWcEE4?=
 =?utf-8?B?ZjAvVVVyNlUzREZXNHJxcGhoUURlZzgwY29uYlhRWXVkTFIwQThENlpJK3Bx?=
 =?utf-8?B?bzdUVmhSSmc1U1ZZbm81dVJNMTdsZ0pTeDJkWTEzWTNvSnh5czV2M2Q1YnQr?=
 =?utf-8?B?Yk15NnZIaFJDdVpPNGliWEVxblZKSjY3TEpXaW1ZY1FUczVIa2JHdFJFOEJV?=
 =?utf-8?B?Ly9EU0tmRyt3Wk54K0FhSDJ2YmNhRXlTRndrV2wvN3VKNTJCWkJOZnI4czFk?=
 =?utf-8?B?T29pbm0waWVIK2xMQk81cm12TWtwK01pbElhR2lhN1VzNE9nL0hqcEdWbDNN?=
 =?utf-8?B?UkVmNFlhZzR6NFN2UnFNbU43M3ViTENKaHR6OTFvWmwrRGhrRWJWSnVFOFJ0?=
 =?utf-8?B?bVE2TTRJUHhYalcwQU5tbjZzVHZTcnJXcVJ6L2xwQzBjdjRzdG9ya3B2T3hj?=
 =?utf-8?B?KzV5Vy9BZ3laa2h2dkN0d2wzZGhKVnJvRzNhSWtxcUErY3BNVzd6Zy81bTBi?=
 =?utf-8?B?UmNPcVBHaFdWVDBVaXpMTDlLa2ZVUlZueHA0cmdkT2VNU2JFREZYaTQ3NW1i?=
 =?utf-8?B?dmIycWpmNVRlOXRzZUU4QkhEbW1lMmtwTkRzSDB3SHFlK0MvdWUrdlBBRDRO?=
 =?utf-8?B?b0dvTTZWRDRLMjYrNUdUT3Z3bmt2NWVIZEhNaHkxNThLVlFkMkZCemxqSHhZ?=
 =?utf-8?B?VHltOXNRWFBnb0dvMzV4Q0RPcEFxZzVmUndtejZXYkYxNWlENk51bGF1Kytz?=
 =?utf-8?B?RzYyeGMwbFBuYzF0bVl3UXZvZXZYM3RiVlJGa1JhZWVueUszWE1XN2kxS0t1?=
 =?utf-8?B?eEpjb09EZHg4N0VncnNTR2ZramdDTlFxMUFVd2JoTWNzNzRsVm9mNkxuSnNJ?=
 =?utf-8?B?azZJQXk4Q3NYSVlYY1E0SEwxUS9LNlRwMVIxSjNFdVBOVVVjZlBFZjRHaitt?=
 =?utf-8?B?QUNraUlOUm5yVWc0d1FRU1pYNGRwREl5Yzl2Z3VGVGhRRWdpMnJodEtoTXRo?=
 =?utf-8?B?c1d3SUExVTQxMVVuT2VFa09yNFg5Qm1tYWhXRU1TczUyVUd0Z1Mycml0UDAy?=
 =?utf-8?B?OEs1eWx6YWxPRm1wRjRRRGlHSkxjcmFNNmxFM3hFbUZ6b2NoMjlrNVVEbkxT?=
 =?utf-8?B?SVpScTB4WmEwcXA0Z2dVa3BmMXRJajkwdWY3cURqc2NqSEFNbkozWVpwTVFa?=
 =?utf-8?B?T0IwM2NHL3BiZHFNdnJ4YXQrdStMY1hDVjNLcjlmbnRCdEhCQ0MxKzRXZnNa?=
 =?utf-8?B?QjEwYzUvRWxKTFppRW9ma2laRU0ycE5DNjRESG5NdlFEZVEzT3pkcktNZ0Uv?=
 =?utf-8?B?K280eDUrSHZFSzZ2b0EvQlEzRWJraW1QMCtqWmZYYXlLejIwN2d3Tm1UbWFD?=
 =?utf-8?B?Ujd2VmIwTGp3NnZ6N0RNem5rUnM4cUE2SjV2VkVha1pvTURwSG9Qd1dPYlJP?=
 =?utf-8?B?Tk9uYkJCKzI2M3pHZHB2Yk1xc1RtcTdiOEIzWSsvcXAxbmtTU2xiWk8rV2x6?=
 =?utf-8?Q?JZLqrBG2emlHNQ4ko7BeA5mTY?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7242c861-9bc6-4adb-4577-08db23ba5cc7
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 11:59:13.2072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rrna/HB16s7X/MMjQBJtTHpPaIKpUScbzjc0sSu/A79YDyKo4kVbSFPE/YgR7ng9SoKFmI3EIJHGxnSqbDn0tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7964
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/12/23 20:47, Benjamin Cheng wrote:
> When FB_DAMAGE_CLIPS are provided in a non-MPO scenario, the loop does
> not use the counter i. This causes the fill_dc_dity_rect() to always
> fill dirty_rects[0], causing graphical artifacts when a damage clip
> aware DRM client sends more than 1 damage clip.
> 
> Instead, use the flip_addrs->dirty_rect_count which is incremented by
> fill_dc_dirty_rect() on a successful fill.
> 
> Fixes: 30ebe41582d1 ("drm/amd/display: add FB_DAMAGE_CLIPS support")
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2453
> Signed-off-by: Benjamin Cheng <ben@bcheng.me>

Applied, thanks for catching this!

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8af58bba503f..a89ec2cc4ffc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -5130,9 +5130,9 @@ static void fill_dc_dirty_rects(struct drm_plane *plane,
>   
>   		for (; flip_addrs->dirty_rect_count < num_clips; clips++)
>   			fill_dc_dirty_rect(new_plane_state->plane,
> -					   &dirty_rects[i], clips->x1,
> -					   clips->y1, clips->x2 - clips->x1,
> -					   clips->y2 - clips->y1,
> +					   &dirty_rects[flip_addrs->dirty_rect_count],
> +					   clips->x1, clips->y1,
> +					   clips->x2 - clips->x1, clips->y2 - clips->y1,
>   					   &flip_addrs->dirty_rect_count,
>   					   false);
>   		return;

-- 
Hamza