Date:   Mon, 13 Mar 2023 13:11:03 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jason Xing <kerneljasonxing@gmail.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next] net-sysfs: display two backlog queue len
 separately
Message-ID: <ZA8S14QtdBduQEVq@corigine.com>
References: <20230311151756.83302-1-kerneljasonxing@gmail.com>
 <ZA4huzYKK/tdT3Ep@corigine.com>
 <CAL+tcoDi5fVWjyTX6wjJGKrszqL6JWkEgDBajhZchYSW7kyhGQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAL+tcoDi5fVWjyTX6wjJGKrszqL6JWkEgDBajhZchYSW7kyhGQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkpUejdEbG5BYnhBNC95M0d6QkNNLzlRb1BkRFdqb2ZzekpKMmMrZFB5V1Z6?=
 =?utf-8?B?TG52dGZ3VnVNZFRWVm9VYnhvNGN4RkZCMnB1TTNwWVltc2p5Ynk1Wmw5dkJ0?=
 =?utf-8?B?UGZXTSt4Q3VBRDU2b1ZBR0FmdTF6Y3ExS1Vvb2kyeTVVbWpOTGhEQ0JQUHZH?=
 =?utf-8?B?SW1IRy93RWk0QUtUR29JUzZGUFhnS1NKaFZBNkxrdkVsY25FQTJtWW1rdVJI?=
 =?utf-8?B?NHZUQ1NYclZFZmlZS1FDY2NHaDl4WmFIR2kwZUVMUXl3SWVab3k0SG1pejZo?=
 =?utf-8?B?OXNqVXlTbitYeVBEZUQ1VmV6ckFCTTNRcG5mOUNaWUhCbHhja0wzL1MxQUdm?=
 =?utf-8?B?eUkrSVFxcGp6SVE5VkU3YWxsYm1aekJqRHk4WmFzL24zeXc5MXgwbWZBZ2gw?=
 =?utf-8?B?cnp4cVV4a0FxS1dTL3RTd3Q1Ylk2clA4T0hOR1RTQjIxZk03azF0Y2tpeEgz?=
 =?utf-8?B?a0NySEVEZVI2V0VTUDIzS2NvS00xTHNvSFJDa1V3bXlVMC9BbUhUdXJBM3du?=
 =?utf-8?B?RDNrZTRzQ0JrNXZIN3RKMWRYaTZlWWpQNTZYMEtKcm8vNm90S2p6aGJrNnpS?=
 =?utf-8?B?NTdibDRIbHNaYy9OZURCV2l3MGFoZmxKUEpoc3FEcUdpSEtiUWNvUFAwYUlP?=
 =?utf-8?B?ZGRYV3lhb2YyVDdJVjJ4aWFpdmNOMFByd2lsZXVsRVdRTmhTT1R3V3FUR3o5?=
 =?utf-8?B?MVY0U21BU0NKcUJReXhyVFp5RmtMaVpzbmNZSExOekU5YlJNRWhRSjZHZjV1?=
 =?utf-8?B?Z1BuLzJFb0I5c2VDUy9QVm9qYWFjOXhTd3Vqb1ViOXc5T2NkYWh6cjhKcmcy?=
 =?utf-8?B?RU0veVlLMUduUkhLUEgvNjRTbkkvMWg3dEp5THRLa1dZQzVLWE54a25LODZs?=
 =?utf-8?B?U0lwSTZjcDJwdmlsWHRXc2pHVU01eUx1eVhZNjlLZGlQanNyZSt4SE1EQm5P?=
 =?utf-8?B?cUxRcGtuRzkzNWxoejJsbkxZUkJVSkN3d2ozSVhVRUZBcWJoOGZ5L1lCYTdx?=
 =?utf-8?B?WWxWSUE4ZWpvdUV0TVRxTlJBTEFtdzByeDhTNURFZDJxNUVudUZXMnBhSXo4?=
 =?utf-8?B?dHdnRWJVRHVqdnZ0ZzVzMjNvSWJKK3grNGFyWVAycEJ4RWRiQmZqM3lmVzJ3?=
 =?utf-8?B?RDR4dGVlV0Jjdjl0R1hoMHhPNFNNZmxXV1RNODhqMGJzVjFaTXozdTZWRDJI?=
 =?utf-8?B?OGNTV3k4S1puWDJ2eEMyRjdsT0JpUVpVZ0xpRjQvZVZ1S1Q5Wk9kajlNQURV?=
 =?utf-8?B?Z0VTa3ZESE5xM0VYNWlyTGY1MldZeGlCUFl4enZSNmZkV0xDTkQvOFFVZzRM?=
 =?utf-8?B?M0E1NnR5em1MOW5rWEVOaHJEcXVQUGg1bml1UjBrNlJaY2ROWU1HMUJXQlVY?=
 =?utf-8?B?VTQ1VHUwcFpXbUhoNzEzV2pPMDFmYVJrSlhhSUc3QkpEdWNlYU5kYnREWUF6?=
 =?utf-8?B?a3NjdHpmbi9IVzFlNzNlYTVBQzVCR2FNZDdlUy9jSy9SN21rWUkyZElPa3JU?=
 =?utf-8?B?TGNmUUxEU3pmVjFkVC9rdkF4dlRYNW9DNmNFeW1iVGVFNHdCaHpLSkhYYnFP?=
 =?utf-8?B?OTFadjhCeHp5cVNoVHlyS1EvUmpWblVoS250ckJJOG93TkMrRjNsNDA2NVZp?=
 =?utf-8?B?bjB1QjZsdXI5anU4dGYxbmVvRjlROHlkT1R1NkNjbU4xMTg3VUI1eGpTRW56?=
 =?utf-8?B?N2F4VkJiZm1kMjVpeEFIUWVmWHhaalNSN0o1a2hWaVowOVA0SGl2VWd3OFM4?=
 =?utf-8?B?eXk4aDdRZ3FJK2xoNWdRNDVCcTd0UE5XTGhTMHY3SktYZEJIYTlLYWNvMVNC?=
 =?utf-8?B?MDdFSlZ6MnlMaWR0eFNYTzVxVkgzaUVMQWJTZm9YMkxWcXFCRFZEMXFQRmVO?=
 =?utf-8?B?R09XUUdobmZLUkg4L0Mxc3NFYmVMZm5LdDBJUmpSelJzVDZGeE5oc1l2bE05?=
 =?utf-8?B?Nk9HVmtPRzN1aW53enExbkZqMGlKRVUyZkxrbmNPcEFsVzNoeXVoKy9udFpR?=
 =?utf-8?B?cE9KOTVkbEtDNldaMzFISUFpVWdqMjZ4M0tQL3lzMjdOQmRjdEJiU3RYNmI2?=
 =?utf-8?B?d1kvL3dxK0pmK1VGV0czUW9vWTNSbDhxZDNPMFhVSWZueEh6Y2N2QndJYitP?=
 =?utf-8?B?YXhMYUZTZ0ZrUmtZekJ3dFFKOE90cTNINVNQL1lxdW9haVF2eDg1Zk9kSjZU?=
 =?utf-8?B?ajFhK0V1ejhYY0ZTYXl3Q1NHRjR4WDZIUnc0dEIwVzF4Q1plS2lPVEk1SVlt?=
 =?utf-8?B?WWZEdWJTSktQbHpNQ3dyNGNpeHBBPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c571574-6595-4a09-7c80-08db23bc07b0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 12:11:09.4762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PxZOGKc/VFMyMjtiiXBw6z3FyrlicyGGjhrZtbokgCeB8LbWNme+AWDkRD0x/iIhKI5shE7R7G2fRySEn1kMdpBrp3Jk44TE1b7qYtJOJ0U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4807
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 13, 2023 at 09:55:37AM +0800, Jason Xing wrote:
> On Mon, Mar 13, 2023 at 3:02 AM Simon Horman <simon.horman@corigine.com> wrote:
> >
> > On Sat, Mar 11, 2023 at 11:17:56PM +0800, Jason Xing wrote:
> > > From: Jason Xing <kernelxing@tencent.com>
> > >
> > > Sometimes we need to know which one of backlog queue can be exactly
> > > long enough to cause some latency when debugging this part is needed.
> > > Thus, we can then separate the display of both.
> > >
> > > Signed-off-by: Jason Xing <kernelxing@tencent.com>
> > > ---
> > >  net/core/net-procfs.c | 17 ++++++++++++-----
> > >  1 file changed, 12 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/net/core/net-procfs.c b/net/core/net-procfs.c
> > > index 1ec23bf8b05c..97a304e1957a 100644
> > > --- a/net/core/net-procfs.c
> > > +++ b/net/core/net-procfs.c
> > > @@ -115,10 +115,14 @@ static int dev_seq_show(struct seq_file *seq, void *v)
> > >       return 0;
> > >  }
> > >
> > > -static u32 softnet_backlog_len(struct softnet_data *sd)
> > > +static u32 softnet_input_pkt_queue_len(struct softnet_data *sd)
> > >  {
> > > -     return skb_queue_len_lockless(&sd->input_pkt_queue) +
> > > -            skb_queue_len_lockless(&sd->process_queue);
> > > +     return skb_queue_len_lockless(&sd->input_pkt_queue);
> > > +}
> > > +
> > > +static u32 softnet_process_queue_len(struct softnet_data *sd)
> > > +{
> > > +     return skb_queue_len_lockless(&sd->process_queue);
> > >  }
> > >
> > >  static struct softnet_data *softnet_get_online(loff_t *pos)
> > > @@ -169,12 +173,15 @@ static int softnet_seq_show(struct seq_file *seq, void *v)
> > >        * mapping the data a specific CPU
> > >        */
> > >       seq_printf(seq,
> > > -                "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x\n",
> > > +                "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x "
> > > +                "%08x %08x\n",
> > >                  sd->processed, sd->dropped, sd->time_squeeze, 0,
> > >                  0, 0, 0, 0, /* was fastroute */
> > >                  0,   /* was cpu_collision */
> > >                  sd->received_rps, flow_limit_count,
> > > -                softnet_backlog_len(sd), (int)seq->index);
> > > +                0,   /* was len of two backlog queues */
> > > +                (int)seq->index,
> >
> > nit: I think you could avoid this cast by using %llx as the format specifier.
> 
> I'm not sure if I should change this format since the above line is
> introduced in commit 7d58e6555870d ('net-sysfs: add backlog len and
> CPU id to softnet data').
> The seq->index here manifests which cpu it uses, so it can be
> displayed in 'int' format. Meanwhile, using %8x to output is much
> cleaner if the user executes 'cat /proc/net/softnet_stat'.
> 
> What do you think about this?

I think %08llx might be a good way to go.
But perhaps I'm missing something wrt to changing user-facing output.

In any case, this is more a suggestion than a request for a change.