Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79365C61DA4 for ; Mon, 13 Mar 2023 12:16:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbjCMMQq (ORCPT ); Mon, 13 Mar 2023 08:16:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbjCMMQn (ORCPT ); Mon, 13 Mar 2023 08:16:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01BF830EB1 for ; Mon, 13 Mar 2023 05:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678709753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lXPYbBYCTYiMKrYNBmUMEnReGM9kweVlcHiDWAi6CGI=; b=HxS66h+BPtg2BhseHmqSDL6w/vu/OtZMTQm3aGkMD18sY7e2B93Oiku0doGTF9TMnhTRkB MDvyCXAwbet9BcbfTxJYPM85rYC4kTb5gnH631oepeRivR9GlxZGCWVqp3CEJhfM6WYi/4 ywtIyPQexS/GKL3ApjlVwBetPgDhv6Q= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436-UEvJZi_uMReevQpPxmO9bA-1; Mon, 13 Mar 2023 08:15:52 -0400 X-MC-Unique: UEvJZi_uMReevQpPxmO9bA-1 Received: by mail-ed1-f72.google.com with SMTP id y24-20020aa7ccd8000000b004be3955a42eso16863461edt.22 for ; Mon, 13 Mar 2023 05:15:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678709750; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lXPYbBYCTYiMKrYNBmUMEnReGM9kweVlcHiDWAi6CGI=; b=kEHJqoXzprwWnAmtWgvt9wJshn+DnynOcyBUNgptDUhCAm0WB6affMbN/va0kw/YjM dkLCq84udn6v1GJt2AlyenzC2NxDiMrLbU+bx2IeRbzdEZX5+fTsrOu2Mcb0K6yEpCqT x+BtFfmNTdlcXBhHamrkcq0XVSlG/h5o11RmT24s1SHZVq9ZAxTJ6rczFTMBLAZgLFF1 LJ9SX+FeYTtS1j0gbaCRQGmpd8ysBV+onWBkNAZx4GT8SuKTXtEXcCH0K3x+6kB9KEv+ BudjGN5PR22ofdxhBzsc28Tktfn9okExk6cdYnp7M1liJKJqHJ7sn4tZinY+7IAlVMMJ aX9g== X-Gm-Message-State: AO0yUKWXwUwInnIB9QH94KwtILFlKOsNlkMRZN4lWlcwVJASkjZt1ZFI BSYuV/tYhmEGELx64S1FEi7ZEQ7z4EQrqHvzfE/+3lZBlo+hAhGelo3GWDyI0mcyNrGhcBgyQxw XtGE1ik8ItarB3WczQWWhzSKRyojwbsa4 X-Received: by 2002:a17:906:5857:b0:878:81d7:9f77 with SMTP id h23-20020a170906585700b0087881d79f77mr30905947ejs.34.1678709750509; Mon, 13 Mar 2023 05:15:50 -0700 (PDT) X-Google-Smtp-Source: AK7set9Z5b6MLUkGKVg3T2p+PspkIBkQYBJ2aBl5xrk9I6UV7xAL0Qnjp/YptrZXGlySHUMvNN+nNA== X-Received: by 2002:a17:906:5857:b0:878:81d7:9f77 with SMTP id h23-20020a170906585700b0087881d79f77mr30905930ejs.34.1678709750285; Mon, 13 Mar 2023 05:15:50 -0700 (PDT) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id ho20-20020a1709070e9400b00927e0fb3e50sm1506984ejc.100.2023.03.13.05.15.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 05:15:49 -0700 (PDT) Message-ID: Date: Mon, 13 Mar 2023 13:15:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] backlight: apple_bl: Use acpi_video_get_backlight_type() Content-Language: en-US To: Daniel Thompson Cc: Mark Gross , Andy Shevchenko , Lee Jones , Jingoo Han , Aditya Garg , platform-driver-x86@vger.kernel.org, Matthew Garrett , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230307120540.389920-1-hdegoede@redhat.com> <20230309170911.GC96419@aspen.lan> From: Hans de Goede In-Reply-To: <20230309170911.GC96419@aspen.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 3/9/23 18:09, Daniel Thompson wrote: > On Tue, Mar 07, 2023 at 01:05:40PM +0100, Hans de Goede wrote: >> On some MacBooks both the apple_bl and the apple-gmux backlight drivers >> may be able to export a /sys/class/backlight device. >> >> To avoid having 2 backlight devices for one LCD panel until now >> the apple-gmux driver has been calling apple_bl_unregister() to move >> the apple_bl backlight device out of the way when it loads. >> >> Similar problems exist on other x86 laptops and all backlight drivers >> which may be used on x86 laptops have moved to using >> acpi_video_get_backlight_type() to determine whether they should load >> or not. >> >> Switch apple_bl to this model too, so that it is consistent with all >> the other x86 backlight drivers. >> [snip] >> Signed-off-by: Hans de Goede > > Reviewed-by: Daniel Thompson > > but... Thank you. >> --- >> A note to the backlight class / subsystem maintainers, this change >> applies on top of a similar patch for drivers/platform/x86/apple-gmux.c >> which makes that driver use acpi_video_get_backlight_type(). See: >> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans >> >> I believe it is easiest to also merge this patch through >> the platform-drivers-x86 tree, may I please have your Ack for this ? >> --- > > ... please don't treat above as an ack. Lee Jones will hopefully be > along shortly to discuss that! Understood. Regards, Hans