Message-ID: <284dddaf-86ea-f8f2-f2a8-5b7c41a4ca87@amd.com>
Date:   Mon, 13 Mar 2023 18:05:24 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2 2/3] perf/ibs: Fix interface via core pmu events
Content-Language: en-US
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     peterz@infradead.org, eranian@google.com, acme@kernel.org,
        mark.rutland@arm.com, jolsa@kernel.org, irogers@google.com,
        bp@alien8.de, x86@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, sandipan.das@amd.com,
        ananth.narayan@amd.com, santosh.shukla@amd.com,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230309101111.444-1-ravi.bangoria@amd.com>
 <20230309101111.444-3-ravi.bangoria@amd.com>
 <CAM9d7ci_dRrjq==hu5O0wD2kdN5tSJRNFf2ZtDsQ_X6UXZM3CA@mail.gmail.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAM9d7ci_dRrjq==hu5O0wD2kdN5tSJRNFf2ZtDsQ_X6UXZM3CA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjU5bXp1N1FCamhxNkt1dkErZVhwUFpCVnFHRWxXdUpXWkJVaDl1R280Rnlr?=
 =?utf-8?B?cHRaT0dPYTRqb1BjOVRyRzJsRS80NWhGUDR2ZDBHeHc2djBEblJzMWRqNkxp?=
 =?utf-8?B?M05ZYmt5cnNOcjIvVStRV1JlNWxpRU9pNUZEb0xDdXdDaGI4NjhKK3Z0QnRi?=
 =?utf-8?B?dEF1VmhhSGU3QlpFUkl4b25iMHJxa0RzcE9oL1h6bVA1RTZ1NW5JVjJOcmgy?=
 =?utf-8?B?ZGZ6Mk1PRndJOW5nR00yZVRkd2hNdjJPTkVXWEVBUkNXYmwvckRURFd3NVk0?=
 =?utf-8?B?cWZScUlLRElMeEpDKzVFYTdxS1NEcmc0UmVaTHkrVkgrMjhPWlZuSlZjdGFo?=
 =?utf-8?B?UHRLeStLK0QyS08wbmZORFBxQkZwcU5Udk9hWTBkWk9lTWRVQVJmN21paVJ2?=
 =?utf-8?B?ZGZjYzd4NVF5cURqc3NITGdRNVo3ZWZONkdUQ05qd3ZPVTNiR0JCWitybVpI?=
 =?utf-8?B?d2lkZGhkcVNRTjdJVHEyb3RDVWhjVnJjM2J4b01iVGF5Z1BlZjNTUVhvTkZF?=
 =?utf-8?B?WHdZYkVYSXlOSGVJZklIMENLb3Nwa3hjQmZ6K3hWK2M4UFZpWXhPYzF6ZDlK?=
 =?utf-8?B?aXF4alYzajltNU9CM3N4ZUdhQUtFV25QN1V3cjRhSDlTSTZvV1BpNC85NkQ0?=
 =?utf-8?B?WVRDQUplMjU4VWFuaGxWL1YvVGk4dWI0ZkZONnErY2F5L3NxOG1DRDBRRFlN?=
 =?utf-8?B?YWZ5SGY4Z3VtN1NTN3Y1clZjTTBsbXVTRkxuRzdiUGtsTGIyN0lqT0krYlA4?=
 =?utf-8?B?K0NRWmdIOTNWbnIxMnZtUVkzMmgraFZsblAwdk5YOEVieHJZMDVWdFE1Q2Rk?=
 =?utf-8?B?VDU3Vytxb01uZGVrMkJGZURML3hsSmZlNmtwQlpTNDkzdU56VWJWU3AyNG1v?=
 =?utf-8?B?anIzQXh4c2U5UEtlSU1DNVhSLzNyUWYrNzc0Y3dKWi9JQmZKOXRPZVdOQ0w0?=
 =?utf-8?B?T1duaHZsNWJQaWdzU3N5ZEhEKy9QdGhJLzg4N0E3dDRNb0trZHQ0OXV4Mmp2?=
 =?utf-8?B?cnU2MHh0a1ZGQm5xUTJhOEJUZWdRVjVsaTA2Z2J0UGdHMXpmUnFVeXdnZ3lD?=
 =?utf-8?B?SVdKN29uUnBDSFV4eFA2RllJRE9xTHRuWkNHQW8wOTJzcCtHT3BIa0JGRi9i?=
 =?utf-8?B?MnN3TlF0MnF1djl4ZDgwemNWS0RkZk9BWnVqWWJwbHhLNUZvL0FFTXVldjhk?=
 =?utf-8?B?K0NYbXRtbUsvTDlBcXY3MjlFclordXVqbmN5aDFsaWJwWFVaR0R4Qm1CT21T?=
 =?utf-8?B?eWJzUE5rNlQvckdHVDIxOWhLbUNqT1ZpYytlS0tZWElyL25BSmZkcXd1SnZh?=
 =?utf-8?B?YmZsY0h6UXJuRHdNWWZTNTFOZjFmZDlpc3lDazB4aDJrbXM5d0FiQ2o4MjR1?=
 =?utf-8?B?SUxKbjFmR3JyQUhnMG8xZ3MvSm9pQU9MR04wWXViT0lydmdwanRETkxad0Nx?=
 =?utf-8?B?eEczRzQxRy95NkJEUXczRFRSbFFteWJsRUN3ODU1emNQT2ZWNHZvREhUZ2I2?=
 =?utf-8?B?cXQ2T2doeVpTbGRYNm5XRTl1a3prUTJpdkVOaXZXckJXdTdjNTdjSGRTcUta?=
 =?utf-8?B?TjFkbE9rWGszemlpaUdQNU00L29MbWxQOVdSYjRDUWN0ZEs4QkRLSitLanZV?=
 =?utf-8?B?VXErOXU3VFp1VWVzVjhKTUJmbTkxVDRuUkZBZ2ZlQytTanY0V1R1K2Znc3hE?=
 =?utf-8?B?SnJ4SmV4VVBnbDJRdjFSOHY0YnE3MGd6Z2xJUVZwNE5rNFRhNGRiVTg4NHNt?=
 =?utf-8?B?bFRGS0pDcGZvTjlkdGlabnZLVmk0U1F1M2hQM3lQcjJIWDlGVmhibE15ODJs?=
 =?utf-8?B?VUwzVTMzdlF0SlZiN29lRmtENmhLY3JXTmJ3M202eVVLc3FxamNPbFlXb25M?=
 =?utf-8?B?bG9GMVpud2pqQlBZVXJrcGxpbkdYWjhubTVMa2N6Z1JuSjJjR3RqMGE0U0Ru?=
 =?utf-8?B?RFprUnJoT0I2eTQvcytZcjNUaUZOUHlMVHBSL3lJbEd5UnB6c2UwS0FzN3pY?=
 =?utf-8?B?N1puZDlGTEVpNnoxOHE3V1ppaGg2KzRyZFlSSDR6eVNaRUFpMzU2ZVExZkY3?=
 =?utf-8?B?T2lvMG5xQy9ydEFtS3RyN3BPK3IzSXNZTWVoSjY0emFrTnJMRUhKQmNBM3g0?=
 =?utf-8?Q?ji0YQxx3Ke2dqsKN8tTTy7zna?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23740eb3-b00e-45c0-564a-08db23bf7269
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 12:35:37.2038
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XQRR3x6qjzBAOXj7Ji4k1XKmHhgHFatFiXhpm4lFARfAk5GQSmpoNC1eVPzVeQuE6+VcDNLij9kw/O7oONcVrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4116
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +               /*
>> +                * pmu->event_init() should return -ESRCH only when it
>> +                * wants to forward the event to other pmu.
>> +                */
> 
> Can we add this to the comment in the struct pmu?  There is a
> description already for other error codes.

Sure. I'll update there if we continue with this approach.

> 
> Otherwise looks good.

Thanks,
Ravi