Message-ID: <b7e39919-a94f-3929-8814-ada801365dfe@kontron.de>
Date:   Mon, 13 Mar 2023 14:46:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask
Content-Language: en-US
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Robin Gong <yibin.gong@nxp.com>
Cc:     linux-kernel@vger.kernel.org
References: <20230310092857.3555187-1-alexander.stein@ew.tq-group.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20230310092857.3555187-1-alexander.stein@ew.tq-group.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDRESmZEZkx5YW4vWGxGck03Y0ZMMGZEbm50SmFMcDRaRWxDRHRHUStBMUNX?=
 =?utf-8?B?cVFwZElTa3BadFlIQnJoT1hQKzFvWmI4UTAzYUdDbVUxM0hIVHFBcnNFRGh4?=
 =?utf-8?B?QWlLOXVkT2I3aVlhTXA1Wkg0VnFGcktneHVLZjV3OElSZXBVOVk5czZsK2R4?=
 =?utf-8?B?ZXdBTUw2QTA3M282a0d3Y29paUFoMEtIblNFSW50QTlINXNFUFhwOGVkK1pi?=
 =?utf-8?B?UHN2ZWV0aTlONXFYT2RtdGdwbnBHbERQU2NEcTR1cWxYMlMrbDV0NHI0NHp3?=
 =?utf-8?B?TjNlRDV2a3lkL0x1czdvdkJ0bW9BK1lQWEZYMEFZM3hYZjN0SjVnREpnUXdH?=
 =?utf-8?B?VDYzRGdXcTYzZ0xpd2xnZmtwUWZxYTVESGswaFhwcUpkOEs2WjRuaVpnZkln?=
 =?utf-8?B?L0t1b083eTdhcjdzS1hPSldXS0xLYjZlUzZDWklxN240c1NseW5tVk00K0dQ?=
 =?utf-8?B?N29uL0lnN0tFd1grNHUyS0ZGWkhXb2JIUlBSS3BidjZDUTRJaDVOM2ViakVY?=
 =?utf-8?B?T1pEQkpSYkIrRXhxblAyZHZ2dk5TVmlvUkp0dUVvVm9WREIrS0hkVTU4M1Bt?=
 =?utf-8?B?NkhDMHZKbWs1eTBvZi80VFBqL1RXZm93VnorWCtXdkdha1JPQUtMTWh3RDJ4?=
 =?utf-8?B?blE4WEJVQ1N1aVlVSGhxQnIzMzZRRWYrcVFKRThIRFhkR3B1Z0lMR0ZUZWpp?=
 =?utf-8?B?REtIbDBCUCtsSkhGVzlaWDVyOTdZQ3I0Rytvc0tMQW1JQWhLUEpqbXBkb1hZ?=
 =?utf-8?B?UlN0b09HbDJsN01KNjR6QXZacE8wUzVDbTVPbnRLMndqc3ArMU41MHp5VWFC?=
 =?utf-8?B?dGhteDF4V0JwUktuMTVWWHIxOHZrUjFRRGU4S1JsTGMwU2xOM3B3L25wS0Vo?=
 =?utf-8?B?WUlkaSs3RWZCS01TL0dLS0ROeERBekdXcjVaMWhyNHBDZmV6R1llazVwMGVX?=
 =?utf-8?B?WGJiSndLY3E4Tk40TU5PSytrNzBEclhON2dqNDY1aHV2VjlzOFlZSWI4Unpi?=
 =?utf-8?B?aWR0blBUVExSTDNyYlJEZ1pJSG9qTWRwREJFUTV2cGVlL3FhWXNvRmoyVFJm?=
 =?utf-8?B?dnZBU3hiNFpxVUdXak0rNWxodkJnTFpTSlBJSHBwbm4wREc1MEJDTmtoYWRE?=
 =?utf-8?B?Y2ZGS2FlVmRQajFtcGJyNEswNGdlaEt1WHFPTnE3YmFLc25hSk93MXNwclgx?=
 =?utf-8?B?TktpeDJhWTg5YkF0SHhsMFdRVkg3YW1vSE1XWlhCRFlqcHRoWjI4QWR2LzA1?=
 =?utf-8?B?OGJNZmE4MlBQMzVjdGNBQ1RVYXFhUEM1UzJrQks4Z0txZ2JuczYyYjNSbkpB?=
 =?utf-8?B?YSs0bFA4VGpLdzdBTDE3bWE4QzdlZTl0RW03MVluZjdhWlJOZWNrS3gzVDIx?=
 =?utf-8?B?dTVueVBSb0NpcTNhQUxJSnNKcVJjZEcrUFJGV3NGcHZnY29qdGl3QjJIdU9K?=
 =?utf-8?B?VmR6Z2NQdlF0YUt3WktYbFlYd0ZDS01MUHZkN1g2bWp5OVRhUXBYWklrNHJu?=
 =?utf-8?B?TU91S1dwSEI2MXBINTdhZFBxWXd1dUZHZUczUXQzckc0Y3hCelk2cWxDM1I0?=
 =?utf-8?B?KzNtNkQrMDhVUlQwbG1sTFJmeTYxeUNQMjNzWHE0aHN0TXJ6bEpGellOSXJJ?=
 =?utf-8?B?SVRMKy83TnBmVDlRNmFHYXBKN1RlNldRSGZCeW9rWm5pWlk4N2ZvaTM4aVFP?=
 =?utf-8?B?djE0ak0rYjJKMHMzNEZkN0pxR29KUTd2cGZNS1FMaFQzTk40UWdGNlBneW1C?=
 =?utf-8?B?RnFVaFA0Z2xhY0RYc2E2TkpLYzI3eHdTNUcxYXRHc09OdUxYK2hqQzRsOTNt?=
 =?utf-8?B?dTVyV25Da0FKdE93Y1BpZ2hOaTYyY1RNLzJIUlovUmMrc0R2K1FTUm5TU0Jo?=
 =?utf-8?B?cUQ4QWM4TjBGeU95UlB3YnNxanp2UG9LcDlySm9oQ0t4ZjUzTmRpSWtzS3RU?=
 =?utf-8?B?TDhOTzRKenBHUnJLa1RhQTZJOFY3RkEwZCtkTHpzWE9IZ01OZXJrTDRtWTZS?=
 =?utf-8?B?SjRtbjJRUS8yc0dFbm9nSFFkUFRkRWwxS2VuRWxEekxKMWpRY0RkMlE2dUhW?=
 =?utf-8?B?VmwyeGRYblplT2YzaWg1dDgyZUkwRWs5UUZhdCtMZ05ZTEFIMzdtZ0I0NEFi?=
 =?utf-8?B?ZGdpS0REVWVqM1RvaWtnTEtTWXZ2R1JqWmk5WjYycW5zdGRCQWtObHk3MVlw?=
 =?utf-8?B?WlE9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea14eae-724d-4b85-9617-08db23c94deb
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 13:46:10.8097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8bcuvou/Hsyj8uAtDh4H2xq0mHs0X76QgDHAECYH2f3TcitvbqElbd+LoXrWKWlUtgWASzK4xzbci1oyXn1BiDGiSa5uhJ9R0Rxlums5l4M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB6172
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10.03.23 10:28, Alexander Stein wrote:
> This fixes a copy & paste error.

I would mention here, that this doesn't contain any functional changes
as BUCK1_ENMODE_MASK is equal to BUCK2_ENMODE_MASK.

> 
> Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
> Originally-from: Robin Gong <yibin.gong@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> This diff is extracted from a downstream commit authored by Robin Gong.
> I'm not sure if adding Originally-from: is enough here or I do have to
> change From: as well.

I never heard of "Originally-from:". Does this tag exist? Is it
documented somewhere?

I think that your tooling (git format-patch) should add a From: tag
automatically if you correctly pick up a patch from someone else.

Other than these formal issues the change itself looks good to me.

> 
>  drivers/regulator/pca9450-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
> index c84d95b11e9c..544e741f7108 100644
> --- a/drivers/regulator/pca9450-regulator.c
> +++ b/drivers/regulator/pca9450-regulator.c
> @@ -265,7 +265,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = {
>  			.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
>  			.vsel_mask = BUCK2OUT_DVS0_MASK,
>  			.enable_reg = PCA9450_REG_BUCK2CTRL,
> -			.enable_mask = BUCK1_ENMODE_MASK,
> +			.enable_mask = BUCK2_ENMODE_MASK,
>  			.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
>  			.ramp_reg = PCA9450_REG_BUCK2CTRL,
>  			.ramp_mask = BUCK2_RAMP_MASK,
> @@ -509,7 +509,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = {
>  			.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
>  			.vsel_mask = BUCK2OUT_DVS0_MASK,
>  			.enable_reg = PCA9450_REG_BUCK2CTRL,
> -			.enable_mask = BUCK1_ENMODE_MASK,
> +			.enable_mask = BUCK2_ENMODE_MASK,
>  			.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
>  			.ramp_reg = PCA9450_REG_BUCK2CTRL,
>  			.ramp_mask = BUCK2_RAMP_MASK,