Date:   Mon, 13 Mar 2023 15:46:21 +0200
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Roy Pledge <Roy.Pledge@nxp.com>, Li Yang <leoyang.li@nxp.com>,
        Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Gaurav Jain <gaurav.jain@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Yangbo Lu <yangbo.lu@nxp.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org,
        dmaengine@vger.kernel.org, netdev@vger.kernel.org,
        kvm@vger.kernel.org
Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void
Message-ID: <20230313134621.5rmzawmhv3lvis32@LXL00007.wbi.nxp.com>
References: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?B5i8T64NYVV+0AFGAs8jsVs5EXj+XBj2AdCggRWOQqzyC5xWjESJIgluSl?=
 =?iso-8859-1?Q?Sds4Zm8R869qoMmEAXmkF78kjUhKIvxQ/+4567qAGZcULMdHKNQRPary22?=
 =?iso-8859-1?Q?wlCuF1WtBLfUBkgQTQu1tks0yKialOfkLz1Bp25deDHRbbNh0YBBSw8d+t?=
 =?iso-8859-1?Q?ALQHtK8vMPlJtXVKGsPrLO0wNFnPKnQ0jzmUV8ZE5kaRIBvMl2em0v02RQ?=
 =?iso-8859-1?Q?0Tf597dQ5J3iF9F+cTK5XH0pwk9M7BIMyjlAIofkRE/gLy80qbuiCSurWN?=
 =?iso-8859-1?Q?jwZd3wxR0Nibo5p/l6LsKqnKKb/7E4BYFxLVYZJcu7NlGUMOsAC0q9tPlY?=
 =?iso-8859-1?Q?Uge0XTcY8naxS6FuHz9FQ0ytMvaW4soWlToVFRcyinZWoA/jK7HaMy/hwQ?=
 =?iso-8859-1?Q?VN5/Ko7wULCz4KF6H/ee+OTDjkipVipuypRYRkk5oObkIBCMpnxLN8RS+u?=
 =?iso-8859-1?Q?OuMM7dOalRxVHE38cju960+h7kDYbkoua64hAk/PF+5WubFmnDLSeQt6NH?=
 =?iso-8859-1?Q?L1SmH5OnY9YrGduCVyUiS6v4taUb8KoWM1lk++tjrV2LvP9OKAcEb3Xuuw?=
 =?iso-8859-1?Q?UCwvy6gL5JkSedKpvQQaGJA9bjQdDPDZyXZqY5k3MDu8oGcdGdK2kd8eEV?=
 =?iso-8859-1?Q?gjK2xREyRVSyOm9UOUL1GVIIu5lrnmkiOZnmMcPfpG55/7MF5hNmTvGeBT?=
 =?iso-8859-1?Q?LQGovQ1ZZYDIQ5t8ypxAt0CY4FKUtd2w/Jg+yyFiZqiU/e0ohD+3JHeOFQ?=
 =?iso-8859-1?Q?1gm+xPInNh3Fs32K2gsH1isHhu7o4CiR/WVMvMSGJoh3/4g++6e+TQe6oN?=
 =?iso-8859-1?Q?O4p/NBvcMlvaBIDNRSfibosaQZKvChExuKTGP4MTBem6yX5ufoDMuaQ0VF?=
 =?iso-8859-1?Q?mGx9lAbsAL9EJ0a6KEsccWptvxyIoUZ3ZC7CgoE+j7tXVwGtOfqBA8TSr4?=
 =?iso-8859-1?Q?HMxy38tDFVESxZmOEg6I6jla6PWGida7vl7kjzeZl8VQZTH8GDj+FfKJ35?=
 =?iso-8859-1?Q?8kCR6sfBYgqnl8rGrSL9IrFqobnaISupAbY3F9m5oUal17qH2vQ+qzr4SI?=
 =?iso-8859-1?Q?4ioWyWf+FdGnVXBQPo6Vzt67qmFSa+3uk6SgiuS68zY3blKSN+/yjow25V?=
 =?iso-8859-1?Q?FCEQfF4a6aaN0nln65UqyPtf/+ZrxhKu3sSRGrrN6bmV1nzKKWA21ARPIj?=
 =?iso-8859-1?Q?fQsH4EWXQwbr48sSrOwSNVlFFlhPusH6JYuvJrjTSegBiQzietXOwtXzYM?=
 =?iso-8859-1?Q?7jv//pxY7QJ3VS80yrmoK2V2UVTXTb4oIQ+kisQgtEx+90SVk0oJ2efJJQ?=
 =?iso-8859-1?Q?Pjfx5mK4uiTbo1L8rF5EfFsD2WjbyL59vuRxEnGuxOyNjwNbe/TJC7E+Qw?=
 =?iso-8859-1?Q?9z+0JTigUHgpBM8nK242Q7ZyuAB30oh5iRac9owlETgH5Qo/btApaDLbst?=
 =?iso-8859-1?Q?UZtihIAzRpois361AZ04EzJJZya6EedlRepb2nhnbJ5S4dXIOX9owvyBfA?=
 =?iso-8859-1?Q?Jg55ct9UQk9zUUR4BGeG1KpWMJITUIL0jeHI1i1NafydjFOLj/A+L4yNmZ?=
 =?iso-8859-1?Q?+O4/lAJBzexYBbgQiD1VTPdOUiMwbqkhQmn+ShNGDDzXGE4NZkpX8wrJfn?=
 =?iso-8859-1?Q?u1s0Pgx0ESWd+kneC/a3t+gU0/DUJJjvl9/4fNd1bwPQsI1T7T5jHHjQ?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a701bb84-b878-42a6-b8ff-08db23c95769
X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9055.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 13:46:28.2498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rvWiizfBB/cqLXnu63ye5XHWmzfzQeInv+HCziodOjzxZUXq8kgBJ05v0L56p9R2g9FMXYCInnc1f9lzM36GwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7306
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-K?nig wrote:
> Hello,
> 
> many bus remove functions return an integer which is a historic
> misdesign that makes driver authors assume that there is some kind of
> error handling in the upper layers. This is wrong however and returning
> and error code only yields an error message.
> 
> This series improves the fsl-mc bus by changing the remove callback to
> return no value instead. As a preparation all drivers are changed to
> return zero before so that they don't trigger the error message.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-K?nig (6):
>   bus: fsl-mc: Only warn once about errors on device unbind
>   bus: fsl-mc: dprc: Push down error message from fsl_mc_driver_remove()
>   bus: fsl-mc: fsl-mc-allocator: Drop if block with always wrong
>     condition
>   bus: fsl-mc: fsl-mc-allocator: Improve error reporting
>   soc: fsl: dpio: Suppress duplicated error reporting on device remove
>   bus: fsl-mc: Make remove function return void
> 

Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> # sanity checks