Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D979BC6FD19 for ; Mon, 13 Mar 2023 14:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbjCMOiD (ORCPT ); Mon, 13 Mar 2023 10:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbjCMOiB (ORCPT ); Mon, 13 Mar 2023 10:38:01 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AFB6AD2B for ; Mon, 13 Mar 2023 07:37:59 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id s12so13263685qtq.11 for ; Mon, 13 Mar 2023 07:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1678718276; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nAqJ0VRun7GLH0P7PDatGQQt5VcBWd3DCbBuaXJxSSc=; b=O33xqR8cnFnw9Ua8eE13pUFaX5FOsy/vDGMQDg5Q7KyLi46tmIRXE6lqIVYPLfCfZ/ +CU5NZf5CmAZD5gtZK+Pz2X3KSY8ewUTzuj/5HeAjutIDIHIBoCV8Xk0V8Wd23XN7Z3C g7hQGo5j6D1sLyMGllXEujdi1jZOU2LXy4fBs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678718276; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nAqJ0VRun7GLH0P7PDatGQQt5VcBWd3DCbBuaXJxSSc=; b=lIZBk1x7zY0F7wS7P3vuuSJKCP+I+oiD+K+mtez8yt6I92CCJJ0tOvK+Ebr2IE+Jeh G8dv+wPjEr5fSI3IuJmYEkUULlJcuHK8YJgTmKrEu7Jzg0bLqJ6/gurn76ndfG5MZIzS xCkhFJWIGvsZIcTFULfHUilz+eHjTyainWqnp+YIst0OxjSkfFkSCXxnMHxAgJlEHW1F +YEWJ123D22va8EvDfdLDDTI+lMIRr/Hw3SB7YSS4UUTsRUQ5Syrzisy+sqHiEw1c8cU iFnChW/dM9rmtvh+6eEGcZ3K0imVqRGqr0TcDNiwVIReoyL6u+cu+zcDu2YJ+fPB0AbC X9cQ== X-Gm-Message-State: AO0yUKV1J/bnKcKKnZPfE2t5bOYOJfy7VBCrJDnSStfiYzFSudRL+eon yiEg5BV7wmiz2l9R1hOdlPJ2fm9H36Ett2SeC6M= X-Google-Smtp-Source: AK7set98RSfsl26VTaeVCrKCr54MIR7qWwUPeePBXPNtCOXoPPDgzZiVHghplY1ZGBsQ1VmW1XqfEg== X-Received: by 2002:a05:622a:1895:b0:3bf:b504:d5ea with SMTP id v21-20020a05622a189500b003bfb504d5eamr27055501qtc.48.1678718276619; Mon, 13 Mar 2023 07:37:56 -0700 (PDT) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com. [209.85.128.181]) by smtp.gmail.com with ESMTPSA id o191-20020a3741c8000000b0071a02d712b0sm5425034qka.99.2023.03.13.07.37.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 07:37:56 -0700 (PDT) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-5416b0ab0ecso116498837b3.6 for ; Mon, 13 Mar 2023 07:37:55 -0700 (PDT) X-Received: by 2002:a81:a782:0:b0:541:6763:3ce1 with SMTP id e124-20020a81a782000000b0054167633ce1mr5003671ywh.2.1678718275345; Mon, 13 Mar 2023 07:37:55 -0700 (PDT) MIME-Version: 1.0 References: <20230312183622.460488-1-krzysztof.kozlowski@linaro.org> <20230312183622.460488-3-krzysztof.kozlowski@linaro.org> In-Reply-To: <20230312183622.460488-3-krzysztof.kozlowski@linaro.org> From: Doug Anderson Date: Mon, 13 Mar 2023 07:37:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/8] arm64: dts: qcom: sc7180-trogdor-lazor: correct trackpad supply To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Matthias Kaehlcke , "Joseph S. Barrera III" , Gustave Monce , Vinod Koul , Rajendra Nayak , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, Mar 12, 2023 at 11:36=E2=80=AFAM Krzysztof Kozlowski wrote: > > The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other > boards which use elan,ekth3000 with valid VCC: > > sc7180-trogdor-lazor-limozeen-nots-r4.dtb: trackpad@2c: 'vcc-supply' do= es not match any of the regexes: 'pinctrl-[0-9]+' > > Fixes: 2c26adb8dbab ("arm64: dts: qcom: Add sc7180-lazor-limozeen skus") > Signed-off-by: Krzysztof Kozlowski > --- > .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-= r4.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > index 850776c5323d..70d5a7aa8873 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts > @@ -26,7 +26,7 @@ trackpad: trackpad@2c { > interrupt-parent =3D <&tlmm>; > interrupts =3D <58 IRQ_TYPE_EDGE_FALLING>; > > - vcc-supply =3D <&pp3300_fp_tp>; > + vdd-supply =3D <&pp3300_fp_tp>; Luckily it didn't matter since this regulator is always on, but good to have things described properly. Reviewed-by: Douglas Anderson