From:   Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org,
        simon.horman@corigine.com
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com, neeraj.sanjaykale@nxp.com
Subject: [PATCH v10 1/3] serdev: Add method to assert break signal over tty UART port
Date:   Mon, 13 Mar 2023 20:10:26 +0530
Message-Id: <20230313144028.3156825-2-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20230313144028.3156825-1-neeraj.sanjaykale@nxp.com>
References: <20230313144028.3156825-1-neeraj.sanjaykale@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3kdQs/whS67AO95y4k4P1eDCBN8046vd2IeMb9FsiOwlKf0NRk22TCSE3QJA?=
 =?us-ascii?Q?lY1vgdF/rC3CKKxz1qNc5asc5h1L34YKOAlYh8Z5zCJDW6l7Lzx999POpe46?=
 =?us-ascii?Q?E07HBPSIDQlxL720TljK5SlmXzgrfhqOBBa0BgurMM3zFSvm0BCwB0f9vcZk?=
 =?us-ascii?Q?6koOweYcBO757C42jJ82R8lNCT44UQ+03kKgLJAwT18uvcl33PHsvnz3UW0T?=
 =?us-ascii?Q?gmGZTPklFstI4ggiyvbjbeJ4PusCQuc1KJ2AzxK8RE8eT7Q8AXZCEiGRO8tq?=
 =?us-ascii?Q?lj1ffsety9ttAPlqmm/cjdC/T65Vah00OyEs1YuIpT4we61/C2i/sRM/49Ub?=
 =?us-ascii?Q?NVcGkUuDLA2HjSeTZoOmKz4YZ63vRk1tpEoBBgNO0u4NReUmMXksA1H8AGQn?=
 =?us-ascii?Q?z5taPf0CgX5xSZPPXHjBX/hi4Ghy8qFAXIAdsMUMCf00ZzeelI5IaYhzFs/8?=
 =?us-ascii?Q?mdQbUpvfl3QN6Yf1qTNp3jv7v5Y0S2XXdaIs1678u23MjfNECcEwEF3vphod?=
 =?us-ascii?Q?RrS7Uq8ACfgg8CbONM6MbS2sj+fdhcPz0+6DGxh282XbWHgUfjgu1O5pBu1M?=
 =?us-ascii?Q?23zXYNKExqiauIUAg5OU1kehWXBAfrcD2C4Q0X0yBNId6uYGHytDsIEOooEf?=
 =?us-ascii?Q?RhKsl79fdsa3yr0FHKKrPEK+xFjMeNgZN0qrtTW6O/WeREAdI636El215MtZ?=
 =?us-ascii?Q?iqtLn1K5AFmlSjQdwjlsCJlVimxHYLxgpUQgztqFdPOavaWA+dy0meSWwtOF?=
 =?us-ascii?Q?Y75nkhx0YB5EfqZDk3eMV8pDMeguwvTqX5TYY7adne9eh5OBfDbvnvU3uP2w?=
 =?us-ascii?Q?sm3Tdh+Z748Nh2Y6GW9sw0afSt/F2fEv2n5KEDRiHmIlSVwcaBbt/PuF7cws?=
 =?us-ascii?Q?DJpxg7T2uR6XOINxo1+7MdDM478362ss3Wyma8Gxb4F/JY8HAL12I3RNkOFi?=
 =?us-ascii?Q?e0fo8QoPM8arh9J90ZIsy6WtF9nlL1cE8jRoOluiAbwKr+M/S615StUPEyO/?=
 =?us-ascii?Q?81ZSf6kcFMUqD7HozWXGUMuA9RmtUFaoljtE8itRAG7p4qBoEVb/950HoHL4?=
 =?us-ascii?Q?UQCBEKmkOe0ne8im2y2oj9bFhIr0icpRkjLz0kaTgcWW68GABZpqAO9sKtRY?=
 =?us-ascii?Q?6JN5WMiB0aKRv3q7Le+b6A2HCDTEOHqI6+bUy7kHRuoLRgUskMYpbptl3XyS?=
 =?us-ascii?Q?YLAHtzav/aVqDKJf77QiSo23XQLN3Y+618GmwJrwiODJzALMMOMakP1RQ52T?=
 =?us-ascii?Q?cmCuxp2hZWcDB/QrHBvJY52ur+sYu2PQ30FfyqB+Yztbe5fbzDC1VriIKljk?=
 =?us-ascii?Q?2cET0RcFRljnvx3jq9dnn1xHPbn5UyWWFGO0OIoiEX7UT6j56r+76492ybAj?=
 =?us-ascii?Q?zML7FW7wq6cCvWXoh8HOJNwl/lSShkNHrfzmZ/CraElFwecv9zvIFhGQ/rep?=
 =?us-ascii?Q?S8Lca4jxtu0AXdJ50HftsAAY0Xkddccjbib+o+fbKjCbbuiB7QkZdCBs60qP?=
 =?us-ascii?Q?hzvdDcoHtqqIkBVMKsDX1J0NxU/2FhCl8wtfZyMuXh2W5NFeeWX0MkAVn5GE?=
 =?us-ascii?Q?cirMWIBxiJhs89wjKKkpJhV3F+5Y76v0uX5uzdep6SBfj4vmQuln6s9OBwf1?=
 =?us-ascii?Q?Bw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36b358c5-ab51-4d50-34bc-08db23d0fbca
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 14:41:09.0215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nQbPwZjv8qm2fARwyq4DO3G3Csfc6x/h76dlOsaIQUJBeC83jiDtCI4HbHJggrHPhVTWiT5A79lovpMGkqsQR9UhKDiZXYl+252ZZ6kvIQk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7744
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the
underlying platform and UART peripheral supports this operation.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
v3: Add details to the commit message. Replace ENOTSUPP with
EOPNOTSUPP. (Greg KH, Leon Romanovsky)
v9: Replace all instances of ENOTSUPP with EOPNOTSUPP.
(Simon Horman)
---
 drivers/tty/serdev/core.c           | 17 ++++++++++++++---
 drivers/tty/serdev/serdev-ttyport.c | 16 ++++++++++++++--
 include/linux/serdev.h              |  6 ++++++
 3 files changed, 34 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 0180e1e4e75d..dc540e74c64d 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -366,7 +366,7 @@ int serdev_device_set_parity(struct serdev_device *serdev,
 	struct serdev_controller *ctrl = serdev->ctrl;
 
 	if (!ctrl || !ctrl->ops->set_parity)
-		return -ENOTSUPP;
+		return -EOPNOTSUPP;
 
 	return ctrl->ops->set_parity(ctrl, parity);
 }
@@ -388,7 +388,7 @@ int serdev_device_get_tiocm(struct serdev_device *serdev)
 	struct serdev_controller *ctrl = serdev->ctrl;
 
 	if (!ctrl || !ctrl->ops->get_tiocm)
-		return -ENOTSUPP;
+		return -EOPNOTSUPP;
 
 	return ctrl->ops->get_tiocm(ctrl);
 }
@@ -399,12 +399,23 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear)
 	struct serdev_controller *ctrl = serdev->ctrl;
 
 	if (!ctrl || !ctrl->ops->set_tiocm)
-		return -ENOTSUPP;
+		return -EOPNOTSUPP;
 
 	return ctrl->ops->set_tiocm(ctrl, set, clear);
 }
 EXPORT_SYMBOL_GPL(serdev_device_set_tiocm);
 
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	struct serdev_controller *ctrl = serdev->ctrl;
+
+	if (!ctrl || !ctrl->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return ctrl->ops->break_ctl(ctrl, break_state);
+}
+EXPORT_SYMBOL_GPL(serdev_device_break_ctl);
+
 static int serdev_drv_probe(struct device *dev)
 {
 	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index d367803e2044..8033ef19669c 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -231,7 +231,7 @@ static int ttyport_get_tiocm(struct serdev_controller *ctrl)
 	struct tty_struct *tty = serport->tty;
 
 	if (!tty->ops->tiocmget)
-		return -ENOTSUPP;
+		return -EOPNOTSUPP;
 
 	return tty->ops->tiocmget(tty);
 }
@@ -242,11 +242,22 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	struct tty_struct *tty = serport->tty;
 
 	if (!tty->ops->tiocmset)
-		return -ENOTSUPP;
+		return -EOPNOTSUPP;
 
 	return tty->ops->tiocmset(tty, set, clear);
 }
 
+static int ttyport_break_ctl(struct serdev_controller *ctrl, unsigned int break_state)
+{
+	struct serport *serport = serdev_controller_get_drvdata(ctrl);
+	struct tty_struct *tty = serport->tty;
+
+	if (!tty->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return tty->ops->break_ctl(tty, break_state);
+}
+
 static const struct serdev_controller_ops ctrl_ops = {
 	.write_buf = ttyport_write_buf,
 	.write_flush = ttyport_write_flush,
@@ -259,6 +270,7 @@ static const struct serdev_controller_ops ctrl_ops = {
 	.wait_until_sent = ttyport_wait_until_sent,
 	.get_tiocm = ttyport_get_tiocm,
 	.set_tiocm = ttyport_set_tiocm,
+	.break_ctl = ttyport_break_ctl,
 };
 
 struct device *serdev_tty_port_register(struct tty_port *port,
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index 66f624fc618c..c065ef1c82f1 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -92,6 +92,7 @@ struct serdev_controller_ops {
 	void (*wait_until_sent)(struct serdev_controller *, long);
 	int (*get_tiocm)(struct serdev_controller *);
 	int (*set_tiocm)(struct serdev_controller *, unsigned int, unsigned int);
+	int (*break_ctl)(struct serdev_controller *ctrl, unsigned int break_state);
 };
 
 /**
@@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
 void serdev_device_wait_until_sent(struct serdev_device *, long);
 int serdev_device_get_tiocm(struct serdev_device *);
 int serdev_device_set_tiocm(struct serdev_device *, int, int);
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
 void serdev_device_write_wakeup(struct serdev_device *);
 int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
 void serdev_device_write_flush(struct serdev_device *);
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
 {
 	return -ENOTSUPP;
 }
+static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	return -EOPNOTSUPP;
+}
 static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
 				      size_t count, unsigned long timeout)
 {
-- 
2.34.1