MIME-Version: 1.0
References: <20230307154157.1184826-1-zyytlz.wz@163.com> <43b48f87-2343-5855-e6c2-8f30319687c5@xs4all.nl>
 <f0db2bb7-01b0-c146-6643-5509e8fa4b11@xs4all.nl>
In-Reply-To: <f0db2bb7-01b0-c146-6643-5509e8fa4b11@xs4all.nl>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Mon, 13 Mar 2023 23:23:17 +0800
Message-ID: <CAJedcCws+2eK=uu2=+PLZhVVJ+0ErmG5oHSNejDenc4Qu7mpYQ@mail.gmail.com>
Subject: Re: [PATCH] media: hantro: fix use after free bug in hantro_remove
 due to race condition
To:     Hans Verkuil <hverkuil@xs4all.nl>
Cc:     Zheng Wang <zyytlz.wz@163.com>, ezequiel@vanguardiasur.com.ar,
        p.zabel@pengutronix.de, mchehab@kernel.org,
        linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-kernel@vger.kernel.org, 1395428693sheep@gmail.com,
        alex000young@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hans Verkuil <hverkuil@xs4all.nl> =E4=BA=8E2023=E5=B9=B43=E6=9C=8813=E6=97=
=A5=E5=91=A8=E4=B8=80 23:09=E5=86=99=E9=81=93=EF=BC=9A
>
> On 13/03/2023 16:08, Hans Verkuil wrote:
> > On 07/03/2023 16:41, Zheng Wang wrote:
> >> In hantro_probe, vpu->watchdog_work is bound with
> >> hantro_watchdog. Then hantro_end_prepare_run may
> >> be called to start the work.
> >>
> >> If we close the file or remove the module which will
> >> call hantro_release and hantro_remove to make cleanup,
> >> there may be a unfinished work. The possible sequence
> >> is as follows, which will cause a typical UAF bug.
> >>
> >> The same thing will happen in hantro_release, and use
> >> ctx after freeing it.
> >>
> >> Fix it by canceling the work before cleanup in hantro_release.
> >>
> >> CPU0                  CPU1
> >>
> >>                     |hantro_watchdog
> >> hantro_remove     |
> >>   v4l2_m2m_release  |
> >>     kfree(m2m_dev); |
> >>                     |
> >>                     | v4l2_m2m_get_curr_priv
> >>                     |   m2m_dev->curr_ctx //use
> >>
> >> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> >> ---
> >>  drivers/media/platform/verisilicon/hantro_drv.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers=
/media/platform/verisilicon/hantro_drv.c
> >> index b0aeedae7b65..80bd856a4da9 100644
> >> --- a/drivers/media/platform/verisilicon/hantro_drv.c
> >> +++ b/drivers/media/platform/verisilicon/hantro_drv.c
> >> @@ -1099,6 +1099,7 @@ static int hantro_remove(struct platform_device =
*pdev)
> >>
> >>      v4l2_info(&vpu->v4l2_dev, "Removing %s\n", pdev->name);
> >>
> >> +    cancel_delayed_work(&vpu->watchdog_work);
> >
> > Use cancel_delayed_work_sync(): that ensures the code waits for a runni=
ng
> > watchdog function to finish.
> >
> > Ditto for the other patch.
>
> And also the cedrus and rkvdec patches.
>
> Regards,
>
Dear Hans,

Thanks for your review. I'll use cancel_delayed_work_sync in the next versi=
on.

Best regards,
Zheng
> >
> >>      media_device_unregister(&vpu->mdev);
> >>      hantro_remove_dec_func(vpu);
> >>      hantro_remove_enc_func(vpu);
> >
>