Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 13 Mar 2023 16:27:53 +0100
Message-Id: <CR5D0YM6E93X.S0PN49LMWT0U@vincent-arch>
Cc:     <christophe.leroy@csgroup.eu>, <song@kernel.org>
Subject: Re: [PATCH] stress-module: stress finit_module() and
 delete_module()
From:   "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To:     "Luis Chamberlain" <mcgrof@kernel.org>, <colin.i.king@gmail.com>,
        <patches@lists.linux.dev>, <linux-modules@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <pmladek@suse.com>,
        <david@redhat.com>, <petr.pavlu@suse.com>, <prarit@redhat.com>
References: <20230313103439.1235909-1-mcgrof@kernel.org>
In-Reply-To: <20230313103439.1235909-1-mcgrof@kernel.org>
Precedence: bulk

Just some comments on the code that feel a little bit odd to me,=20
while I was reading the code.

> +#if defined(HAVE_LINUX_MODULE_H)
> +#include <linux/module.h>
> +#else
> +UNEXPECTED
> +#endif
> +
> +#if defined(HAVE_LIBGEN_H)
> +#include <libgen.h>
> +#endif
> +
> +#ifndef MODULE_INIT_IGNORE_MODVERSIONS
> +# define MODULE_INIT_IGNORE_MODVERSIONS 1
> +#endif
> +
> +#ifndef MODULE_INIT_IGNORE_VERMAGIC
> +# define MODULE_INIT_IGNORE_VERMAGIC 2
> +#endif
looks like that the #define has an exstra space and this differ from the ot=
hers=20
.[c,h] files?

=E2=9E=9C  stress-ng git:(master) =E2=9C=97 git grep "#define" | wc -l
2830
=E2=9E=9C  stress-ng git:(master) =E2=9C=97 git grep "# define" | wc -l
1

Cheers!

Vincent.