Date:   Mon, 13 Mar 2023 16:51:43 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Roger Quadros <rogerq@kernel.org>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 net-next 00/13] Add tc-mqprio and tc-taprio support
 for preemptible traffic classes
Message-ID: <ZA9Gj8j1AZIGj/0R@corigine.com>
References: <20230220122343.1156614-1-vladimir.oltean@nxp.com>
 <20230311215616.jdh6qy6uuwwt5re7@skbuf>
 <ZA86mThUeARDfnN/@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZA86mThUeARDfnN/@corigine.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hEbP+LuFVWwsQlmpVdZP8ycdEETeir+UxKaZg5vQvVMrUe8v99Fm4oyi55H7?=
 =?us-ascii?Q?6lXVnaIuTVixXbLBJ0/mmnJhtJF7PADMCULfkSjF+Nfaq09DPr7O54DlpoOQ?=
 =?us-ascii?Q?qkmPNmszwvCkJw/IyPi2oppsRiRE13hVLBZhOPdAmi2Vz/68yqyxC1sFXYW8?=
 =?us-ascii?Q?OkRY8c0rwuQj9+HND/7Iq8+IeLdjVyTdkV3WR+YajZhXeqcpL/Gr8OujPSTJ?=
 =?us-ascii?Q?dSJeGghf8ihClkY3OuuR/xAjLsEckXj0cvrmg7BE5Qx7021J5T7Km3R2lbVL?=
 =?us-ascii?Q?pHCwdb05sm/lcfVxvw9du+Wd32U5S04NDPRtlOLW8m4D341sUfjnHxshxvzI?=
 =?us-ascii?Q?Rkw36Pkjk9PgmPJFvnMY4jfrdFyg+JnfRoeqNL1D4lrIbO8EbnokO/n2iVjo?=
 =?us-ascii?Q?QQ6wqtLtTHm0dNJ/6O/Ex8T2SL2CdFv9ERxGLRug3vDxxYmY4tiYqaRUmAfF?=
 =?us-ascii?Q?rPbidgd8cpt2kKFzLGt8BnEC0XwlMkeE0IHGW56TddurpXPgZVlxPhjESJxw?=
 =?us-ascii?Q?tBIRMN/mVx9aBZlYDoxZd6YomgdJoEtynKdZcY6XySS0v732iyQy5NPwEqD6?=
 =?us-ascii?Q?koclBcRPrWQz7XC+LTlhN7k3+FC/XLQPZmQifK2ATMtX5PyVxzHt9anz4k7c?=
 =?us-ascii?Q?NEyjLVXDCRd7rr9saCH9MLwpJjWi0yNqHMZIu3BMbJavn547xJ1Fx03xdANx?=
 =?us-ascii?Q?N27goAQYdhlyh9CQuVxNMK/GZ7vLMNALYbOxuOqw0ULct1CVumvf2r/vAQSw?=
 =?us-ascii?Q?b7rZaeczWsufOMC6agxHUtoBxGF5qea6ofCrj0d9HI59Qe5q4J+srg/X7DW0?=
 =?us-ascii?Q?DcPUmhM+1nuM0YTDGmO33sLK04OSwpACa8r1aAA9VDyynpBTWXTrMQjobK6l?=
 =?us-ascii?Q?hHRIkQJpQy+PvEYrffdDw1dUO3MNTPgg0T1oOYxfQRhrpH5TZQGJ3bAgAwdh?=
 =?us-ascii?Q?LLyo9ci1LQ8ssL0XPqw7bT1we3qw17oIhxOaW3azlEZwn1/zbNjkauJDsI03?=
 =?us-ascii?Q?9CXW5AjUD90fz0YasU6UPmFDDB8C847KOz94Ufb6v5s9BidxoUPITvNchXsp?=
 =?us-ascii?Q?5sdab1LQ53kXtc3t4rWdJ2mAC78JgB4TdzPYkGeFiZhKBZ0V3BXV5u5patCv?=
 =?us-ascii?Q?U4+es+6TjTZYNeasstJWzixp6kR8iAYnf5fqwVUpDewLmjHz2SU4RLoRY9PS?=
 =?us-ascii?Q?133nrZsXu82N+h5pCGH0ngf0kBU3yFpMWwqV39i+3bsldFXZSAbSiwyxwumS?=
 =?us-ascii?Q?i/m9vDpP/a0e1QwJOTgclFA3Qptzbsvt2w6kB2e4CxX4dRb87WZKugmxq06/?=
 =?us-ascii?Q?JtdqMpxMYrd9aQadUWLrB8l9QfoDkUtUXtxqKS4JK0R1BkYcaqdB+YlSxqs3?=
 =?us-ascii?Q?26/FIabE8h9qq1W8D8vcYDzwRBktqTsialqIwrx/39nz6KUHMFsO4LgxQ/4J?=
 =?us-ascii?Q?CKsTLgWZoY/8z5/p0KLfHnJMam29gtzK8Hal0V2JA+og0FDU+YSvfHtRQ7Z8?=
 =?us-ascii?Q?+vo8PoGQTfkhYSt/xmNs7Z/1Jil46IJRYXS45WOGU0A0Wb429o5ehZZwPDgd?=
 =?us-ascii?Q?t9J37N0UwAeVf6h4x57mYzMGiirlR+N6AOOzaS2HfW+ub79jH8NxNIPNcPUz?=
 =?us-ascii?Q?+XY5NtNUv3IjSKXdw/LlH5HdIadvZS8puEPgHaTzIWNFiW3yJZ+n0+DV0uV+?=
 =?us-ascii?Q?oMxcIw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bfb75bd8-a0cf-49ed-311a-08db23dadd16
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 15:51:52.4930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9acnsOr+4m6PuW88wEEyGQa6m0++/wBQ5bzl1LMWFw9f/iHHR+Muh5HOMkm2Ea492uMcZcLgYPejVaAJpz+sfZmxMAOmrlrchMW6SGiLACo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR13MB5196
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 13, 2023 at 04:00:53PM +0100, Simon Horman wrote:
> On Sat, Mar 11, 2023 at 11:56:16PM +0200, Vladimir Oltean wrote:
> > On Mon, Feb 20, 2023 at 02:23:30PM +0200, Vladimir Oltean wrote:
> > > This series proposes that we use the Qdisc layer, through separate
> > > (albeit very similar) UAPI in mqprio and taprio, and that both these
> > > Qdiscs pass the information down to the offloading device driver through
> > > the common mqprio offload structure (which taprio also passes).
> > 
> > Are there any comments before I resend this? So far I have no changes
> > planned for v4.
> 
> FWIIW, I am now reviewing v3 - I missed that only the first patch was
> was applied when the message from patch bot arrived. So far I
> am up to patch 08/13 and nothing stands out so far. And I can just as
> easily review v4.

FWIIW, I completed my review.

Reviewed-by: Simon Horman <simon.horman@corigine.com>