Date:   Mon, 13 Mar 2023 17:28:43 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Richard Cochran <richardcochran@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: ines: drop of_match_ptr for ID table
Message-ID: <ZA9PO82L1Adwtd7A@corigine.com>
References: <20230312132637.352755-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230312132637.352755-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1o4MTdnNHZzTDNUK2YzKyt4NUZSWk1xaXR1Wi9Pb1kzYTlLbDVrdEZBS2sz?=
 =?utf-8?B?cHpRaDlvamZKVDhGMnRaalN2NDg2bXRrZDhGL1d1d2p1b2p1S3NlYWFCMXNQ?=
 =?utf-8?B?T09RZzQ5TGdPbGphKzZqMnpRTUZ4ZDZOWEh5c0o3OGU0MHRhY2xDcmNhZWZr?=
 =?utf-8?B?RHcvRjJCUGFPLzVGa1ZsNVltUXl0M0o2R2I4MUZocWE5Uno1M2YrUXVRUGo2?=
 =?utf-8?B?YW5Zbm40MWxvVzVua1dINzJmaFpHSlBKbENxd0dMWTdpb1Bkb2RJNVpZdm5T?=
 =?utf-8?B?RXZCVVJOajZyTnBNVHNOZzg0YTNDSjB6RnA4NzNWeEJBQ2d4RURCbmNkZnk0?=
 =?utf-8?B?emlJbHdaUjFScndJaHVCbG0rbFoydVRzNm12QkVyMUV3ZnN0UDR5bGFLRWlF?=
 =?utf-8?B?Ykx2SkVHUWpHczlvMThGMndkbzRvMWl3K0FjWkxIc25jU1Ercy9vV3p5VFcv?=
 =?utf-8?B?K01zWWxkT3kwTWJCVWJzQUc1QU1OeHNWTUdEQisrYXpVczEwT1V3Z2xSSzdE?=
 =?utf-8?B?TkRuTVFmaUQ1ZExiVTArQnlQSFZjZ1VmTnpnSXpvY3FjdmxHTjd1blp4UWV4?=
 =?utf-8?B?NnFCd3pPeGZkVXBQV0dGdjFXbm9Ma1lRZU5ZUmNLZUlaMlkydFdQM0ptWlBJ?=
 =?utf-8?B?dmRtVFNZZk9uTTN4UVhSYkV3L1BpZks2YVkvcXplM3ZhaDdyTWZXZEFoUjA5?=
 =?utf-8?B?bzdjbTZwS3ZkMWpYNFJibzhzOXhtWmpTRXAzYnQwQ1VtSDJleHV5c0FvMjE2?=
 =?utf-8?B?OUFJZkVBcjZHUXlrV3FoZ2ZBYWx2Nkw5MGpmMnExZmN6bUJ6by9ZUG9mSlMx?=
 =?utf-8?B?UDJWQ0w0TnJXbVVjYkFQRmVjbjZ4MFgvSDlIUGhJYm1lWlZ6dDEvUFUzM09p?=
 =?utf-8?B?NHF2aU5abDRobHNqM2t4aEdoOGJlUDNrWjA4N21sQ3M4cEVRRWRaSTVxNGFJ?=
 =?utf-8?B?MFFOQm1GenFqa2tTbWJESXhvRVpTWTdpYlZia3NIWEViMjZuSzhPQmpyaFNQ?=
 =?utf-8?B?bnIyMXV4Q1JkRkdIN2w2ckNTaEloWUoyWElrYW5sWmNvZDY0Z1Z0OUVVT2JQ?=
 =?utf-8?B?NDlkTkY1cXdkRUVlNHp6VFpSaGxvMUYvbW11RDd3TlJDOW1sakRHVXpwQnJl?=
 =?utf-8?B?ZnBIYkEwcGZiYzZZZ2E0TllCc0pjYTJmMkVRYUFaSWVHTVhUY29tYkszdFJI?=
 =?utf-8?B?V0oxR0ZPR2ozRGpZczh5Sy9OQTZ2L0xyV2pESG44VGZ3K1ViNm1FZUN5TUs2?=
 =?utf-8?B?WldHck5QdWdyc2NUbW5JR3ZBQUljYzg4VlNnbW5OSzltUUU5REU4MlRyYmRn?=
 =?utf-8?B?ejV3OURNUC90cXRIOHlOZE9TQjRYcU4rSjZDMlVCbFpTVmhCNG56QUxhdUJq?=
 =?utf-8?B?NTR3SVNFUjNGeVl5THJGTzBpWE5zb3cwaVZ6MGN5ZFdLUER6R0xVaVdJekh4?=
 =?utf-8?B?WEZNQTNlL2NkelNhYVM4c21EMG9zSlh3TCs2a0RITlZXMHB3QTZGc3VQYm9I?=
 =?utf-8?B?MnBVUk9YdU94dEZxSzRHb0kwT0dxK0hFSWJOZ09PRzRzNitpSHhQNGlINkZ6?=
 =?utf-8?B?dmNMWjZlY2NBazY1VFM2WUFWdnh6NmdXMDNNUXBSNm5xOFdkQ2EwYmJVU0VI?=
 =?utf-8?B?M2c3Vm1VS0dkaHF4V1BFa1lqUzV3cDJsTURRU0V6U1lYMHcvSkVqRTBjSUpo?=
 =?utf-8?B?aFM3WFROMHJSbHlmcVV5Y2F5Q3crUWJVMEVFZFhXK2VKTmw4cmVwUXV4Ny9V?=
 =?utf-8?B?TVZWMnZ2ZkxERUJCTFFUa0pvaDNUUFZCMXF6MUdxcUYvWkpSVWUwcmR1cG5x?=
 =?utf-8?B?TFArWkdBSUVXaExEN3phNmVtWkFnaWdMRGViSDdrUlRDempNQUxHWnBkOTN0?=
 =?utf-8?B?TTFwQnZYSmRBeWlpbjFVK2dORy85b2VTYTZubzFyTi9lajR0RzNjTVJ1QUpk?=
 =?utf-8?B?NDdVekpsd1RXQzI3TkVlck5FSzBIbTR2Qi9BaTJwdHZSQ1BKcjJsUms1Y2R3?=
 =?utf-8?B?VjdKL2NXblczNlRvT1ZMbi8xUm9wR2J2M1pRR091em02Y2pGeDRxalpaMEF2?=
 =?utf-8?B?cUV6cjNiYkZXb2l5Zk8zOHRhNkZZTTNKSVlveXNubXJJa3g0VStmWjlYK3Fv?=
 =?utf-8?B?VVgySHJ6VE1kQzA5bnpWTVBEWFFwSXFMVTU1YnZ3bHR5MGhYbitKT0ZSb0J5?=
 =?utf-8?B?WUVyRFJhd2piU2wvZlJtUWhCalhxRWZWR3ZwMlF6dXA5RXlMQlJtRnFYdWkr?=
 =?utf-8?B?cXlKNExFcXVGcWFoTFJYcTFWY0JRPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38a12820-794e-4ef5-211f-08db23e006a9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 16:28:49.5856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UxfQmq+5DIKW/58u9OwhjFCQVn/JKg7jQ0HDyLRNl+WrDNrtTTSQQIMWnq8lGSk6bf+XX9FbsHhkGMBtg6OnAyZ7h04uwvXQrhKag0rdDn4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4147
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 12, 2023 at 02:26:37PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).  This
> also fixes !CONFIG_OF error:
> 
>   drivers/ptp/ptp_ines.c:783:34: error: ‘ines_ptp_ctrl_of_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>