Message-ID: <b4195142-6cfe-df3c-6edf-0c40b64ad02a@nvidia.com>
Date:   Mon, 13 Mar 2023 10:05:24 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH V3 2/6] dt-bindings: timestamp: Add Tegra234 support
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
        devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        robh+dt@kernel.org, timestamp@lists.linux.dev,
        krzysztof.kozlowski+dt@linaro.org, brgl@bgdev.pl, corbet@lwn.net,
        gregkh@linuxfoundation.org
References: <20230310190634.5053-1-dipenp@nvidia.com>
 <20230310190634.5053-3-dipenp@nvidia.com>
 <f6d9c84a-1c75-d9b4-59ed-39d6c5b310a9@linaro.org>
Content-Language: en-US
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <f6d9c84a-1c75-d9b4-59ed-39d6c5b310a9@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmFuY3dJQjBoUnB4Q0dwS0IyMnBzbHFTd0p1MTdFckxKZWxrWG1XVm9SQzRK?=
 =?utf-8?B?TWZsOVB6T0pjRXg1aS9XOWhnbWpGYjhsOUxGWG0ybXFpVmg1ZmhLTkQ4RWZQ?=
 =?utf-8?B?RHRSKzZBakdlcm9LM25WTmVkaVFxanVHWEdPeXF0ZElJRW5VV1ZUVU9nRFJs?=
 =?utf-8?B?dDdsYTNVNWdwb0M4RkJRamw4Z2ZmeG55VEFHS1hyWkdYenR2Z0cxYWhNMlV3?=
 =?utf-8?B?R09rUDNUcmJVWStDQkllbTM1R1VBNCtHL2U0cmhnbU9WblZJSHd2ZTJOR1J4?=
 =?utf-8?B?eXh1Z1NJeERubGNuWGk3N29QSG5sSWptYjkyQnJQblpRaGR4Q2QrQW9FbWw4?=
 =?utf-8?B?dVFhWVpxWStjOS9ldlZ3eE9rSlVEMityNHdCTnNDOGdJQUVwMmo0ZVYzSmhs?=
 =?utf-8?B?bjZhdFRZNGpDbWFVUDYrbzdteEFzRy91MFZEWmIzd0R0UzNTSkJ6bkkxaTlP?=
 =?utf-8?B?YkVSbTlPcGRJVEl4N04zMGVxWHNCZVlyV0RGTy9GajBGTU1UQnVOSXpzVDdn?=
 =?utf-8?B?eE1MNU90SmxoYlk3a0pidWZGN3V2WGlWMnFPN3o4R2ZwNStkTHBRY2t1b2g0?=
 =?utf-8?B?ZVVTRC9jL3lHYnBkQVQ4QnpGbjROYlA3dEFJME4xeUplK1gyUlFnZCszeVdL?=
 =?utf-8?B?cjVnbWtaYnlSZktkYWluVmpUZWx5ZDNscUFSczVQMlpwUmdVejN3a3RDWUpO?=
 =?utf-8?B?NnJYZFJEbWxCM2VrT2s2MlNWZHVwSm9pZGxFbUpvbmlsaWVHWmFrQm1idit2?=
 =?utf-8?B?UFNJQ1M4RzNaNDhUY01DaHlXSDVwWk5hTXNRWjNJemtCeWlrNTZZL1MycHlo?=
 =?utf-8?B?RFpnUTJKa2hISXlvM080bmVjVklvSDcraWtEWUdMTjVxL3dpT25neWVKQUs1?=
 =?utf-8?B?bnhhY2g3d3hMSFJyYUU1eDAwVUlLc1VMblFGODVNWlUydEdGZU5yYkN4bXhi?=
 =?utf-8?B?UThzUlpVMzgrN0N1ZHUydWJVZngzN0FvSmlkMUJpZjdUQkw4YWJPc20wczI0?=
 =?utf-8?B?dGpPS2hCSXlrWHhkSkVXU09ENjF4T0hmSHRtM0pheTRnZlo4bmg2RlBEd1JN?=
 =?utf-8?B?YlFZTi9FQmpGaGJQWDV4UmFhNjk4N1JzWVJqYlhkZHpCYnlVRUJHUkFMV2pQ?=
 =?utf-8?B?RE1yaEtyajhuck1CRDBZTjNJVlJQYnpNL0p5R05nbVFCM2tSOWhxZHVpOSsv?=
 =?utf-8?B?WW1wS3Mzb09TWDlabXZvbzRpTUthT0ZYb1BEUmtmTUk4REh1MmRFalFsQk1F?=
 =?utf-8?B?ZzEvMWtxak9oN01xOGw5NWpBUkZQSXBRZGFoeDBXejBscFZLVloxbTJWOGFk?=
 =?utf-8?B?ci8rSmRyVHFrcmFDK2ZBVnZQcjRNRUt5ZmR0OTdwQ0lwT0kyTUhXV256NjM0?=
 =?utf-8?B?bnN3Q0J5ZXZiRVZIU0xBZGNZZHp4dWlvOXFjcHRHTXhxZG4xdFkxaHFKazJ4?=
 =?utf-8?B?U2VqSVh5UDA3WXZwSC9KRCtpaENHTi8yTzJiUi9SYy9CNDQwcjB3Rk9VWWRU?=
 =?utf-8?B?OXZJSU95eGR5eGthRDVZdWxNdE1xWExYa0wvVE16K2V2dW9zTVhGTkxMTjkx?=
 =?utf-8?B?dTQ1Z1BDWkk4VWlxYW5Td1RWMGFVaUpLNXpodFE5bWhpc1YvNmpIcWoyVE9X?=
 =?utf-8?B?VjRaVElsRDNZR2NJd0NpMGtLTi9DNHR3ZU8waWFoSWcrSFNnRGtsVFhWT2Ux?=
 =?utf-8?B?QkhkQTN1anNWcE5vaEZLS0xmUGdSaTVMbmtKeWswWXRZYmlBUEhsSmh5dkJS?=
 =?utf-8?B?am9BUjN4YVRkOXlFRC9INEF1dzNpby9QMnFUY0JPYjZtMlpXWGhtcE5Wa1hP?=
 =?utf-8?B?R3ptTU9WTjdMM05EOVJldW5lYmJreHZwcitpM3Rldk5UMXBNeTdvOHk0Z2VM?=
 =?utf-8?B?TDZaaXErMFU5YXZ3TFJyZTJxbU13UjZ6aE5VZzRRRlhtMnozVGU4NEVyUnNv?=
 =?utf-8?B?Uzd3RWFDNGhKak03V2dHcUtDbGlJLy84aUhWc1ViSFVxamdRWnk3aWVackM1?=
 =?utf-8?B?ZEJLWlNEM2c4Z1FGS0pFV09kZkVwNGxKWlVnY1psOGdCZmJLR09XdHQ4em1t?=
 =?utf-8?B?N0ZiaFNoeUZIMmMrNmFSNWN1dU9ibllDRzBlKzlETTlrcW9UbWR2QnQ3U0Js?=
 =?utf-8?Q?dNGMMq2yPGewn7yJ9n7ORc0HK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9aa50d1f-c379-4f43-41ce-08db23e5252a
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 17:05:28.7940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NNrYlmEYr3HTvEJYGWZBLoppaajuGgCM8ye85ctOglPhjc2USpSqBm+iao30ZWMdWAbeI6dlgivi0TG92uaQyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5388
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/12/23 8:47 AM, Krzysztof Kozlowski wrote:
> On 10/03/2023 20:06, Dipen Patel wrote:
>> Added timestamp provider support for the Tegra234 in devicetree
>> bindings. In addition, it addresses review comments from the
>> previous review round as follows:
>> - Removes nvidia,slices property. This was not necessary as it
>> is a constant value and can be hardcoded inside the driver code.
>> - Adds nvidia,gpio-controller property. This simplifies how GTE driver
>> retrieves GPIO controller instance, see below explanation.
>>
>> Without this property code would look like:
>> if (of_device_is_compatible(dev->of_node, "nvidia,tegra194-gte-aon"))
>> 	hte_dev->c = gpiochip_find("tegra194-gpio-aon",
>> 				   tegra_get_gpiochip_from_name);
>> else if (of_device_is_compatible(dev->of_node, "nvidia,tegra234-gte-aon"))
>> 	hte_dev->c = gpiochip_find("tegra234-gpio-aon",
>> 				   tegra_get_gpiochip_from_name);
>> else
>> 	return -ENODEV;
>>
>> This means for every future addition of the compatible string, if else
>> condition statements have to be expanded.
>>
>> With the property:
>> gpio_ctrl = of_parse_phandle(dev->of_node, "nvidia,gpio-controller", 0);
>> ....
>> hte_dev->c = gpiochip_find(gpio_ctrl, tegra_get_gpiochip_from_of_node);
>>
>> We haven't technically started making use of these bindings, so
>> backwards-compatibility shouldn't be an issue yet.
> 
> Unfortunately, I don't understand this statement. The
> nvidia,tegra194-gte-aon with removed property is in a released kernel
> v6.2. What does it mean "technically"? It's a released kernel thus it is
> a released ABI.

There is no active user of that driver, so even if it breaks 6.2, it is fine
as there is no one to complain about it.

> 
> And since DTS always go to separate branch, your patch #4 breaks
> existing DTS (return -ENODEV;) - it is not bisectable.
> 
>>
>> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
>> ---
> 
> 
> Best regards,
> Krzysztof
>