Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDBFC7618B for ; Mon, 13 Mar 2023 17:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231176AbjCMRRi (ORCPT ); Mon, 13 Mar 2023 13:17:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231575AbjCMRRX (ORCPT ); Mon, 13 Mar 2023 13:17:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C56E5D44F; Mon, 13 Mar 2023 10:16:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DABE6134E; Mon, 13 Mar 2023 17:15:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7667C4339C; Mon, 13 Mar 2023 17:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678727735; bh=18h7yJ4dungwOKffwnbsdGXL7tiydULOEDbCcZ66iBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OynKBULDCoI/qcQGwd4Pr1fRMeE9xZRbwZyH/ENX9IxzsA5qb6ew9/0hl/W8SkZsa kPUXJz/V21M9lpDz9ycnnp8FdcNLsMBN1ECYYu6Ngpua00Kk5MEp8k+avfYhE3UuTj 2rtzJtf/mlB05WgEK1xQ2mZWWo0Hc2PZmvI12Zhe8qo4kiy5SW9EB897FJOZEoGVz+ xmqehOH+JGNeKNP/qys0RiJEupqI2F03msT/1a3Grl0aAFBHpTVEbjfleoZnjNrVoW zetoHu7WbstMVeEugIWb6Q77eIZFueshv1mq3AXD9T8pNmQj64tuv3mqHbDmbiixzc mAPVz3m2rcChg== From: Jisheng Zhang To: Eugeniy Paltsev , Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/11] dmaengine: dw-axi-dmac: remove unnecessary devm_free_irq() calling Date: Tue, 14 Mar 2023 01:04:41 +0800 Message-Id: <20230313170450.897-3-jszhang@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313170450.897-1-jszhang@kernel.org> References: <20230313170450.897-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In dw_remove(), We have disabled the irq from the dw-axi-dma side, so we are safe against the case "The irq is still ON when devices remove is executed and irq should be quiesced before remove is completed." Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 23a10dbdecb7..56f12dfa410d 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1542,8 +1542,6 @@ static int dw_remove(struct platform_device *pdev) pm_runtime_disable(chip->dev); axi_dma_suspend(chip); - devm_free_irq(chip->dev, chip->irq, chip); - of_dma_controller_free(chip->dev->of_node); list_for_each_entry_safe(chan, _chan, &dw->dma.channels, -- 2.39.2