Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C226C61DA4 for ; Mon, 13 Mar 2023 17:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230280AbjCMReU (ORCPT ); Mon, 13 Mar 2023 13:34:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbjCMReR (ORCPT ); Mon, 13 Mar 2023 13:34:17 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE1AD125A0 for ; Mon, 13 Mar 2023 10:34:04 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-536af432ee5so256431007b3.0 for ; Mon, 13 Mar 2023 10:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678728844; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E8OoBtnsiUhLio1XkxWQCxxFKn2qFyy0u1AAbg2mfZs=; b=QoXlhRk3GPVQklHmVFD/RvvwrG4rsWGzRLtWigCNCjQeM/YHzeXLMdctP3DzSwmLbW nKm0lsxuQb7j44cFIOPPJ2Ao+Fef3MSEw3h9PT6h9n6hOLpLq9M19QAa5Hlrs3kRvUXc Uyg60hpvOloUlp9vNs1bHEeWZX1U/vUUNW89tQMiZoly3hB2J+wJ3myg1wFat6FY3NCv 7i3yodw9Ob2wAUQBgqFKf4iXFWHRfUtOI1VWTpPcpyT70gOTZZ8FqeiAwdVlXDFYJ7kZ A5a+Bfg0VIdcDa46Y4GxoAiTPfeC8ekSDO9WSfwrmFyYoIO2+u4PTuXCf/YhZ3wwCJDD /k+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678728844; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E8OoBtnsiUhLio1XkxWQCxxFKn2qFyy0u1AAbg2mfZs=; b=IixSXKzYGo0m3CwEDGLngbUK6HTwXM5JwIny3FJ92OThgH5dk1Bc/+u4zqCgYfBDpz 1BiUSoEyQEir4IgfUKYbxOXxlAPeaQn7v+aKCuokUcH1cxZsefj2dtxANoL1dFq0M1N+ +QKSsoH++8grR3BuceMwt8A/KSsx4vrUokffwOLDWDLwnoOkw/9uEtp22SYIlAueunrt MiZzuTq4TlqRquMci3HeoABvwOUv+NcLVDPzIHwL0ZhW3vt5/qGdItvBYjY9Pd5c6+el vHNR3+j1aaPfHhpgdTR6UHaMI7SZAEx4zpeuEJZM6SrxhPWtQ2TB3GxryrhoyPySPLLx J0mA== X-Gm-Message-State: AO0yUKVI3IiboG0OISpA8X7u1jaa62JfM3sExdlMNl6+CCNC1a9T4aV7 cPeRClevgNZlKaWc2r02eFKgj8MDBIfbsBe3n1gtaA== X-Google-Smtp-Source: AK7set9x56RnCIOXJlBDAjoX6Fz8Cex6878uDmkPuKM363zKCV7DFGJhlh5PcV0Cyp6RA37TExWl2Z3CGvctByMLalk= X-Received: by 2002:a81:4520:0:b0:533:9d49:f9c9 with SMTP id s32-20020a814520000000b005339d49f9c9mr23458033ywa.0.1678728843816; Mon, 13 Mar 2023 10:34:03 -0700 (PDT) MIME-Version: 1.0 References: <20230311151756.83302-1-kerneljasonxing@gmail.com> In-Reply-To: From: Eric Dumazet Date: Mon, 13 Mar 2023 10:33:52 -0700 Message-ID: Subject: Re: [PATCH net-next] net-sysfs: display two backlog queue len separately To: Jason Xing Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Xing Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2023 at 10:16=E2=80=AFAM Jason Xing wrote: > > Thanks for the guidance. Scaling is a good way to go really. But I > just would like to separate these two kinds of limits to watch them > closely. More often we cannot decide to adjust accurately which one > should be adjusted. Time squeeze may not be clear and we cannot > randomly write a larger number into both proc files which may do harm > to some external customers unless we can show some proof to them. > > Maybe I got something wrong. If adding some tracepoints for those > limits in softnet_data is not elegant, please enlighten me :) > I dunno, but it really looks like you are re-discovering things that we dealt with about 10 years ago. I wonder why new ways of tracing stuff are needed nowadays, while ~10 years ago nothing officially put and maintained forever in the kernel was needed.