Message-ID: <5513e68a-22b8-2c91-5342-b1796741610d@metafoo.de>
Date:   Mon, 13 Mar 2023 10:36:20 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 2/5] dmaengine: axi-dmac: Don't set chancnt
Content-Language: en-US
To:     Jisheng Zhang <jszhang@kernel.org>, Vinod Koul <vkoul@kernel.org>,
        Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org
References: <20230313170250.815-1-jszhang@kernel.org>
 <20230313170250.815-3-jszhang@kernel.org>
From:   Lars-Peter Clausen <lars@metafoo.de>
In-Reply-To: <20230313170250.815-3-jszhang@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/13/23 10:02, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it
> outself is wrong.

s/outself/ourself/

Looks good otherwise, thanks.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>   drivers/dma/dma-axi-dmac.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index a812b9b00e6b..fc7cdad37161 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev)
>   	dma_dev->device_terminate_all = axi_dmac_terminate_all;
>   	dma_dev->device_synchronize = axi_dmac_synchronize;
>   	dma_dev->dev = &pdev->dev;
> -	dma_dev->chancnt = 1;
>   	dma_dev->src_addr_widths = BIT(dmac->chan.src_width);
>   	dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width);
>   	dma_dev->directions = BIT(dmac->chan.direction);