Date:   Mon, 13 Mar 2023 23:26:03 +0500
From:   Khadija Kamran <kamrankhadijadj@gmail.com>
To:     Alison Schofield <alison.schofield@intel.com>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: axis-fifo: initialize read_timeout and
 write_timeout once in probe function
Message-ID: <ZA9qu+E/gPZ68mw4@khadija-virtual-machine>
References: <ZA4M3+ZeB1Rl2fbs@khadija-virtual-machine>
 <9938109.ZD9C4EEAuf@suse>
 <ZA83yzPTq+nQF9Dd@khadija-virtual-machine>
 <ZA9ZY91K8iQtn0ev@aschofie-mobl2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZA9ZY91K8iQtn0ev@aschofie-mobl2>
Precedence: bulk

On Mon, Mar 13, 2023 at 10:12:03AM -0700, Alison Schofield wrote:
> 
> It sounds like the git commit hook for checkpatch, suggested in
> the tutorial, would have saved you here. Please look that up.
>

Hey Alison!
I had set up git post-commit hook following the tutorial. The script
showed the errors, but I ignored them before. I have submitted another
patch. I had 'trailing white spaces' errors in my code and removed them
in the new patch after consultation from 'coding-style.rst' file.

> Also see the section "Following the Driver commit style"
> And, there are sections on revising patchsets too.
> 
> Much of the info in the tutorial doesn't make sense until you
> need it. So, keep reviewing it to catch more useful info.
>

Yes!! No matter how many times I read the tutorial, I still end up
getting back to it! :)
Thank you!

Regards,
Khadija

> More on running checkpatch:
> - Add that git commmit hook.
> - The final checkpatch run can be on the formatted patches.
>   After you've done git format-patch and have a .patch file you
>   are thinking of sending, run it again. 
> 
> Something like this:
> scripts/checkpatch.pl --no-tree --strict --codespellfile=/usr/bin/codespell ~/my_patches/*.patch
> 
> > 
> > Also, I had one question. Is it okay to write a long subject as I have
> > used in this patch? 
> This is in the tutorial. section "Following the Driver commit style"
>
> > 
> > Regards,
> > Khadija
> > 
> > > >  drivers/staging/axis-fifo/axis-fifo.c | 18 ++++++++++++------
> > > >  1 file changed, 12 insertions(+), 6 deletions(-)
> > > 
> > > 
> > > 
> >