Date:   Mon, 13 Mar 2023 11:31:02 -0700
In-Reply-To: <a3e58e90a6b26019633afeef9162720ef39c5e03.camel@intel.com>
Mime-Version: 1.0
References: <20230310214232.806108-1-seanjc@google.com> <20230310214232.806108-3-seanjc@google.com>
 <a3e58e90a6b26019633afeef9162720ef39c5e03.camel@intel.com>
Message-ID: <ZA9rl1sp0l9oPoBm@google.com>
Subject: Re: [PATCH v2 02/18] x86/reboot: Expose VMCS crash hooks if and only
 if KVM_INTEL is enabled
From:   Sean Christopherson <seanjc@google.com>
To:     Kai Huang <kai.huang@intel.com>
Cc:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "x86@kernel.org" <x86@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chao Gao <chao.gao@intel.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 13, 2023, Huang, Kai wrote:
> Hi Sean,
>=20
> Thanks for copying me.
>=20
> On Fri, 2023-03-10 at 13:42 -0800, Sean Christopherson wrote:
> > Expose the crash/reboot hooks used by KVM to do VMCLEAR+VMXOFF if and
> > only if there's a potential in-tree user, KVM_INTEL.
> >=20
> > Signed-off-by: Sean Christopherson <seanjc@google.com>
> > ---

...

> > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> > index 299b970e5f82..6c0b1634b884 100644
> > --- a/arch/x86/kernel/reboot.c
> > +++ b/arch/x86/kernel/reboot.c
> > @@ -787,6 +787,7 @@ void machine_crash_shutdown(struct pt_regs *regs)
> >  }
> >  #endif
> > =20
> > +#if IS_ENABLED(CONFIG_KVM_INTEL)
> >  /*
> >   * This is used to VMCLEAR all VMCSs loaded on the
> >   * processor. And when loading kvm_intel module, the
> > @@ -807,6 +808,7 @@ static inline void cpu_crash_vmclear_loaded_vmcss(v=
oid)
> >  		do_vmclear_operation();
> >  	rcu_read_unlock();
> >  }
> > +#endif
> > =20
> >  /* This is the CPU performing the emergency shutdown work. */
> >  int crashing_cpu =3D -1;
> > @@ -818,7 +820,9 @@ int crashing_cpu =3D -1;
> >   */
> >  void cpu_emergency_disable_virtualization(void)
> >  {
> > +#if IS_ENABLED(CONFIG_KVM_INTEL)
> >  	cpu_crash_vmclear_loaded_vmcss();
> > +#endif
> > =20
> >  	cpu_emergency_vmxoff();
>=20
> In the changelog you mentioned to expose the *hooks* (plural) used to do
> "VMCLEAR+VMXOFF" only when KVM_INTEL is on, but here only "VMCLEAR" is em=
braced
> with CONFIG_KVM_INTEL.  So either the changelog needs improvement, or the=
 code
> should be adjusted?

I'll reword the changelog, "hooks" in my head was referring to the regsiter=
 and
unregister "hooks", not the callback itself.

> Personally, I think it's better to move VMXOFF part within CONFIG_KVM_INT=
EL too,
> if you want to do this.

That happens eventually in the final third of this series.

> But I am not sure whether we want to do this (having CONFIG_KVM_INTEL aro=
und the
> relevant code).  In later patches, you mentioned the case of out-of-tree
> hypervisor, for instance, below in the changelog of patch 04:
>=20
> 	There's no need to attempt VMXOFF if KVM (or some other out-of-tree=EF=
=BF=BD
> 	hypervisor) isn't loaded/active...
>=20
> This means we want to do handle VMCLEAR+VMXOFF in case of out-of-tree hyp=
ervisor
> too.  So, shouldn't the hooks always exist but not only available when KV=
M_INTEL
> or KVM_AMD is on, so the out-of-tree hypervisor can register their callba=
cks?

Ah, I see how I confused things with that statement.  My intent was only to=
 call
out that, technically, a non-NULL callback doesn't mean KVM is loaded.  I d=
idn't
intend to sign the kernel up for going out of its way to support out-of-tre=
e hypervisors.

Does it read better if I add a "that piggybacked the callback" qualifier?

  There's no need to attempt VMXOFF if KVM (or some other out-of-tree hyper=
visor
  that piggybacked the callback) isn't loaded/active, i.e. if the CPU can't
  possibly be post-VMXON.=20