Date:   Mon, 13 Mar 2023 19:42:48 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Josef Miegl <josef@miegl.cz>
Cc:     Eyal Birger <eyal.birger@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: geneve: set IFF_POINTOPOINT with
 IFLA_GENEVE_INNER_PROTO_INHERIT
Message-ID: <ZA9uqAPhmUyYPcdo@corigine.com>
References: <20230312164557.55354-1-josef@miegl.cz>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230312164557.55354-1-josef@miegl.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cLZSiKG4UwQBD81c+k32/QIbVjapwsUORxra33oAzhwzqOomoVhi8l0CLgV1?=
 =?us-ascii?Q?x4R8TV5ovxcuBdvBlPw+rx/EAl8W0vKvrxuieuA2+WFpCeTIoYKSmwwwlgyr?=
 =?us-ascii?Q?EUBrIQNGqvDMAyb0CLBXsab/IOrK9fMyMKUO2Ix+NFtdbgb+D+0OIO8wchpR?=
 =?us-ascii?Q?qAqX6E3YVb+ZdKZNmhn27EkG3Q9e2v/W7SJMx0xVNDDnR1mDw0mqfQRD0X25?=
 =?us-ascii?Q?ltR8jfN6vqOt8FeeqeETr04e6bf/4Z2q8puCZcMqzNPsGZhWQq/n7UokEvr/?=
 =?us-ascii?Q?Gbigzh2ZEk1lLF7CzF1z3JGrDURytHsQAmjRLu1loQuwwnKgIeec2r6ap4N0?=
 =?us-ascii?Q?/yT+TZcCHMpUlz/yZdVu/B709ljC9h2flNdbkKmobVYYyP+b7B/DnPepKeJH?=
 =?us-ascii?Q?yeCzOypGQY0+DSzno39KBzkoaFnI+zFJh2lbhXbPg+RJmE2Y3srbjgXtgewQ?=
 =?us-ascii?Q?CE4y3VjrMWmYaJ72R1n9TgqAR9DsvDqvTCKqDUydBH+Dtev1mzv3KtmbEN+K?=
 =?us-ascii?Q?6696CosG64uapFPQZhiLhilUr1NiJzZVWsx+82TM5ena+WDYz5HA+LcOT+IW?=
 =?us-ascii?Q?QMPE2DU2sAo+70ysIMbBD3t9Z7+fmiYhFY8i2vcxnEG/wR1ny52IjptErYIo?=
 =?us-ascii?Q?xAGsS4x6maJafIdCLhv+h8xVygyf+swI30jwJ1G4JAXQAVrNZhXoDvzCBu2u?=
 =?us-ascii?Q?GjXy9uK9dXTdBiYVIJ+JWc3bjCymVh9j7VQFQYqTZH+Xa3vwpIAs6lGxSVbc?=
 =?us-ascii?Q?sO7n94jWQHXAr9G5GcAQHnc9mV6jqag7cLVGUn2X3johpnw7tc9WuPMT4O8E?=
 =?us-ascii?Q?wRQsv4T8KjRzaxrewWm+zXY69v/qeX7NpuKX60IGUzpStJu7rxgLux5DbCiv?=
 =?us-ascii?Q?+8KtQ6fjRkdql7uJD/YinQJeMLNgDymCdTJB0rjKv3Gd0N15S4EYM4PqJdfh?=
 =?us-ascii?Q?tR9hBvuGAxoyail22dFl4ZRnfZVErxkzforW54/BH4Cdu3cFvPq1Nt1ot8jH?=
 =?us-ascii?Q?8u4q3Z8fqsJWrt99riWvKbm1FxJAxerP7D1IG5haSiBvmGMiqAQom3O0eNwR?=
 =?us-ascii?Q?R9feoWkf2+YgtqOIhJM8FJSK9k1Qn0khDJvEbR2ztCUGi7nejChiMc83PI9w?=
 =?us-ascii?Q?StoqlRxUw5Tl+EtZO8/thB+21ukNlrOHls+8MHmnaOd1Yf+8n6jEz5me8P53?=
 =?us-ascii?Q?z3X52HmiXFiDnCQYQbJEMJPV+vpJNeMEGYkDTPOwJQ8NVgk+8KhucexwKSw4?=
 =?us-ascii?Q?06R+F+jX3bEUSwhgwVt9iw/Qbk9KqOASWQzmpwFN1nt7yUfNbKTWNuuOfL3K?=
 =?us-ascii?Q?WKpnf8tjrpyzkIe69FSpWJjZWMqZeNJaDuW9/EXLSn7sK7IG9uYHIr2Gbw4O?=
 =?us-ascii?Q?r8CXhBANSpsltud1IGva8oKYmjvW5wJm9YcjhuOtNs30W9WxNXuUcYU+NJ/w?=
 =?us-ascii?Q?mvEeEpMGLIgW74p0/ShbasF0SYMqK/nvv+G/o/9ODPArpm4f0/4eXzLFvQjW?=
 =?us-ascii?Q?yBf6sBmNATKy4DKYTU0BG4fh64BeofyilHfnAIMElm1gLOiuCmnk85fRESD0?=
 =?us-ascii?Q?uuSilrnKaFtjBMcegH+u1XG7ykX9WypuT86v8Ij3UCp1a6PCkVNWsMNW9APG?=
 =?us-ascii?Q?cH1KVEKHWvFjfX6hjN9SPzl/bHb3oXI31MHMgKz5FTurP+GycjFJ8gsmc+yf?=
 =?us-ascii?Q?hraTPQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b17e30b9-4c0f-4c9a-6901-08db23f2c186
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 18:42:54.1269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aTi+IWQXml8mz+vBoXqczoK1NRDNfOAI59k5n4ag/1wS4KObbkHoK0F9Aa6Pf2EfuKZ0PpxzZwntVPrDe03Xtu/mQi74bw1zUz2T9Qf5vaM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4999
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 12, 2023 at 05:45:57PM +0100, Josef Miegl wrote:
> The GENEVE tunnel used with IFLA_GENEVE_INNER_PROTO_INHERIT is
> point-to-point, so set IFF_POINTOPOINT to reflect that.
> 
> Signed-off-by: Josef Miegl <josef@miegl.cz>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> ---
>  drivers/net/geneve.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index 32684e94eb4f..78f9d588f712 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -1421,7 +1421,7 @@ static int geneve_configure(struct net *net, struct net_device *dev,
>  		dev->type = ARPHRD_NONE;
>  		dev->hard_header_len = 0;
>  		dev->addr_len = 0;
> -		dev->flags = IFF_NOARP;
> +		dev->flags = IFF_POINTOPOINT | IFF_NOARP;
>  	}
>  
>  	err = register_netdevice(dev);
> -- 
> 2.37.1
>