Date:   Mon, 13 Mar 2023 11:48:58 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     "Jonas Suhr Christensen" <jsc@umbraculum.org>,
        "Harini Katakam" <harini.katakam@amd.com>
Cc:     "Paolo Abeni" <pabeni@redhat.com>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Michal Simek" <michal.simek@xilinx.com>,
        "Haoyue Xu" <xuhaoyue1@hisilicon.com>,
        huangjunxian <huangjunxian6@hisilicon.com>,
        "Wang Qing" <wangqing@vivo.com>,
        "Yang Yingliang" <yangyingliang@huawei.com>,
        "Esben Haabendal" <esben@geanix.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak
Message-ID: <20230313114858.54828dda@kernel.org>
In-Reply-To: <bd639016-8a9c-4479-83b4-32306ad734ac@app.fastmail.com>
References: <20230205201130.11303-1-jsc@umbraculum.org>
        <20230205201130.11303-2-jsc@umbraculum.org>
        <5314e0ba3a728787299ca46a60b0a2da5e8ab23a.camel@redhat.com>
        <135b671b1b76978fb147d5fee1e1b922e2c61f26.camel@redhat.com>
        <20230207104204.200da48a@kernel.org>
        <bd639016-8a9c-4479-83b4-32306ad734ac@app.fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 13 Mar 2023 19:37:00 +0100 Jonas Suhr Christensen wrote:
> On Tue, Feb 7, 2023, at 19:42, Jakub Kicinski wrote:
> > On Tue, 07 Feb 2023 12:36:11 +0100 Paolo Abeni wrote:  
> >> You can either try change to phys type to __be32 (likely not suitable
> >> for -net and possibly can introduce even more warnings elsewhere)  
> >
> > FWIW that seems like the best option to me as well. Let's ignore the
> > sparse warning for v3 and try to switch phys to __be32 in a separate
> > patch for net-next. No point adding force casts just to have to remove
> > them a week later, given how prevalent the problem is.
> >  
> >> or explicitly cast the argument.  
> 
> I no longer have access to the hardware, so I'm not rewriting the
> batch. Feel free to take ownership of it and fix what's needed.

Ack.

Harini, are you the designated maintainer for this driver? Could you
add a MAINTAINERS entry for it? I don't see one right now.
And possibly pick up these patches / fix the problem, if you have 
the cycles?