Date:   Mon, 13 Mar 2023 11:52:09 -0700
From:   Richard Cochran <richardcochran@gmail.com>
To:     Simon Horman <simon.horman@corigine.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: ines: drop of_match_ptr for ID table
Message-ID: <ZA9w2T78IqLWk7ja@hoboy.vegasvil.org>
References: <20230312132637.352755-1-krzysztof.kozlowski@linaro.org>
 <ZA9PO82L1Adwtd7A@corigine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZA9PO82L1Adwtd7A@corigine.com>
Precedence: bulk

On Mon, Mar 13, 2023 at 05:28:43PM +0100, Simon Horman wrote:
> On Sun, Mar 12, 2023 at 02:26:37PM +0100, Krzysztof Kozlowski wrote:
> > The driver can match only via the DT table so the table should be always
> > used and the of_match_ptr does not have any sense (this also allows ACPI
> > matching via PRP0001, even though it might not be relevant here).  This
> > also fixes !CONFIG_OF error:
> > 
> >   drivers/ptp/ptp_ines.c:783:34: error: ‘ines_ptp_ctrl_of_match’ defined but not used [-Werror=unused-const-variable=]
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Acked-by: Richard Cochran <richardcochran@gmail.com>