Message-ID: <76db3d98-2d09-54de-ab46-0ec9d743e05d@intel.com>
Date:   Mon, 13 Mar 2023 12:07:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH 32/36] dmaengine: idxd: use const struct bus_type *
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
CC:     <rafael@kernel.org>, Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>, <dmaengine@vger.kernel.org>
References: <20230313182918.1312597-1-gregkh@linuxfoundation.org>
 <20230313182918.1312597-32-gregkh@linuxfoundation.org>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230313182918.1312597-32-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmRIbGk1U2o3aXQrL010c3JaT2ZDcVg5VmRvaWN5b3hOblR3NjlQaENJSlR0?=
 =?utf-8?B?bFIwQkhaVXk5SEFWT0p5Q2lwNVdGWnhEc242T1NDQVJuMFdlS21oZTVjVzIz?=
 =?utf-8?B?OU5QajJRVkhKU3pMWEYwVkFFemg2dEJFV041RnF4bjhwTWVwbDRIMXVCajl4?=
 =?utf-8?B?UWtTWUZmU2NuSHcySHY4Q2N0RUpHeGExL1NuQllVdkVSbElibHRURENNNjA5?=
 =?utf-8?B?Y2RXck0xdnJUSFliY1lQQVBKbnVqNDBPMzQ5ZWxhNTkwRUtTS1ZiQkZoK2Zx?=
 =?utf-8?B?YjNnN1kyVk1zZmR5SlhTSS9CZnJRZWNNcmZydkNjQU5WVkc3TG1SRFh1bktw?=
 =?utf-8?B?K2lMd2p2RVIvVnlLZzMzbWlleG1NYnFvdVZPUm9NYVVMWXFYWE9GV1BCQitV?=
 =?utf-8?B?NlNzbStFRGErZEFaRmhjSHpDYm5ZK0NSdjNxZVVVcmIwanEyMjNJTWNWK1BP?=
 =?utf-8?B?bjl1Si9IMXdKb0ZJbXhyTnJOeGFRTEVENTdjMmV3WkJkbmtENUpwR2t2NzR6?=
 =?utf-8?B?Y1dVRWhEMXlmZ0EyYmc4eklwU0pkcHlhQ1ZPV29XaVlzYVhmc1RJTVc4NWtX?=
 =?utf-8?B?RGZVVDhONXlaanBsdFlMQ2tlbzBPanVRenA3aDBpYlByQ1dkcG1QSDZQUXNx?=
 =?utf-8?B?aTlXeWJOOFlYYWZuUHBBT2pRTG8rQUdvTlF2OTUyTWQrelpyRGZEcmZBQmlr?=
 =?utf-8?B?blhQcytwOHlOcmJHeXBDaE5Rd2tCTHBHQ056ZGtkWkhyK092YVRJNzJTdEZF?=
 =?utf-8?B?SERNSCs2Yk5Vd1hLdUQ5NUMyYzQ0b1VPRzRSWnhSc004M2Fka25pNG10N0Nk?=
 =?utf-8?B?TGxnWFdpTXFPZk9LUUovcmYwN2lvc3VkbXQ3NU9yZzZSb29VQXNYSEs3S0E5?=
 =?utf-8?B?b2JRM2xrQTA0UUowVWIzMmRXYjc1R0FiYzRla0Jtak5WRXJUL3A5aHF2SmFv?=
 =?utf-8?B?aVAybzBVM3Jrb1FEa0tUcHJYc2tTZzZkd3JqL3FHY3o5dmlwekhDS1pNODhS?=
 =?utf-8?B?OHBpS1JSRnpxYlN2d0s0UWZNaVozSEFQT0QydmZHR2NQM3pRZ1VqYUlHTjVp?=
 =?utf-8?B?M3VXZnhkdjdsT3IraVNTYnRqUXdqUGFaVDFkMHFQaFdyZGlMZENWbkN2OVdV?=
 =?utf-8?B?ZUE0UEVwNi96SFYwdjNic3dlVHNhRWEwVnVXVzVwMWo5SDdQbytOeDB4OUlT?=
 =?utf-8?B?QzM1MXV1Z3FKRlZHSEtrRi9hUkxtM1JBbWNoL28wd3EyajNSWWhJSngwWHlO?=
 =?utf-8?B?QXhSS3loN3NLZnozUjVkeEJDNmVxV3dTb1NCZFFQcnlTUjBpVVh3YkVkQkpn?=
 =?utf-8?B?Mlc0YlBBSnBMS1pGUWd1MnBBMnpqbm9qS2tQRDFJcXhLZ3dxVml0S1V0OFJM?=
 =?utf-8?B?K0pZS21HQkxzWUd1TTZzUk5UdUw1a1l4K2x6N0JNUVA3NnRoQjFTVHc4Znds?=
 =?utf-8?B?aEIzY3ZNbXh0b2xwbXpwTFFiMElxdEhWQnBDTXZEUlVmak1JR05SVFJrNGVC?=
 =?utf-8?B?Rk5vcStQczZPYndVNXA4cFE3SnpZa3J1UVVMVmc1MGt6ZStLT3hHTU1ZdnlF?=
 =?utf-8?B?SGRGM3FwZXNEdTM2KzVUemJBM09wakJzdXpZdm5URTIxck80WWE1OGt4cHNl?=
 =?utf-8?B?N29nZUtnSEgyMElpdEpDcnV5d056Y25xYTNrZDJhbW9mT09jK3RwYTNQb2cv?=
 =?utf-8?B?QlYzZ2hCT01LUFUxaW9DMExEazNjbTdkQ0J4V09oaTZWSE93SFltTU9VcWhE?=
 =?utf-8?B?Zi82ZGNqWUF4S1lpVmFQTzJ4UWNmY0tXSGp2RDNOdzlLY3dneUxORkJTNldr?=
 =?utf-8?B?R3ZmcWErZ2VIZXRMVlpncFVCd3NTa2ZDR0VSZ0pCdWlMSEd2OGc0V3VYZjM5?=
 =?utf-8?B?TTB2MjFxN1NwTUdxZ3Q3SHdVVmg1VmtQWUdGb1AwU1FGWGNSeFRoRGNJVlMw?=
 =?utf-8?B?V2tlRFI3bFFOQzdoc2dVWTltSVgwQTlKMEJTS05zZTVtUEI0M2ZIUlBNWG1R?=
 =?utf-8?B?V242eWRvOVg4Rmw1UjZITDEyTUdUNWhyQ3RXdXhBd0t6MEticGhRZkNXNDVq?=
 =?utf-8?B?RmxjT2ZmbEtzVEZUYWhSelhRZEllbjRGZ3hYOVkyNS91dUQ3NFBNcWk2MXZp?=
 =?utf-8?Q?GXLBrZwGqLdVF2yqpX8102il1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 267fec8d-ecc1-48f6-e28f-08db23f623c4
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 19:07:07.4433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BOzT+uLlaGiVG39YueDwQcHxchzvQgsKevFpCk33lnf0wzpqmgrPIr7EhBh68iAspPqaKnvguaaIArrlS7B2pA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4549
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Greg,

On 3/13/23 11:29, Greg Kroah-Hartman wrote:
> In the functions unbind_store() and bind_store(), a struct bus_type *
> should be a const one, as the driver core bus functions used by this
> variable are expecting the pointer to be constant, and these functions
> do not modify the pointer at all.
> 
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Note, this is a patch that is a prepatory cleanup as part of a larger
> series of patches that is working on resolving some old driver core
> design mistakes.  It will build and apply cleanly on top of 6.3-rc2 on
> its own, but I'd prefer if I could take it through my driver-core tree
> so that the driver core changes can be taken through there for 6.4-rc1.
> 
>   drivers/dma/idxd/compat.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/compat.c b/drivers/dma/idxd/compat.c
> index 3df21615f888..5fd38d1b9d28 100644
> --- a/drivers/dma/idxd/compat.c
> +++ b/drivers/dma/idxd/compat.c
> @@ -16,7 +16,7 @@ extern void device_driver_detach(struct device *dev);
>   
>   static ssize_t unbind_store(struct device_driver *drv, const char *buf, size_t count)
>   {
> -	struct bus_type *bus = drv->bus;
> +	const struct bus_type *bus = drv->bus;
>   	struct device *dev;
>   	int rc = -ENODEV;
>   
> @@ -32,7 +32,7 @@ static DRIVER_ATTR_IGNORE_LOCKDEP(unbind, 0200, NULL, unbind_store);
>   
>   static ssize_t bind_store(struct device_driver *drv, const char *buf, size_t count)
>   {
> -	struct bus_type *bus = drv->bus;
> +	const struct bus_type *bus = drv->bus;
>   	struct device *dev;
>   	struct device_driver *alt_drv = NULL;
>   	int rc = -ENODEV;

After applying this patch, warning is reported:

drivers/dma/idxd/compat.c: In function ‘bind_store’:
drivers/dma/idxd/compat.c:47:47: warning: passing argument 2 of 
‘driver_find’ discards ‘const’ qualifier from pointer target type 
[-Wdiscarded-qualifiers]
    47 |                 alt_drv = driver_find("idxd", bus);
       |                                               ^~~
In file included from ./include/linux/device.h:32,
                  from drivers/dma/idxd/compat.c:6:
./include/linux/device/driver.h:129:59: note: expected ‘struct bus_type 
*’ but argument is of type ‘const struct bus_type *’
   129 |                                          struct bus_type *bus);
       |                                          ~~~~~~~~~~~~~~~~~^~~

Should the "bus" parameter in driver_find() definition be changed to 
const as well to avoid the warning?

Thanks.

-Fenghua