Date:   Mon, 13 Mar 2023 12:16:58 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Xiaoyao Li <xiaoyao.li@intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
        Sean Christopherson <seanjc@google.com>,
        Sagi Shahar <sagis@google.com>,
        David Matlack <dmatlack@google.com>,
        Kai Huang <kai.huang@intel.com>,
        Zhi Wang <zhi.wang.linux@gmail.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH v13 009/113] KVM: TDX: Define TDX architectural
 definitions
Message-ID: <20230313191658.GB3922605@ls.amr.corp.intel.com>
References: <cover.1678643051.git.isaku.yamahata@intel.com>
 <1e73822eacaa512aeb559a3f3b71ae4963bf9fdd.1678643052.git.isaku.yamahata@intel.com>
 <b0c8af03-882c-e675-8397-5b6f843fa4df@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b0c8af03-882c-e675-8397-5b6f843fa4df@intel.com>
Precedence: bulk

On Mon, Mar 13, 2023 at 07:37:43PM +0800,
Xiaoyao Li <xiaoyao.li@intel.com> wrote:

> On 3/13/2023 1:55 AM, isaku.yamahata@intel.com wrote:
> > diff --git a/arch/x86/kvm/vmx/tdx_arch.h b/arch/x86/kvm/vmx/tdx_arch.h
> > new file mode 100644
> > index 000000000000..942a0e561a7b
> > --- /dev/null
> > +++ b/arch/x86/kvm/vmx/tdx_arch.h
> ...
> > +
> > +#define TDG_VP_VMCALL_GET_TD_VM_CALL_INFO		0x10000
> > +#define TDG_VP_VMCALL_MAP_GPA				0x10001
> > +#define TDG_VP_VMCALL_GET_QUOTE				0x10002
> > +#define TDG_VP_VMCALL_REPORT_FATAL_ERROR		0x10003
> > +#define TDG_VP_VMCALL_SETUP_EVENT_NOTIFY_INTERRUPT	0x10004
> 
> TDX guest side implementation defines
> 
>     /* TDX hypercall Leaf IDs */
>     #define TDVMCALL_MAP_GPA			0x10001
>     #define TDVMCALL_REPORT_FATAL_ERROR		0x10003
> 
> We need put these shared definitions between host and guest into some shared
> header file.

Good suggestion. Let me fix it.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>