Message-ID: <b2473ea8-c0cb-42c9-6350-dafd737d94e8@opensource.cirrus.com>
Date:   Mon, 13 Mar 2023 14:18:38 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 4/5] ASoC: cs35l45: DSP Support
Content-Language: en-US
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
CC:     James Schulman <james.schulman@cirrus.com>,
        David Rhodes <david.rhodes@cirrus.com>,
        Richard Fitzgerald <rf@opensource.cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
        <patches@opensource.cirrus.com>, <linux-kernel@vger.kernel.org>,
        Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
References: <20230303192151.2437221-1-vkarpovi@opensource.cirrus.com>
 <20230303192151.2437221-4-vkarpovi@opensource.cirrus.com>
 <20230306092652.GP68926@ediswmail.ad.cirrus.com>
From:   Vlad Karpovich <vkarpovi@opensource.cirrus.com>
In-Reply-To: <20230306092652.GP68926@ediswmail.ad.cirrus.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/6/23 03:26, Charles Keepax wrote:
> On Fri, Mar 03, 2023 at 01:21:50PM -0600, Vlad Karpovich wrote:
>> From: "Vlad.Karpovich" <vkarpovi@opensource.cirrus.com>
>>
>> The CS35L45 digital core incorporates one programmable DSP block,
>> capable of running a wide range of audio enhancement and speaker
>> and battery protection functions.
>>
>> Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
>> ---
>> +#define CS35L45_DAC_MUX_ROUTE(name) \
>> +	{ name" Source", "ASP_RX1",	"ASP_RX1" }, \
>> +	{ name" Source", "ASP_RX2",	"ASP_RX2" }, \
>> +	{ name" Source", "DSP_TX1",	"DSP1" }, \
>> +	{ name" Source", "DSP_TX2",	"DSP1" }
>> +
>> +
> Minor nit, double blank line here.
Thanks. I will fix it
> But otherwise looks pretty good to me:
>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> Thanks,
> Charles