Date:   Mon, 13 Mar 2023 19:38:58 +0000
From:   Lorenzo Stoakes <lstoakes@gmail.com>
To:     Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Hellstrom <thomas.hellstrom@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@suse.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH 3/3] drm/ttm: Remove comment referencing now-removed
 vmf_insert_mixed_prot()
Message-ID: <f7c5bd29-18e5-4eed-8a13-c84d4b9c4874@lucifer.local>
References: <cover.1678661628.git.lstoakes@gmail.com>
 <db403b3622b94a87bd93528cc1d6b44ae88adcdd.1678661628.git.lstoakes@gmail.com>
 <58224a49-654f-0026-4286-c6103d2057dc@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <58224a49-654f-0026-4286-c6103d2057dc@amd.com>
Precedence: bulk

On Mon, Mar 13, 2023 at 08:47:21AM +0100, Christian K?nig wrote:
> Am 13.03.23 um 00:40 schrieb Lorenzo Stoakes:
> > This function no longer exists, however the prot != vma->vm_page_prot case
> > discussion has been retained and moved to vmf_insert_pfn_prot() so refer to
> > this instead.
> >
> > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
>
> Reviewed-by: Christian K?nig <christian.koenig@amd.com>
>
> Feel free to add my acked-by to the other two patches in the series and
> upstream through any branch you like.
>
> Alternatively ping me when you get rbs for the first two patches from the MM
> people and I can push this upstream through drm-misc.
>
> Thanks,
> Christian.

Thanks, much appreciated! I'd rather go through mm if possible as Andrew has
already taken for mm-unstable pending further review + that's easiest for
dealing with any mm feedback.

P.S. apologies for dropping the umlaut on your name in initial patch, I really
need to sort out my terminal which got horribly confused by non-ANSI characters :)

>
> > ---
> >   drivers/gpu/drm/ttm/ttm_bo_vm.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
> > index ca7744b852f5..5df3edadb808 100644
> > --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
> > +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
> > @@ -254,7 +254,7 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf,
> >   		 * encryption bits. This is because the exact location of the
> >   		 * data may not be known at mmap() time and may also change
> >   		 * at arbitrary times while the data is mmap'ed.
> > -		 * See vmf_insert_mixed_prot() for a discussion.
> > +		 * See vmf_insert_pfn_prot() for a discussion.
> >   		 */
> >   		ret = vmf_insert_pfn_prot(vma, address, pfn, prot);
>