MIME-Version: 1.0
References: <20230310202922.2459680-1-martin.blumenstingl@googlemail.com>
 <20230310202922.2459680-4-martin.blumenstingl@googlemail.com> <7330960d32664bf0bce8446aa93d10c8@realtek.com>
In-Reply-To: <7330960d32664bf0bce8446aa93d10c8@realtek.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Mon, 13 Mar 2023 21:11:43 +0100
Message-ID: <CAFBinCA-OHPbwdxdDe50og787LMSnbPhYbsRL6UzQUhxWgxWbQ@mail.gmail.com>
Subject: Re: [PATCH v2 RFC 3/9] wifi: rtw88: mac: Support SDIO specific bits
 in the power on sequence
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Yan-Hsuan Chuang <tony0620emma@gmail.com>,
        Kalle Valo <kvalo@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Chris Morgan <macroalpha82@gmail.com>,
        Nitin Gupta <nitin.gupta981@gmail.com>,
        Neo Jou <neojou@gmail.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Ping-Ke,

On Mon, Mar 13, 2023 at 10:05=E2=80=AFAM Ping-Ke Shih <pkshih@realtek.com> =
wrote:
[...]
> >         pwr_seq =3D pwr_on ? chip->pwr_on_seq : chip->pwr_off_seq;
> >         ret =3D rtw_pwr_seq_parser(rtwdev, pwr_seq);
> > -       if (ret)
> > -               return ret;
> > +
> > +       if (rtw_hci_type(rtwdev) =3D=3D RTW_HCI_TYPE_SDIO)
> > +               rtw_write32(rtwdev, REG_SDIO_HIMR, imr);
> >
> >         if (pwr_on)
> >                 set_bit(RTW_FLAG_POWERON, rtwdev->flags);
>
> If failed to power on, it still set RTW_FLAG_POWERON. Is it reasonable?
That sounds very reasonable to me!

> Did you meet real problem here?
>
> Maybe, here can be
>
>          if (pwr_on && !ret)
>                  set_bit(RTW_FLAG_POWERON, rtwdev->flags);
I can't remember any issue that I've seen. I'll verify this at the end
of the week (until then I am pretty busy with my daytime job) and then
go with your suggestion.
Thanks again as always - your feedback is really appreciated!

Also thank you for commenting on the other patches. I'll take a closer
look at your feedback at the end of the week and send another version
of this series.


Best regards,
Martin