Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 753A8C61DA4 for ; Mon, 13 Mar 2023 21:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbjCMVDD (ORCPT ); Mon, 13 Mar 2023 17:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbjCMVCi (ORCPT ); Mon, 13 Mar 2023 17:02:38 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C431F8DCFA; Mon, 13 Mar 2023 14:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1pIf+VierdJpmiI9zH5ye8/eQXEQAS3qYu1Hwf19Ncw=; b=R7d6Us7vCuOJReyceWdv+LWtTC 5i5hHWzz00qZTY6FXaLcQvLmThPfgsZFYH8ZHjDYsJfo9Irpn6ZfsFegJq26hvKThLu4ldNwqWV2x kXkPgfw8xMXtp8RhxxIeSyFfwYYm3L3/OWn23Epm/H9l+tf+hh4OAMZ0Oa55d1CkdaIwcB8UZwAF9 E2FIDJIqeoad+oXMaEmGmOP1JOXwbraz02PFER6uHfn8Wl8AijMeZi1X2OfcqS6uH5WzFMXcLUn5m c02De4I+TQkJQ8RROcqVoNvaXRHTVel+UYgbD1vI9b9oyumeuDwqyRXhQlJxXkhw7v92TgShtcZQ1 yY7cxcAw==; Received: from [152.254.169.34] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1pbodB-008NsZ-6k; Mon, 13 Mar 2023 21:18:53 +0100 Message-ID: Date: Mon, 13 Mar 2023 17:18:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4] alpha: Clean-up the panic notifier code Content-Language: en-US To: linux-alpha@vger.kernel.org, Matt Turner , Richard Henderson , Ivan Kokshaysky Cc: linux-kernel@vger.kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, Petr Mladek References: <20230220212245.153554-1-gpiccoli@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: <20230220212245.153554-1-gpiccoli@igalia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/02/2023 18:22, Guilherme G. Piccoli wrote: > The alpha panic notifier has some code issues, not following > the conventions of other notifiers. Also, it might halt the > machine but still it is set to run as early as possible, which > doesn't seem to be a good idea. > > So, let's clean the code and set the notifier to run as the > latest, following the same approach other architectures are > doing - also, remove the unnecessary include of a header already > included indirectly. > > Cc: Ivan Kokshaysky > Cc: Matt Turner > Cc: Richard Henderson > Reviewed-by: Petr Mladek > Signed-off-by: Guilherme G. Piccoli > > --- > > > V4: > - Rebased (and build-tested) against v6.2. > > V3: > - No changes. > > V2: > - Fixed rth email address; > - Added Petr's review tag - thanks! > Hi folks, just a gentle ping. Lemme know if there's anything I could do in order to get this move forward. Thanks in advance, Guilherme