MIME-Version: 1.0
References: <20230214-kobj_type-md-v1-1-d6853f707f11@weissschuh.net>
In-Reply-To: <20230214-kobj_type-md-v1-1-d6853f707f11@weissschuh.net>
From:   Song Liu <song@kernel.org>
Date:   Mon, 13 Mar 2023 14:12:01 -0700
Message-ID: <CAPhsuW5atxr8iFS-=scHjhXo19We4Rnms+XU80c9aKANQL1k1g@mail.gmail.com>
Subject: Re: [PATCH] md: make kobj_type structures constant
To:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc:     linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Feb 13, 2023 at 7:19=E2=80=AFPM Thomas Wei=C3=9Fschuh <linux@weisss=
chuh.net> wrote:
>
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>

Applied to md-next. Thanks!

Song

> ---
>  drivers/md/md.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 02b0240e7c71..091c1d6f0b87 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -78,7 +78,7 @@
>  static LIST_HEAD(pers_list);
>  static DEFINE_SPINLOCK(pers_lock);
>
> -static struct kobj_type md_ktype;
> +static const struct kobj_type md_ktype;
>
>  struct md_cluster_operations *md_cluster_ops;
>  EXPORT_SYMBOL(md_cluster_ops);
> @@ -3600,7 +3600,7 @@ static const struct sysfs_ops rdev_sysfs_ops =3D {
>         .show           =3D rdev_attr_show,
>         .store          =3D rdev_attr_store,
>  };
> -static struct kobj_type rdev_ktype =3D {
> +static const struct kobj_type rdev_ktype =3D {
>         .release        =3D rdev_free,
>         .sysfs_ops      =3D &rdev_sysfs_ops,
>         .default_groups =3D rdev_default_groups,
> @@ -5558,7 +5558,7 @@ static const struct sysfs_ops md_sysfs_ops =3D {
>         .show   =3D md_attr_show,
>         .store  =3D md_attr_store,
>  };
> -static struct kobj_type md_ktype =3D {
> +static const struct kobj_type md_ktype =3D {
>         .release        =3D md_kobj_release,
>         .sysfs_ops      =3D &md_sysfs_ops,
>         .default_groups =3D md_attr_groups,
>
> ---
> base-commit: f6feea56f66d34259c4222fa02e8171c4f2673d1
> change-id: 20230214-kobj_type-md-a3c7773574cf
>
> Best regards,
> --
> Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
>