Message-ID: <04cc510b-6d66-99b5-4fe8-f51729299574@linux.alibaba.com>
Date:   Tue, 14 Mar 2023 11:51:25 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 5/5] dmaengine: sprd: Don't set chancnt
To:     Jisheng Zhang <jszhang@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Vinod Koul <vkoul@kernel.org>,
        Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org
References: <20230313170250.815-1-jszhang@kernel.org>
 <20230313170250.815-6-jszhang@kernel.org>
From:   Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <20230313170250.815-6-jszhang@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/14/2023 1:02 AM, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it
> outself is wrong.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   drivers/dma/sprd-dma.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index 474d3ba8ec9f..2b639adb48ba 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev)
>   
>   	dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask);
>   	sdev->total_chns = chn_count;
> -	sdev->dma_dev.chancnt = chn_count;
>   	INIT_LIST_HEAD(&sdev->dma_dev.channels);
>   	INIT_LIST_HEAD(&sdev->dma_dev.global_node);
>   	sdev->dma_dev.dev = &pdev->dev;