From:   "Katakam, Harini" <harini.katakam@amd.com>
To:     Jakub Kicinski <kuba@kernel.org>,
        Jonas Suhr Christensen <jsc@umbraculum.org>
CC:     Paolo Abeni <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Haoyue Xu <xuhaoyue1@hisilicon.com>,
        huangjunxian <huangjunxian6@hisilicon.com>,
        Wang Qing <wangqing@vivo.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Esben Haabendal <esben@geanix.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Neeli, Srinivas" <srinivas.neeli@amd.com>
Subject: RE: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak
Thread-Topic: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak
Thread-Index: AQHZOZ4bIaLXD56kTU6BDUgiXUw8vK7DWxGAgAACc4CAAHb+AIA1bdoAgAADVwCAAK4eMA==
Date:   Tue, 14 Mar 2023 05:15:01 +0000
Message-ID: <BYAPR12MB47736214A6B4AAF524752A8B9EBE9@BYAPR12MB4773.namprd12.prod.outlook.com>
References: <20230205201130.11303-1-jsc@umbraculum.org>
        <20230205201130.11303-2-jsc@umbraculum.org>
        <5314e0ba3a728787299ca46a60b0a2da5e8ab23a.camel@redhat.com>
        <135b671b1b76978fb147d5fee1e1b922e2c61f26.camel@redhat.com>
        <20230207104204.200da48a@kernel.org>
        <bd639016-8a9c-4479-83b4-32306ad734ac@app.fastmail.com>
 <20230313114858.54828dda@kernel.org>
In-Reply-To: <20230313114858.54828dda@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vIPgAbsGWDbM/vByqejG1dOJfCoHlFGWrsvJqMrGilMl3W+79g+OnYNmHIVt?=
 =?us-ascii?Q?kV7q1xSlfRcvr1VfNVMgGm7PltzGBYPJd8Q478atm47KbsXxpY1vR04YXWiv?=
 =?us-ascii?Q?SzufYTkoMPsCZnN269Tjd8mUKzDG3QfxIkAzlgu9zVBIPAqpx2VFI9xaqBUr?=
 =?us-ascii?Q?lKAbia3kzFYds7dV2sKpLft/iJGQ8lQS/3zcRhuIhOigLKz4IRnJJbQALPKA?=
 =?us-ascii?Q?PXM/3KseUDcmpjj7LOzjGyrBkE9q0FuCIdhGNyIQHB7ghEZBssguaq5WAkrb?=
 =?us-ascii?Q?WmzkMwRRVMd18WVmJhR/QT+ypIm/eSSom3ZORXCbAtM+0OprAfs9TBqrp7vr?=
 =?us-ascii?Q?pnA2UbZjzO19J+xNvQ9tDroZpS6Wxb52KpJasdMUvy+mxWMJThQRYr7zn+/9?=
 =?us-ascii?Q?gBiylQJYBMFry3W7OMzfkLzfOfQRZ8WZc3t6YNvjThtAMjkzYBPiNf2kOslX?=
 =?us-ascii?Q?ciKv5KwWemQ3szFPIf9HuMFegWFa62pcArVkL4+CyAOn7nObuO9zxw0wjm+N?=
 =?us-ascii?Q?F7T5PMw42aGIio0AU+hwUWJufUwvkWSlYmxZwjVi1hFBejws+W/TXGewbrew?=
 =?us-ascii?Q?ztVs/PxeFmy2rTzt/FccnckilpmGRZ03L3E0iadorDKnR/d9Wig8CMY0ORzL?=
 =?us-ascii?Q?JVlT2VtrsHnFxeFQx8a/ZerdOhK1X6NsK3uOhVmdEOTdE3Gsv0Xmev6+I+I2?=
 =?us-ascii?Q?q3OqVTG89oJhiRTY9GPjo8kWZN5Ckt355xWOJsleVIo152+GvcdxA7AzaQns?=
 =?us-ascii?Q?fu6IMVseVRXVRjhOXrYrxLX8zQ2quvGzbcToDyRmAlrNzit0/SgW4aWbyU4s?=
 =?us-ascii?Q?QD4cdvcqhztA+tW4p3R3xkg2nr8SAF10wmacpRiyXllhYXKLCEiYjFGrtAn5?=
 =?us-ascii?Q?1z1hhqEmdUctV8T9vkkwAT1BbE023/obCt8dBcdxTy77LZzAqesKq6Wk8Blm?=
 =?us-ascii?Q?8hvl4LfOvQ9M3HQ0HSjhCGncHWFqrnLs5Wk+aPGEJ1SHydgZvypZEspNMKJm?=
 =?us-ascii?Q?wcqSc9fCraA46JCPSivemEjA8obrYD7triM46ma48D5WeHnAiDCiV3YrahPz?=
 =?us-ascii?Q?Q2wq9+yyotVhGAWmpbLhNsBClQxUmPe4HeKcNHzlPVI748fOojt2Lpk+mynL?=
 =?us-ascii?Q?xxLwV6L0cW0FMn1vU6rON6En6eKXlVRAhuwDMpkH6xKrMY95/mHcfBYuZlqD?=
 =?us-ascii?Q?Z7zu44yRK08kbjLJ3jP1HdclYDBtt8sTwXQGF7/en2Bq3NUvv+7OYirvktrb?=
 =?us-ascii?Q?j7lD7vn59TPpHX52K8Mu5wFxg1fn03/yEUO95+rWjaHS2ku66qpJtmj8E9vb?=
 =?us-ascii?Q?uFDsiTZRUVaBkTkze5l4o1pXKlLDV7s20arfyK9D1TVPg9tOzMkZg9c6O9Qs?=
 =?us-ascii?Q?gnX/NY+2sBGkZ8oFIIOi8X7v+DjSlJ8W4xxmwb4E0nNSSAnLtqOTvb9J6v/U?=
 =?us-ascii?Q?CYTiIkAEGUElif4VSX1G4lYxCqxdDfJ6kPSrDkynn8n2N7qag97YufmHW5ss?=
 =?us-ascii?Q?4o3Cah5aDKmnv/W/n2VsBPEASGTc3bw1F0Z6iWjAJwCNXIrWukwdvirk37YL?=
 =?us-ascii?Q?pSZPfsSD/dS5T23Sks8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4773.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c674a75-d2c7-485b-c42f-08db244b0fe1
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2023 05:15:01.0189
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4Rb/+RBgJYV/5FFCY76YyzUbx4hfqSbBvk95YykCsPw2CDUuIcJ57+Y7ysOXaMnU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6793
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jakub, Jonas,

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, March 14, 2023 12:19 AM
> To: Jonas Suhr Christensen <jsc@umbraculum.org>; Katakam, Harini
> <harini.katakam@amd.com>
> Cc: Paolo Abeni <pabeni@redhat.com>; netdev@vger.kernel.org; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Michal Simek <michal.simek@xilinx.com>; Haoyue Xu
> <xuhaoyue1@hisilicon.com>; huangjunxian <huangjunxian6@hisilicon.com>;
> Wang Qing <wangqing@vivo.com>; Yang Yingliang
> <yangyingliang@huawei.com>; Esben Haabendal <esben@geanix.com>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak
>=20
> On Mon, 13 Mar 2023 19:37:00 +0100 Jonas Suhr Christensen wrote:
> > On Tue, Feb 7, 2023, at 19:42, Jakub Kicinski wrote:
> > > On Tue, 07 Feb 2023 12:36:11 +0100 Paolo Abeni wrote:
> > >> You can either try change to phys type to __be32 (likely not
> > >> suitable for -net and possibly can introduce even more warnings
> > >> elsewhere)
> > >
> > > FWIW that seems like the best option to me as well. Let's ignore the
> > > sparse warning for v3 and try to switch phys to __be32 in a separate
> > > patch for net-next. No point adding force casts just to have to
> > > remove them a week later, given how prevalent the problem is.
> > >
> > >> or explicitly cast the argument.
> >
> > I no longer have access to the hardware, so I'm not rewriting the
> > batch. Feel free to take ownership of it and fix what's needed.
>=20
> Ack.
>=20
> Harini, are you the designated maintainer for this driver? Could you add =
a
> MAINTAINERS entry for it? I don't see one right now.
> And possibly pick up these patches / fix the problem, if you have the cyc=
les?

Sure, Srinivas (cced) will pick up this series and send a v3.
I'll get back on the state of this IP/driver for the maintainers list. Will=
 include
that patch in the beginning of the series as well.

Regards,
Harini