MIME-Version: 1.0
References: <20230314052711.4061652-1-harshit.m.mogalapalli@oracle.com>
In-Reply-To: <20230314052711.4061652-1-harshit.m.mogalapalli@oracle.com>
From:   Qiang Yu <yuq825@gmail.com>
Date:   Tue, 14 Mar 2023 14:22:32 +0800
Message-ID: <CAKGbVbsh4AXo+E4=T0eHeHS_ZuY4QYgRBF+Nbt+BFFMoJOMo0g@mail.gmail.com>
Subject: Re: [PATCH] drm/lima/lima_drv: Add missing unwind goto in lima_pdev_probe()
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     error27@gmail.com, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Eric Anholt <eric@anholt.net>,
        Andreas Baierl <ichgeh@imkreisrum.de>,
        Simon Shields <simon@lineageos.org>,
        Heiko Stuebner <heiko@sntech.de>,
        dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Reviewed-by: Qiang Yu <yuq825@gmail.com>

On Tue, Mar 14, 2023 at 1:27=E2=80=AFPM Harshit Mogalapalli
<harshit.m.mogalapalli@oracle.com> wrote:
>
> Smatch reports:
> drivers/gpu/drm/lima/lima_drv.c:396 lima_pdev_probe() warn:
>         missing unwind goto?
>
> Store return value in err and goto 'err_out0' which has
> lima_sched_slab_fini() before returning.
>
> Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> Only compile tested.
> ---
>  drivers/gpu/drm/lima/lima_drv.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_=
drv.c
> index 7b8d7178d09a..39cab4a55f57 100644
> --- a/drivers/gpu/drm/lima/lima_drv.c
> +++ b/drivers/gpu/drm/lima/lima_drv.c
> @@ -392,8 +392,10 @@ static int lima_pdev_probe(struct platform_device *p=
dev)
>
>         /* Allocate and initialize the DRM device. */
>         ddev =3D drm_dev_alloc(&lima_drm_driver, &pdev->dev);
> -       if (IS_ERR(ddev))
> -               return PTR_ERR(ddev);
> +       if (IS_ERR(ddev)) {
> +               err =3D PTR_ERR(ddev);
> +               goto err_out0;
> +       }
>
>         ddev->dev_private =3D ldev;
>         ldev->ddev =3D ddev;
> --
> 2.38.1
>