Message-ID: <46EE4683.7070205@qumranet.com>
Date: Mon, 17 Sep 2007 11:18:59 +0200
From: Avi Kivity <avi@qumranet.com>
User-Agent: Thunderbird 2.0.0.5 (X11/20070719)
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>, Avi Kivity <avi@qumranet.com>,
       kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
       Nguyen Anh Quynh <aquynh@gmail.com>
Subject: Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c
References: <11900179463203-git-send-email-avi@qumranet.com> <11900179461472-git-send-email-avi@qumranet.com> <20070917091340.GB2083@infradead.org> <46EE45C3.8040302@qumranet.com>
In-Reply-To: <46EE45C3.8040302@qumranet.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1015
Lines: 34

Avi Kivity wrote:
> Christoph Hellwig wrote:
>   
>> On Mon, Sep 17, 2007 at 10:30:43AM +0200, Avi Kivity wrote:
>>   
>>     
>>> From: Nguyen Anh Quynh <aquynh@gmail.com>
>>>
>>> *nopage() in kvm_main.c should only store the type of mmap() fault if
>>> the pointers are not NULL. This patch fixes the problem.
>>>     
>>>       
>> Care to convert it to ->faul while you're at it?
>>   
>>     
>
> I'll add this to my todo, though not sure It'll be in time for .24.  If
> someone sends a patch I'll apply it.
>
>   

I should mention that the converting to use ->fault() is a 15-minute
change; the tricky part is adding backwards compatibility for the
external module package.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/