Message-ID: <4ac7e2e0-9b19-c911-7297-3510e55d6cfd@linaro.org>
Date:   Tue, 14 Mar 2023 07:46:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM
 & INFRA IOMMU
Content-Language: en-US
To:     =?UTF-8?B?WW9uZyBXdSAo5ZC05YuHKQ==?= <Yong.Wu@mediatek.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
Cc:     "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?WW91bGluIFBlaSAo6KO05Y+L5p6XKQ==?= 
        <youlin.pei@mediatek.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        =?UTF-8?B?SmlhbmppYW8gWmVuZyAo5pu+5YGl5aejKQ==?= 
        <Jianjiao.Zeng@mediatek.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        =?UTF-8?B?Q2hlbmdjaSBYdSAo6K645om/6LWQKQ==?= 
        <Chengci.Xu@mediatek.com>,
        =?UTF-8?B?WUYgV2FuZyAo546L5LqR6aOeKQ==?= <YF.Wang@mediatek.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        =?UTF-8?B?TWluZ3l1YW4gTWEgKOmprOm4o+i/nCk=?= 
        <Mingyuan.Ma@mediatek.com>,
        "angelogioacchino.delregno@collabora.com" 
        <angelogioacchino.delregno@collabora.com>
References: <20230307080555.14399-1-yong.wu@mediatek.com>
 <20230307080555.14399-2-yong.wu@mediatek.com>
 <388e2274-d46a-68a4-3e85-5bd597085041@linaro.org>
 <aba29e7fd9a461f2d94c83cf2c7496521433847d.camel@mediatek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <aba29e7fd9a461f2d94c83cf2c7496521433847d.camel@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 14/03/2023 03:41, Yong Wu (吴勇) wrote:
> Hi Krzysztof,
> 
> Thanks very much for your help review.
> 
> On Wed, 2023-03-08 at 11:35 +0100, Krzysztof Kozlowski wrote:
>> On 07/03/2023 09:05, Yong Wu wrote:
>>> From: "Chengci.Xu" <chengci.xu@mediatek.com>
>>>
>>> Add descriptions for mt8188 IOMMU which also use ARM Short-
>>> Descriptor
>>> translation table format.
>>>
>>> In mt8188, there are two smi-common HW and IOMMU, one is for
>>> vdo(video
>>> output), the other is for vpp(video processing pipe). They connects
>>> with different smi-larbs, then some setting(larbid_remap) is
>>> different.
>>> Differentiate them with the compatible string.
>>>
>>> Something like this:
>>>
>>>   IOMMU(VDO)          IOMMU(VPP)
>>>       |                   |
>>> SMI_COMMON_VDO      SMI_COMMON_VPP
>>>
>>> ---------------     ----------------
>>>   |     |    ...      |     |    ...
>>> larb0 larb2  ...    larb1 larb3  ...
>>>
>>> We also have an IOMMU that is for infra master like PCIe.
>>> And infra master don't have the larb and ports.
>>>
>>> Signed-off-by: Chengci.Xu <chengci.xu@mediatek.com>
>>> Reviewed-by: Yong Wu <yong.wu@mediatek.com>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Indeed, I missed broken checkpatch/DCO chain.
> 
> Just confirm what this means.
> 
> Do you mean MAINTAINERS need to be updated since we add a prefix
> "mediatek," for the header file?

No it means, run checkpatch.

Best regards,
Krzysztof