Message-ID: <bd1fbca3-cb57-eab8-9c0d-372c4db516c7@amd.com>
Date:   Tue, 14 Mar 2023 08:26:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v5 1/5] mailbox: zynqmp: fix counts of child nodes
Content-Language: en-US
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Tanmay Shah <tanmay.shah@amd.com>
Cc:     andersson@kernel.org, jaswinder.singh@linaro.org,
        ben.levinsky@amd.com, shubhrajyoti.datta@amd.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-remoteproc@vger.kernel.org
References: <20230311012407.1292118-1-tanmay.shah@amd.com>
 <20230311012407.1292118-2-tanmay.shah@amd.com>
 <20230313193844.GA2071975@p14s>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230313193844.GA2071975@p14s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnFGUUJWbG9mZHArVm1ac1hqNHJpaUZ2T2dBVzlBOUxsYjVhT3J2SElLaHRp?=
 =?utf-8?B?Ykl5OXZJZXRkNENGaHRPcy8yUGF0TDRLNUlyUXN1TmNWVSsva3d5ZXNESEZp?=
 =?utf-8?B?bFpENjlraUxYcmgvd1VRQ0pOcnRvbEZ6S2pVeVBoT2V3bjhHYzVGeDBuT0pt?=
 =?utf-8?B?cS9KZXMrZXd1S3JsSmk4cHFjZkgvSXJrYTZKNzNVakFqQ0VtV0YwV1Y4eW80?=
 =?utf-8?B?bjhTT1N0K01ZOGlPK2srNGdiclZubWUyRXNoT1BBK2s1Y09ReHhyZEpLTDFO?=
 =?utf-8?B?L2h1elR3cUUrbk0zdk1yaHV6OVZCb1liQS9ONm5ON3NLbnJjWW04T05KNGly?=
 =?utf-8?B?dGxCNDA5dEN6VlNEZkd4cWYzZGU1cWhNeVdrVktRZis0OWpGRmRWNTRXUUhw?=
 =?utf-8?B?Ym9ERXRIK3gyT3hsdzFTbkZrcndONVZCVTFRcTNsN2M4bThLaUxaZmcwNU8v?=
 =?utf-8?B?S2ZQR0lvR1Z0b3gzcm9vVFhiMU5IL25sZHVkK1pRS0s0VGp6QVlBSmFmeTJC?=
 =?utf-8?B?WDRNb0ZnbFpGSUU3OXRXK1hyNGZFc2FnazZMSFpQNHM1QkxJMjRCSzA3NUQy?=
 =?utf-8?B?V0hyTVpsNlNPRTlzMUNsTUl5ZjR4UVhwSnFFN0pla3Vab2lRbklEdEJ5dk1X?=
 =?utf-8?B?N0s0UXhpaUhLVnVoeGpDMjBWaTFrYXdQdjIxTUFKVGhPaGw2alhPckFOb3V4?=
 =?utf-8?B?SFFyMlFnaXZQMlg3eCs3ZnFDWWZLYmxNcUFqU0NSQUpMN2ttU3ZqRkltZjNF?=
 =?utf-8?B?bVR3M1hVNE5ZZFp0NW1PWlMzU1VGZTdwU29KZlRBcGJ5SE1SS2x2MlkxOEh1?=
 =?utf-8?B?R3BYNkd0UXEwbEpYcXVQYUs3eVpvWExHbXY1ZWFaNGVLV2h1SUhQdk1hWjBJ?=
 =?utf-8?B?dno3dE1IUUxkRzVOcFYvUnVtV0lJeW1jcTJaUkRaZ3prUHgzTzBPdGkxQzRk?=
 =?utf-8?B?eUE5VEV3MWxDSXZYUVFVaWpsVWo4UURZN3NhWDBnZzdDZmZxSDlMOXJYNVdI?=
 =?utf-8?B?VU9XcCtycnRTalQzRWhRMHdLKzQ0TmlLd1JZc2x2ZitoYUU4eTd0WWJpZnpZ?=
 =?utf-8?B?OEFZa3hQNk1DVXpwSHhlN2VlTU1IZWtzVUdFdHlSNDF6UWpJYVJJNi92STdT?=
 =?utf-8?B?aVUzWndWelFKUnFsd3BGUUpPU1FNV3RUOGRYTGNvS0l0YmtuM2xuZ1dpbkpY?=
 =?utf-8?B?OWFVMXBsR2FMY1pTRDdCcXRLcGtSZTR0VzAzYmk5N3poT3RsRFlsTXlubWh4?=
 =?utf-8?B?bXRKTjllZmNXNW1mRzNjSnEyZzBmekNiakRWU2tZOVZTeC9zSnFvR3R0dHIw?=
 =?utf-8?B?alB5WWFDTEsvSktRWHVVTEFnRWZXWGJaSW10ZThnaHNONm9GT1l4S2NYYkky?=
 =?utf-8?B?QWxnYWdjV1JpdlE5VHhjUTBiZ1Ewcit4My93RytVdkcxOE1tMjRUcjJITEp3?=
 =?utf-8?B?MjY4R041bG1uQUlUdlJCamFkL3E0MjlMTDIwcUY5SEN4MkVhMVAvcGNPTXlO?=
 =?utf-8?B?YW9EVkVudk81NFBOOU1GUmpDeTRuT3I5QmFERHZxMlZQa0FwUkQ0eGZmZStO?=
 =?utf-8?B?L1VtUVNMeSt0SWRxOERwd3pFeU81dDltNTJucHcwS3BpTWM0c3J3RS9vZy94?=
 =?utf-8?B?bU9WU2krT2lZUnZZbkNUdTJwazJiZEVmVjhTQnJ6ZU9MTWs4MDl4RU1jdnRs?=
 =?utf-8?B?MlI5dUFaaE4yT2REMUN2TktZL21HWVFYMWJTSlE3Z2JLbWxmMnowYzlKRTdV?=
 =?utf-8?B?K3lNS3JXR3JkUXpORitMVGh4MUg3YjY3TFEzTytDSVYzdm81TEY3c2VHaUZa?=
 =?utf-8?B?bW1lYmRydmlhcUZGMGdPRUdOdzVlUFFJbmJ2Y2F2dzBDTEsxaDEzdHEwM2JJ?=
 =?utf-8?B?RXEydDFDKzZLdkJiejZPbk1aWWxXbm5tNGZrSFhLZ3l0T1g5SHFDb3V0ZGMy?=
 =?utf-8?B?SnlDejRPQWdYRVdXcEFGYVVoN3N1TnBnekdOQzE5eDF1dU5hT2FFdHBDVGlp?=
 =?utf-8?B?WnVlQmd4b3g4SDROMFNyNDk0cUU5T3FZUDRuR0x2SEVad3RQWmdTMG04bDBT?=
 =?utf-8?B?RThDU2ZDRmJvRTB4N2pCbXZjbHVyemhhQUZadWJRVStpUDNteGNKSDNDQUFG?=
 =?utf-8?Q?Pc9gE3nxDYlm+tgoF3LRIhsHK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84c5cc84-8125-4629-8426-08db245d826f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 07:27:04.5086
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ld/7hC7BSoctPgIPFTe6yxTqqX9kBcU/uMXwhV2jvSHOmCQwn2mZBZSpg57QkjwK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6697
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/13/23 20:38, Mathieu Poirier wrote:
> On Fri, Mar 10, 2023 at 05:24:04PM -0800, Tanmay Shah wrote:
>> If child mailbox node status is disabled it causes
>> crash in interrupt handler. Fix this by assigning
>> only available child node during driver probe.
>>
>> Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller")
>> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>> ---
>>
>> Changes in v5:
>>    - mailbox node count should not be 0 for driver to probe
>>
>>   drivers/mailbox/zynqmp-ipi-mailbox.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
>> index a4c8d23c76e2..ae47fbac38d2 100644
>> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
>> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
>> @@ -634,7 +634,12 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
>>   	struct zynqmp_ipi_mbox *mbox;
>>   	int num_mboxes, ret = -EINVAL;
>>   
>> -	num_mboxes = of_get_child_count(np);
>> +	num_mboxes = of_get_available_child_count(np);
>> +	if (num_mboxes == 0) {
>> +		dev_err(dev, "mailbox nodes not available\n");
>> +		return -EINVAL;
>> +	}
>> +
> 
> This patchset looks good now.  I'll queue it once I get an ack from Michal.

Patches 1,2,3 are acked by me already. 4,5 are remoteproc one which I am not 
testing.
If 4,5 are fine please queue them.

Thanks,
Michal