Date:   Tue, 14 Mar 2023 15:28:32 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Martin Kepplinger <martin.kepplinger@puri.sm>
Cc:     robh@kernel.org, krzysztof.kozlowski@linaro.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        kernel@puri.sm, linux-imx@nxp.com, devicetree@vger.kernel.org,
        phone-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Subject: Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove
 dis_u3_susphy_quirk from usb_dwc3_0
Message-ID: <20230314072832.GC143566@dragon>
References: <20230309204608.237605-1-martin.kepplinger@puri.sm>
 <20230309204608.237605-12-martin.kepplinger@puri.sm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230309204608.237605-12-martin.kepplinger@puri.sm>
Precedence: bulk

On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote:
> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> 
> This reduces power consumption in system suspend by about 10%.

Is there any other impact than this nice power gain?  Otherwise,
I would wonder why the quirk was enabled in the first place.

Shawn

> 
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index 0b4b49fa1392a..f557632f574fa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
>  	#address-cells = <1>;
>  	#size-cells = <0>;
>  	dr_mode = "otg";
> -	snps,dis_u3_susphy_quirk;
>  	usb-role-switch;
>  	status = "okay";
>  
> -- 
> 2.30.2
>