Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78763C7618A for ; Tue, 14 Mar 2023 07:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbjCNHqL (ORCPT ); Tue, 14 Mar 2023 03:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbjCNHqH (ORCPT ); Tue, 14 Mar 2023 03:46:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 590CA94F7A; Tue, 14 Mar 2023 00:45:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3E8F6160B; Tue, 14 Mar 2023 07:45:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31865C433D2; Tue, 14 Mar 2023 07:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678779950; bh=xYFxSC3248b3wowZpsQSJGM3+Hs59s0ozCkaRtr0i7w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uaknvJ1Dijgw4p6/pxdtTD1/eFsoePAIj+unNe0bfSPFIFVKJM19sl4Bdb7L0GjD1 1uY9U1otjheelu+adQe9s2BBcSmO2pzFLNEUbal8juiDK2oLHIbdR3hGQEoNA4ynqn Dg9Qt2UdGjnageQfG9tojQRiZFCbcwRvZOCKSPDzhBSzia8OAEp1oE+ls6yf6iFpaV l7VHpfuBcM8dcyAb5hNPq+xaKkQ7MTple//F7R/S5Q15m91IpKl354SMvh21GK2Cv8 fZ1uzImuYAi/bZnz8EO5vHT660FDohj0O4BCFK8tL1MXOnoyhW3KOW/+z+XD/zuQ/b 03ZZXZKfKHgeA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pbzMz-0001ZP-6n; Tue, 14 Mar 2023 08:46:53 +0100 Date: Tue, 14 Mar 2023 08:46:53 +0100 From: Johan Hovold To: Georgi Djakov Cc: Johan Hovold , Bjorn Andersson , Andy Gross , Konrad Dybcio , Dmitry Baryshkov , Yassine Oudjana , Christophe JAILLET , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] interconnect: qcom: rpm: drop bogus pm domain attach Message-ID: References: <20230313084953.24088-1-johan+linaro@kernel.org> <20230313084953.24088-3-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2023 at 09:58:24PM +0200, Georgi Djakov wrote: > Hi Johan, > > On 13.03.23 10:49, Johan Hovold wrote: > > Any power domain would already have been attached by the platform bus > > code so drop the bogus power domain attach which always succeeds from > > probe. > > > > This effectively reverts commit 7de109c0abe9 ("interconnect: icc-rpm: > > Add support for bus power domain"). > > > > Fixes: 7de109c0abe9 ("interconnect: icc-rpm: Add support for bus power domain") > > Cc: Yassine Oudjana > > Signed-off-by: Johan Hovold > To make it a complete revert, I'll fold this in: > > diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c > index 0badd2c75161..c80819557923 100644 > --- a/drivers/interconnect/qcom/icc-rpm.c > +++ b/drivers/interconnect/qcom/icc-rpm.c > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > #include > #include Thanks for catching that! Johan